Update completion snippet and never recompile completions

Explicitly specify where to put the cursor after inserting a completion
snippet, since Atom does not honor the default setting (the end of the
inserted segment).

Author: fwcd

.vscode/launch.json

@@ -1,6 +1,13 @@
 {
     "version": "0.2.0",
     "configurations": [
+        {
+            "type": "kotlin",
+            "request": "launch",
+            "name": "Kotlin Launch",
+            "projectRoot": "${workspaceFolder}/server",
+            "mainClass": "org.javacs.kt.MainKt"
+        },
         {
             "type": "java",
             "name": "Attach Kotlin Language Server",

server/src/main/kotlin/org/javacs/kt/KotlinTextDocumentService.kt

@@ -57,7 +57,7 @@ class KotlinTextDocumentService(
         get() = sp.content(filePath)
 
     private enum class Recompile {
-        ALWAYS, WAIT_FOR_LINT, AFTER_DOT_WAIT_FOR_LINT, NEVER
+        ALWAYS, AFTER_DOT, WAIT_FOR_LINT, NEVER
     }
 
     private fun recover(position: TextDocumentPositionParams, recompile: Recompile): Pair<CompiledFile, Int> {
@@ -66,12 +66,7 @@ class KotlinTextDocumentService(
         val offset = offset(content, position.position.line, position.position.character)
         val shouldRecompile = when (recompile) {
             Recompile.ALWAYS -> true
-            Recompile.AFTER_DOT_WAIT_FOR_LINT -> {
-                if (offset > 0 && content[offset - 1] == '.') {
-                    debounceLint.waitForPendingTask()
-                }
-                false
-            }
+            Recompile.AFTER_DOT -> offset > 0 && content[offset - 1] == '.'
             Recompile.WAIT_FOR_LINT -> {
                 debounceLint.waitForPendingTask()
                 false
@@ -150,9 +145,8 @@ class KotlinTextDocumentService(
         reportTime {
             LOG.info("Completing at {}", describePosition(position))
 
-            val (file, cursor) = recover(position, Recompile.AFTER_DOT_WAIT_FOR_LINT) // TODO: Investigate when to recompile
+            val (file, cursor) = recover(position, Recompile.NEVER) // TODO: Investigate when to recompile
             val completions = completions(file, cursor, config.completion)
-
             LOG.info("Found {} items", completions.items.size)
 
             Either.forRight<List<CompletionItem>, CompletionList>(completions)

server/src/main/kotlin/org/javacs/kt/completion/RenderCompletionItem.kt

@@ -29,7 +29,7 @@ private val GOOD_IDENTIFIER = Regex("[a-zA-Z]\\w*")
 
 class RenderCompletionItem(val snippetsEnabled: Boolean) : DeclarationDescriptorVisitor<CompletionItem, Unit> {
     private val result = CompletionItem()
-    
+
     private val functionInsertFormat
         get() = if (snippetsEnabled) Snippet else PlainText
 
@@ -95,7 +95,7 @@ class RenderCompletionItem(val snippetsEnabled: Boolean) : DeclarationDescriptor
         return when {
             !snippetsEnabled -> name
             desc.valueParameters.isEmpty() -> "$name()"
-            else -> "$name(${desc.valueParameters.mapIndexed { index, vpd -> "\${${index + 1}:${vpd.name}}" }.joinToString()})"
+            else -> "$name(${desc.valueParameters.mapIndexed { index, vpd -> "\${${index + 1}:${vpd.name}}" }.joinToString()})\$0"
         }
     }