CameraView - add viz params to constructor (openvdb#289)

We had concurrency issues in nanovdb_editor and changing CameraView viz
parameters needs more work to update during runtime. For now the
fallback is to initialize everything in the constructor. The setters
were not yet used outside of the constructor anyway.

Signed-off-by: Petra Hapalova <phapalova@nvidia.com>

Author: phapalova

fvdb/_Cpp.pyi

@@ -1004,8 +1004,14 @@ class Viewer:
         camera_to_world_matrices: torch.Tensor,
         projection_matrices: torch.Tensor,
         image_sizes: torch.Tensor,
-        frustum_near_plane: float = 0.1,
-        frustum_far_plane: float = 1000.0,
+        frustum_near_plane: float,
+        frustum_far_plane: float,
+        axis_length: float,
+        axis_thickness: float,
+        frustum_line_width: float,
+        frustum_scale: float,
+        frustum_color: tuple[float, float, float],
+        visible: bool,
     ) -> CameraView: ...
     def has_camera_view(self, name: str) -> bool: ...
     def get_camera_view(self, name: str) -> CameraView: ...

fvdb/viz/_camera_view.py

@@ -91,14 +91,21 @@ def __init__(
             image_sizes=image_sizes,
             frustum_near_plane=frustum_near_plane,
             frustum_far_plane=frustum_far_plane,
+            axis_length=axis_length,
+            axis_thickness=axis_thickness,
+            frustum_line_width=frustum_line_width,
+            frustum_scale=frustum_scale,
+            frustum_color=frustum_color,
+            visible=enabled,
         )
 
-        view.axis_length = axis_length
-        view.axis_thickness = axis_thickness
-        view.frustum_line_width = frustum_line_width
-        view.frustum_scale = frustum_scale
-        view.frustum_color = frustum_color
-        view.visible = enabled
+        # TODO: needs adjustments on editor's side
+        # view.axis_length = axis_length
+        # view.axis_thickness = axis_thickness
+        # view.frustum_line_width = frustum_line_width
+        # view.frustum_scale = frustum_scale
+        # view.frustum_color = frustum_color
+        # view.visible = enabled
 
     @property
     def enabled(self) -> bool:

src/fvdb/detail/viewer/Viewer.cpp

@@ -374,7 +374,13 @@ Viewer::addCameraView(const std::string &scene_name,
                       const torch::Tensor &projectionMatrices,
                       const torch::Tensor &imageSizes,
                       float frustumNear,
-                      float frustumFar) {
+                      float frustumFar,
+                      float axisLength,
+                      float axisThickness,
+                      float frustumLineWidth,
+                      float frustumScale,
+                      const std::tuple<float, float, float> &frustumColor,
+                      bool visible) {
     TORCH_CHECK(cameraToWorldMatrices.dim() == 3 && cameraToWorldMatrices.size(1) == 4 &&
                     cameraToWorldMatrices.size(2) == 4,
                 "camera_to_world_matrices must have shape [N, 4, 4]");
@@ -465,6 +471,15 @@ Viewer::addCameraView(const std::string &scene_name,
         }
     }
 
+    // Set visualization parameters
+    it->second.setAxisLength(axisLength);
+    it->second.setAxisThickness(axisThickness);
+    it->second.setFrustumLineWidth(frustumLineWidth);
+    it->second.setFrustumScale(frustumScale);
+    it->second.setFrustumColor(
+        std::get<0>(frustumColor), std::get<1>(frustumColor), std::get<2>(frustumColor));
+    it->second.setVisible(visible);
+
     mEditor.editor.add_camera_view_2(&mEditor.editor, sceneToken, &it->second.mView);
 
     return it->second;

src/fvdb/detail/viewer/Viewer.h

@@ -77,7 +77,13 @@ class Viewer {
                               const torch::Tensor &projectionMatrices,
                               const torch::Tensor &imageSizes,
                               float frustumNear,
-                              float frustumFar);
+                              float frustumFar,
+                              float axisLength,
+                              float axisThickness,
+                              float frustumLineWidth,
+                              float frustumScale,
+                              const std::tuple<float, float, float> &frustumColor,
+                              bool visible);
 
     bool
     hasGaussianSplat3dView(const std::string &name) const {

src/python/ViewerBinding.cpp

@@ -209,14 +209,26 @@ bind_viewer(py::module &m) {
                                const torch::Tensor &,
                                const torch::Tensor &,
                                float,
-                               float>(&fvdb::detail::viewer::Viewer::addCameraView),
+                               float,
+                               float,
+                               float,
+                               float,
+                               float,
+                               const std::tuple<float, float, float> &,
+                               bool>(&fvdb::detail::viewer::Viewer::addCameraView),
              py::arg("scene_name"),
              py::arg("name"),
              py::arg("camera_to_world_matrices"),
              py::arg("projection_matrices"),
              py::arg("image_sizes"),
              py::arg("frustum_near_plane"),
              py::arg("frustum_far_plane"),
+             py::arg("axis_length"),
+             py::arg("axis_thickness"),
+             py::arg("frustum_line_width"),
+             py::arg("frustum_scale"),
+             py::arg("frustum_color"),
+             py::arg("visible"),
              py::return_value_policy::reference_internal,
              "Add a named camera view from camera/world and projection matrices")
         .def("has_camera_view",