Merge pull request #110 from riccardodelutio/rdelutio/color-types-casting

Fix color types casting

Author: fwilliams

point_cloud_utils/_mesh_io.py

@@ -288,23 +288,33 @@ def save(self, filename, dtype=np.float32):
             if wcolors.max() > 1.0 or wcolors.min() < 0.0:
                 raise ValueError("Invalid values for wedge colors, must be between 0 and 1 (inclusive)")
 
+        # Meshlab expects colors to be uint8 for PLY files
+        if filename.endswith(".ply"):
+            vcolors = (vcolors * 255.0).astype(np.uint8)
+            fcolors = (fcolors * 255.0).astype(np.uint8)
+            wcolors = (wcolors * 255.0).astype(np.uint8)
+        else:
+            vcolors = vcolors.astype(dtype)
+            fcolors = fcolors.astype(dtype)
+            wcolors = wcolors.astype(dtype)
+
         save_mesh_internal(filename,
                            np.ascontiguousarray(self.vertex_data.positions.astype(dtype)),
                            np.ascontiguousarray(self.vertex_data.normals.astype(dtype)),
                            np.ascontiguousarray(self.vertex_data.texcoords.astype(dtype)),
-                           np.ascontiguousarray((vcolors * 255.0).astype(np.uint8)),
+                           np.ascontiguousarray(vcolors),
                            np.ascontiguousarray(self.vertex_data.quality.astype(dtype)),
                            np.ascontiguousarray(self.vertex_data.radius.astype(dtype)),
                            np.ascontiguousarray(self.vertex_data.tex_ids.astype(np.int32)),
                            np.ascontiguousarray(self.vertex_data.flags.astype(np.int32)),
 
                            np.ascontiguousarray(self.face_data.vertex_ids.astype(np.int32)),
                            np.ascontiguousarray(self.face_data.normals.astype(dtype)),
-                           np.ascontiguousarray((fcolors * 255.0).astype(np.uint8)),
+                           np.ascontiguousarray(fcolors),
                            np.ascontiguousarray(self.face_data.quality.astype(dtype)),
                            np.ascontiguousarray(self.face_data.flags.astype(np.int32)),
 
-                           np.ascontiguousarray((wcolors * 255.0).astype(np.uint8)),
+                           np.ascontiguousarray(wcolors),
                            np.ascontiguousarray(self.face_data.wedge_normals.astype(dtype)),
                            np.ascontiguousarray(self.face_data.wedge_texcoords.astype(dtype)),
                            np.ascontiguousarray(self.face_data.wedge_tex_ids.astype(np.int32)),

setup.py

@@ -91,7 +91,7 @@ def main():
 
     setuptools.setup(
         name="point-cloud-utils",
-        version="0.34.0",
+        version="0.35.0",
         author="Francis Williams",
         author_email="[email protected]",
         description="A Python library for common tasks on 3D point clouds and meshes",