fix: remove Node polyfill by default (#2593)

This doesn't make sense in normal codebases where we try to detect
whether we're in a Node or browser environment. It can be added back
with a simple Vite config such as:

```
import { polyfillNode } from "esbuild-plugin-polyfill-node";

export default {
  optimizeDeps: {
    plugins: [polyfillNode()],
  }
}
```

Author: fwouts

core/package.json

@@ -32,7 +32,6 @@
     "@previewjs/vfs": "^2.1.4",
     "assert-never": "^1.3.0",
     "axios": "^1.7.9",
-    "esbuild-plugin-polyfill-node": "^0.3.0",
     "exclusive-promises": "^1.0.3",
     "express": "^4.21.2",
     "fs-extra": "^11.2.0",

core/src/vite/vite-manager.ts

@@ -11,7 +11,6 @@ import type {
   ReaderListenerInfo,
 } from "@previewjs/vfs";
 import type { Alias } from "@rollup/plugin-alias";
-import { polyfillNode } from "esbuild-plugin-polyfill-node";
 import { exclusivePromiseRunner } from "exclusive-promises";
 import express from "express";
 import fs from "fs-extra";
@@ -369,14 +368,6 @@ export class ViteManager {
         ...config.vite,
         configFile: false,
         root: this.options.rootDir,
-        optimizeDeps: {
-          entries: [],
-          esbuildOptions: {
-            // TODO: Remove this annotation once upgraded to Vite 5.
-            // @ts-ignore incompatible esbuild versions with Vite 4
-            plugins: [polyfillNode()],
-          },
-        },
         server: {
           middlewareMode: true,
           hmr: {
@@ -428,6 +419,7 @@ export class ViteManager {
         define: {
           __filename: undefined,
           __dirname: undefined,
+          process: undefined,
           ...frameworkPluginViteConfig.define,
           ...existingViteConfig?.config.define,
           ...config.vite?.define,

framework-plugins/preact/package.json

@@ -30,6 +30,7 @@
     "@previewjs/storybook-helpers": "^6.0.1",
     "@previewjs/type-analyzer": "^10.1.5",
     "@previewjs/vfs": "^2.1.4",
+    "esbuild-plugin-polyfill-node": "^0.3.0",
     "typescript": "^5.7.2"
   },
   "devDependencies": {

framework-plugins/preact/src/index.ts

@@ -1,6 +1,7 @@
 import type { Component, Story } from "@previewjs/analyzer-api";
 import type { FrameworkPluginFactory } from "@previewjs/core";
 import { createTypeAnalyzer } from "@previewjs/type-analyzer";
+import { polyfillNode } from "esbuild-plugin-polyfill-node";
 import path from "path";
 import ts from "typescript";
 import url from "url";
@@ -65,6 +66,11 @@ const preactFrameworkPlugin: FrameworkPluginFactory = {
       },
       viteConfig: (configuredPlugins) => {
         return {
+          optimizeDeps: {
+            esbuildOptions: {
+              plugins: [polyfillNode()],
+            },
+          },
           resolve: {
             alias: {
               react: "preact/compat",

framework-plugins/react/package.json

@@ -24,7 +24,8 @@
   },
   "dependencies": {
     "@previewjs/analyzer-react": "^0.1.11",
-    "@vitejs/plugin-react": "^4.3.4"
+    "@vitejs/plugin-react": "^4.3.4",
+    "esbuild-plugin-polyfill-node": "^0.3.0"
   },
   "devDependencies": {
     "@playwright/test": "^1.49.1",

framework-plugins/react/src/index.ts

@@ -1,6 +1,7 @@
 import { createAnalyzer } from "@previewjs/analyzer-react";
 import type { FrameworkPluginFactory } from "@previewjs/core";
 import react from "@vitejs/plugin-react";
+import { polyfillNode } from "esbuild-plugin-polyfill-node";
 import path from "path";
 import url from "url";
 import { reactImportsPlugin } from "./react-js-imports-plugin.js";
@@ -41,6 +42,11 @@ const reactFrameworkPlugin: FrameworkPluginFactory = {
           plugin.name.startsWith("vite:react-")
         );
         return {
+          optimizeDeps: {
+            esbuildOptions: {
+              plugins: dependencies["next"] ? [polyfillNode()] : [],
+            },
+          },
           resolve: {
             alias: {
               "react-native": "react-native-web",

framework-plugins/svelte/package.json

@@ -31,6 +31,7 @@
     "@previewjs/type-analyzer": "^10.1.5",
     "@previewjs/vfs": "^2.1.4",
     "@sveltejs/vite-plugin-svelte": "^5.0.2",
+    "esbuild-plugin-polyfill-node": "^0.3.0",
     "fs-extra": "^11.2.0",
     "svelte": "^5.10.0",
     "typescript": "^5.7.2",

framework-plugins/svelte/src/index.ts

@@ -3,6 +3,7 @@ import type { FrameworkPluginFactory } from "@previewjs/core";
 import { createTypeAnalyzer } from "@previewjs/type-analyzer";
 import type sveltekit from "@sveltejs/kit";
 import { svelte } from "@sveltejs/vite-plugin-svelte";
+import { polyfillNode } from "esbuild-plugin-polyfill-node";
 import fs from "fs-extra";
 import path from "path";
 import url from "url";
@@ -74,6 +75,11 @@ const svelteFrameworkPlugin: FrameworkPluginFactory = {
         };
       },
       viteConfig: (configuredPlugins) => ({
+        optimizeDeps: {
+          esbuildOptions: {
+            plugins: [polyfillNode()],
+          },
+        },
         ...(isSvelteKit
           ? {
               define: {