fix(cache): Fixed an issue with dependency collection when triggering an effect.

- Temporarily disable dependency collection when triggering an effect to avoid incorrect tracking.
- Added test cases to verify the fix.

Author: fxdmhtt

cache/src/signal.rs

@@ -34,6 +34,18 @@ impl<T> Signal<T> {
 
     /// Runs all dependent effects.
     fn flush_effects(&self) {
+        // When triggering an Effect, dependencies are not collected for that Effect.
+        //
+        // The issue arises from the creation of Effect A, which may trigger Effect B.
+        // In Effect B, the signal get operation causes incorrect tracking of Effect A.
+        // In this case, dependency tracking for Effect A should not be performed
+        // until Effect B exits the triggering phase.
+        //
+        // The root cause of this issue is a temporary violation of the assumption that
+        // "an Effect is always the end point of the call chain."
+        let creating_effect = unsafe { crate::call_stack::CREATING_EFFECT };
+        unsafe { crate::call_stack::CREATING_EFFECT = false };
+
         self.effects.borrow_mut().retain(|w| {
             if let Some(e) = w.upgrade() {
                 e.run();
@@ -42,6 +54,8 @@ impl<T> Signal<T> {
                 false
             }
         });
+
+        unsafe { crate::call_stack::CREATING_EFFECT = creating_effect };
     }
 
     #[allow(non_snake_case)]
@@ -103,7 +117,8 @@ impl<T> Signal<T> {
         }
 
         // Track effects in the call stack
-        if let Some(e) = call_stack::current_effect_peak()
+        if unsafe { call_stack::CREATING_EFFECT }
+            && let Some(e) = call_stack::current_effect_peak()
             && !self.effects.borrow().iter().any(|w| Weak::ptr_eq(w, &e))
         {
             self.effects.borrow_mut().push(e);

macros/tests/effect.rs

@@ -125,6 +125,21 @@ fn complex_dependency_effect_test() {
     assert_eq!(unsafe { EFFECT_F_CALLED }, 1);
 }
 
+signal!(
+    static mut LOOP_A: i32 = 10;
+);
+
+#[test]
+fn loop_effect_test() {
+    let _ = Rc::into_raw(effect!(|| {
+        LOOP_A();
+    }));
+
+    let _ = Rc::into_raw(effect!(|| {
+        LOOP_A_set(20);
+    }));
+}
+
 signal!(
     static mut SWITCH_A: bool = true;
 );