fix: fix closing of notifications settings modal (#4072)

Author: bistaastha

src/app/fyle/notifications/email-notifications/email-notifications.component.spec.ts

@@ -173,6 +173,16 @@ describe('EmailNotificationsComponent', () => {
   });
 
   describe('closeModal():', () => {
+    it('should dismiss the modal directly when there are no unsaved changes', async () => {
+      component.hasChanges = false;
+
+      await component.closeModal();
+
+      expect(modalController.dismiss).toHaveBeenCalledWith({
+        employeeSettingsUpdated: false,
+      });
+    });
+
     it('should not dismiss the modal directly when there are unsaved changes', async () => {
       component.hasChanges = true;
 

src/app/fyle/notifications/email-notifications/email-notifications.component.ts

@@ -145,6 +145,8 @@ export class EmailNotificationsComponent implements OnInit {
         this.hasChanges = false;
         this.modalController.dismiss({ employeeSettingsUpdated: false });
       }
+    } else {
+      this.modalController.dismiss({ employeeSettingsUpdated: false });
     }
   }
 
@@ -263,7 +265,7 @@ export class EmailNotificationsComponent implements OnInit {
 
   ngOnInit(): void {
     this.isIos = this.platform.is('ios');
-    this.isLongTitle = this.title.length > 25;
+    this.isLongTitle = this.title.length > 20;
     this.updateSelectAll();
 
     const isPushColumnSupportedForTitle =