feat: infra changes for date, time and currency centralization (#4014)

* add stuff

* reference updates

* pipe changes

* reference changes

* comment changes

* revert to separate styles for amount and symbol

* minor

* fix tests

* minor

* minor

* minor

* eslint

* minor

* minor

* minor

* minor

* minor

* minor

* use currency.js

* minor

* minor

* minor

* minor

Author: harshal015

package-lock.json

@@ -77,6 +77,7 @@
     "cordova-plugin-ionic": "^5.5.3",
     "cordova-plugin-native-spinner": "^1.1.4",
     "cordova-plugin-smartlook": "github:smartlook/cordova-smartlook",
+    "currency.js": "^2.0.4",
     "dayjs": "^1.11.7",
     "dotenv": "^16.0.1",
     "driver.js": "^1.3.5",

package.json

@@ -1,8 +1,11 @@
 import { InjectionToken } from '@angular/core';
 import { BehaviorSubject } from 'rxjs';
+import { FormatPreferences } from './core/models/format-preferences.model';
 
 export const PAGINATION_SIZE = new InjectionToken<number>('API Pagination size');
 
 export const DEVICE_PLATFORM = new InjectionToken<'android' | 'ios' | 'web'>('Device Platform');
 
 export const TIMEZONE = new InjectionToken<BehaviorSubject<string>>('UTC');
+
+export const FORMAT_PREFERENCES = new InjectionToken<FormatPreferences>('FORMAT_PREFERENCES');

src/app/constants.ts

@@ -20,7 +20,7 @@ export const draftExpenseTaskSample = deepFreeze({
 
 export const draftExpenseTaskSample2 = deepFreeze({
   hideAmount: true,
-  amount: '76234.47',
+  amount: '₹76234.47',
   count: 339,
   header: 'Complete 339 expenses',
   subheader: 'Fill in missing details for incomplete expenses',
@@ -49,7 +49,7 @@ export const potentailDuplicateTaskSample = deepFreeze({
 
 export const teamReportTaskSample = deepFreeze({
   hideAmount: true,
-  amount: '5177243929.65',
+  amount: '₹5177243929.65',
   count: 2,
   header: "Approve team's 2 reports",
   subheader: 'Approve pending reports from your team.',
@@ -64,7 +64,7 @@ export const teamReportTaskSample = deepFreeze({
 
 export const sentBackReportTaskSample = deepFreeze({
   hideAmount: true,
-  amount: '4500.00',
+  amount: '₹4500.00',
   count: 2,
   header: 'Review sent back reports',
   subheader: 'Fix issues in your reports to resubmit.',
@@ -79,7 +79,7 @@ export const sentBackReportTaskSample = deepFreeze({
 
 export const sentBackReportTaskSingularSample = deepFreeze({
   hideAmount: true,
-  amount: '4500.00',
+  amount: '₹4500.00',
   count: 1,
   header: 'Review sent back report',
   subheader: 'Fix issues in your report to resubmit.',
@@ -109,7 +109,7 @@ export const unreportedExpenseTaskSample = deepFreeze({
 
 export const unreportedExpenseTaskSample2 = deepFreeze({
   hideAmount: true,
-  amount: '30.00',
+  amount: '₹30.00',
   count: 3,
   header: 'Add 3 expenses to report',
   subheader: 'Add complete expenses to a report and submit.',
@@ -124,7 +124,7 @@ export const unreportedExpenseTaskSample2 = deepFreeze({
 
 export const unsubmittedReportTaskSample = deepFreeze({
   hideAmount: true,
-  amount: '93165.91',
+  amount: '₹93165.91',
   count: 2,
   header: 'Submit 2 expense reports',
   subheader: 'Submit reports for approval.',
@@ -139,7 +139,7 @@ export const unsubmittedReportTaskSample = deepFreeze({
 
 export const sentBackAdvanceTaskSample = deepFreeze({
   hideAmount: true,
-  amount: '123370000.00',
+  amount: '₹123370000.00',
   count: 5,
   header: 'Review sent back advances',
   subheader: 'Fix issues in your advances to resubmit.',

src/app/core/mock-data/task.data.ts

@@ -0,0 +1,8 @@
+export interface FormatPreferences {
+  timeFormat: string;
+  currencyFormat: {
+    placement: 'before' | 'after';
+    thousandSeparator: string;
+    decimalSeparator: string;
+  };
+}

src/app/core/models/format-preferences.model.ts

@@ -17,6 +17,7 @@ import { expensesWithDependentFields } from '../mock-data/dependent-field-expens
 import { CustomInput } from '../models/custom-input.model';
 import { mockExpenseData } from '../mock-data/expense-field.data';
 import { getTranslocoTestingModule } from '../testing/transloco-testing.utils';
+import { getFormatPreferenceProviders } from '../testing/format-preference-providers.utils';
 
 describe('CustomInputsService', () => {
   let customInputsService: CustomInputsService;
@@ -42,6 +43,7 @@ describe('CustomInputsService', () => {
           useValue: authServiceSpy,
         },
         DatePipe,
+        ...getFormatPreferenceProviders(),
       ],
     });
 

src/app/core/services/custom-inputs.service.spec.ts

@@ -209,9 +209,7 @@ export class CustomInputsService {
   }
 
   private formatDateCustomProperty(customProperty: CustomField): string {
-    return customProperty.value
-      ? this.datePipe.transform(<string | number | Date>customProperty.value, 'MMM dd, yyyy')
-      : '-';
+    return customProperty.value ? this.datePipe.transform(<string | number | Date>customProperty.value) : '-';
   }
 
   private formatMultiselectCustomProperty(customProperty: CustomField): string {

src/app/core/services/custom-inputs.service.ts

@@ -124,7 +124,7 @@ describe('ReportService', () => {
       spyOn(reportService, 'getReportAutoSubmissionDetails').and.returnValue(of(apiReportAutoSubmissionDetails));
 
       reportService.getAutoSubmissionReportName().subscribe((res) => {
-        expect(res).toEqual('(Automatic Submission On Feb 1)');
+        expect(res).toEqual('(Automatic Submission On Feb 1, 2023)');
         expect(reportService.getReportAutoSubmissionDetails).toHaveBeenCalledTimes(1);
         done();
       });

src/app/core/services/report.service.spec.ts

@@ -100,7 +100,7 @@ export class ReportService {
         const nextReportAutoSubmissionDate = reportAutoSubmissionDetails.data?.next_at;
         if (nextReportAutoSubmissionDate) {
           return this.translocoService.translate('services.report.automaticSubmissionOnDate', {
-            date: this.datePipe.transform(nextReportAutoSubmissionDate, 'MMM d'),
+            date: this.datePipe.transform(nextReportAutoSubmissionDate),
           });
         }
         return null;

src/app/core/services/report.service.ts

@@ -916,7 +916,7 @@ describe('TasksService', () => {
     expect(sentBackAdvanceTask).toEqual([
       {
         hideAmount: true,
-        amount: '123370000.00',
+        amount: '₹123370000.00',
         count: 1,
         header: 'Review sent back advance',
         subheader: 'Fix issues in your advance to resubmit.',
@@ -957,7 +957,7 @@ describe('TasksService', () => {
     expect(sentBackReportTask).toEqual([
       {
         hideAmount: true,
-        amount: '44.53',
+        amount: '₹44.53',
         count: 2,
         header: 'Review sent back reports',
         subheader: 'Fix issues in your reports to resubmit.',
@@ -995,7 +995,7 @@ describe('TasksService', () => {
     expect(tasks).toEqual([
       {
         hideAmount: true,
-        amount: '132573333762.37',
+        amount: '₹132573333762.37',
         count: 1,
         header: 'Complete 1 expense',
         subheader: 'Fill in missing details for incomplete expense',
@@ -1015,9 +1015,8 @@ describe('TasksService', () => {
       .withArgs({
         value: unsubmittedReportsResponse[0].aggregates[1].function_value,
         currencyCode: homeCurrency,
-        skipSymbol: true,
       })
-      .and.returnValue('0.00');
+      .and.returnValue('₹0.00');
 
     const tasks = tasksService.mapAggregateToUnsubmittedReportTask(
       {
@@ -1030,7 +1029,7 @@ describe('TasksService', () => {
     expect(tasks).toEqual([
       {
         hideAmount: true,
-        amount: '0.00',
+        amount: '₹0.00',
         count: 1,
         header: 'Submit 1 expense report',
         subheader: 'Submit report for approval.',
@@ -1071,7 +1070,7 @@ describe('TasksService', () => {
     expect(tasks).toEqual([
       {
         hideAmount: true,
-        amount: '733479.83',
+        amount: '₹733479.83',
         count: 1,
         header: "Approve team's 1 report",
         subheader: 'Approve pending report from your team.',