Revert "feat: reconciliation - disable editing of currency, amount and spend …" (#4003)

This reverts commit 60923ff.

Author: rvab

src/app/core/models/platform/v1/expense.model.ts

@@ -117,5 +117,4 @@ export interface Expense {
   commute_deduction?: CommuteDeduction;
   commute_details?: CommuteDetails;
   commute_details_id?: number;
-  is_reconciled?: boolean;
 }

src/app/fyle/add-edit-expense/add-edit-expense-6.spec.ts

@@ -155,7 +155,6 @@ export function TestCases6(getTestBed) {
       Object.defineProperty(component.fg, 'value', {
         get: () => null,
       });
-      spyOn(component.fg, 'getRawValue').and.returnValue(null);
     }
 
     beforeEach(() => {

src/app/fyle/add-edit-expense/add-edit-expense.page.html

@@ -135,15 +135,6 @@
   @if (fg && !isLoading) {
     <form #formContainer [formGroup]="fg" class="add-edit-expense--form">
       <div>
-        @if (isReconciledExpense()) {
-          <div class="add-edit-expense--alert-offline">
-            <app-fy-alert-info
-              [message]="'addEditExpense.reconciledInfo' | transloco"
-              [type]="'information'"
-            ></app-fy-alert-info>
-          </div>
-        }
-
         @if (showReceiptMandatoryError) {
           <div class="add-edit-expense--alert-offline receipt-mandatory-error">
             <app-fy-alert-info
@@ -370,7 +361,6 @@
                   [touchedInParent]="fg?.controls?.currencyObj?.touched"
                   [validInParent]="fg?.controls?.currencyObj?.valid"
                   [autoCodedData]="autoCodedData"
-                  [disable]="isReconciledExpense()"
                 >
                 </app-currency>
                 @if (fg.controls.currencyObj.touched && !fg.controls.currencyObj.valid) {

src/app/fyle/add-edit-expense/add-edit-expense.page.ts

@@ -669,8 +669,6 @@ export class AddEditExpensePage implements OnInit {
 
   isLoading = true;
 
-  readonly isReconciledExpense = signal<boolean>(false);
-
   readonly isPendingGasCharge = signal<boolean>(false);
 
   readonly isSelectedProjectDisabled = signal(false);
@@ -709,8 +707,7 @@ export class AddEditExpensePage implements OnInit {
   }
 
   getFormValues(): FormValue {
-    // getRawValue is used to get the value of the form fields including the disabled fields
-    return this.fg.getRawValue() as FormValue;
+    return this.fg.value as FormValue;
   }
 
   getFormControl(name: string): AbstractControl {
@@ -2863,18 +2860,12 @@ export class AddEditExpensePage implements OnInit {
       switchMap((expense) => {
         const etxn = this.transactionService.transformExpense(expense);
         this.isPendingGasCharge.set(this.sharedExpensesService.isPendingGasCharge(expense));
+
         if (etxn && etxn.tx.extracted_data) {
           this.autoCodedData = etxn.tx.extracted_data;
           this.autoCodedData.vendor_name = etxn.tx.extracted_data.vendor;
         }
 
-        this.isReconciledExpense.set(expense.is_reconciled);
-
-        if (this.isReconciledExpense()) {
-          this.fg.controls.dateOfSpend.disable();
-          this.fg.controls.currencyObj.disable();
-        }
-
         this.isIncompleteExpense = etxn.tx.state === 'DRAFT';
         this.source = etxn.tx.source || 'MOBILE';
         if (etxn.tx.state === 'DRAFT' && etxn.tx.extracted_data) {

src/app/shared/components/fy-currency/fy-currency.component.html

@@ -30,7 +30,6 @@
           [placeholder]="'fyCurrency.amountPlaceholder' | transloco"
           formControlName="amount"
           [isAmount]="true"
-          [disabled]="disable()"
         >
         </app-fy-number>
       </div>

src/app/shared/components/fy-currency/fy-currency.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, forwardRef, Input, SimpleChanges, OnChanges, inject, input, effect } from '@angular/core';
+import { Component, OnInit, forwardRef, Input, SimpleChanges, OnChanges, inject } from '@angular/core';
 
 import {
   NG_VALUE_ACCESSOR,
@@ -59,19 +59,6 @@ export class FyCurrencyComponent implements ControlValueAccessor, OnInit, OnChan
 
   private translocoService = inject(TranslocoService);
 
-  constructor() {
-    effect(() => {
-      const isDisabled = this.disable();
-      if (this.fg) {
-        if (isDisabled) {
-          this.fg.disable();
-        } else if (this.fg.disabled) {
-          this.fg.enable();
-        }
-      }
-    });
-  }
-
   // TODO: Skipped for migration because:
   //  Your application code writes to the input. This prevents migration.
   @Input() txnDt: Date;
@@ -100,8 +87,6 @@ export class FyCurrencyComponent implements ControlValueAccessor, OnInit, OnChan
   //  Your application code writes to the input. This prevents migration.
   @Input() autoCodedData: ParsedResponse;
 
-  readonly disable = input<boolean>(false);
-
   currencyAutoCodeMessage = '';
 
   amountAutoCodeMessage = '';

src/app/shared/components/fy-number/fy-number.component.html

@@ -2,6 +2,7 @@
   <input
     class="fy-number--input smartlook-show"
     [min]="min()"
+    [disabled]="disabled()"
     [formControl]="fc"
     [placeholder]="placeholder() || ''"
     (blur)="(onBlur)"
@@ -14,6 +15,7 @@
     <input
       class="fy-number--input smartlook-show"
       [min]="min()"
+      [disabled]="disabled()"
       [formControl]="fc"
       [placeholder]="placeholder() || ''"
       (blur)="(onBlur)"
@@ -26,6 +28,7 @@
       <input
         class="fy-number--input smartlook-show"
         [min]="min()"
+        [disabled]="disabled()"
         [formControl]="fc"
         [placeholder]="placeholder() || ''"
         (blur)="(onBlur)"
@@ -37,6 +40,7 @@
       <input
         class="fy-number--input smartlook-show"
         [min]="min()"
+        [disabled]="disabled()"
         [formControl]="fc"
         [placeholder]="placeholder() || ''"
         (blur)="(onBlur)"

src/app/shared/components/fy-number/fy-number.component.ts

@@ -105,11 +105,6 @@ export class FyNumberComponent implements ControlValueAccessor, OnInit, AfterVie
 
   setDisabledState?(isDisabled: boolean): void {
     this.isDisabled = isDisabled;
-    if (isDisabled) {
-      this.fc?.disable();
-    } else {
-      this.fc?.enable();
-    }
   }
 
   onBlur(): void {

src/assets/i18n/en.json

@@ -1576,8 +1576,7 @@
     "projectDisabledError": "Project disabled, select a different one.",
     "pleaseSelectProjectError": "Please select a project.",
     "billableLabel": "Billable",
-    "cancelButton": "Cancel",
-    "reconciledInfo": "Some details can't be edited because this expense is already reconciled."
+    "cancelButton": "Cancel"
   },
   "myExpensesPage": {
     "title": "My expenses",