fix edit expenses (#92)

Author: Hrishabh17

apps/fyle/models.py

@@ -69,49 +69,59 @@ class Meta:
         db_table = 'expenses'
 
     @staticmethod
-    def create_expense_objects(expenses: List[Dict], workspace_id: int):
+    def create_expense_objects(expenses: List[Dict], workspace_id: int, skip_update: bool = True):
         """
         Bulk create expense objects
         """
         expense_objects = []
 
         for expense in expenses:
-            expense_object, _ = Expense.objects.update_or_create(
-                expense_id=expense['id'],
-                workspace_id=workspace_id,
-                defaults={
-                    'employee_email': expense['employee_email'],
-                    'employee_name': expense['employee_name'],
-                    'category': expense['category'],
-                    'sub_category': expense['sub_category'],
-                    'project': expense['project'],
-                    'expense_number': expense['expense_number'],
-                    'org_id': expense['org_id'],
+            expense_data_to_append = None
+            if not skip_update:
+                expense_data_to_append = {
                     'claim_number': expense['claim_number'],
-                    'amount': round(expense['amount'], 2),
-                    'currency': expense['currency'],
-                    'foreign_amount': expense['foreign_amount'],
-                    'foreign_currency': expense['foreign_currency'],
-                    'reimbursable': expense['reimbursable'],
-                    'state': expense['state'],
-                    'vendor': expense['vendor'][:250] if expense['vendor'] else None,
-                    'cost_center': expense['cost_center'],
-                    'corporate_card_id': expense['corporate_card_id'],
-                    'purpose': expense['purpose'],
-                    'report_id': expense['report_id'],
-                    'file_ids': expense['file_ids'],
-                    'spent_at': expense['spent_at'],
                     'approved_at': expense['approved_at'],
-                    'posted_at': expense['posted_at'],
-                    'expense_created_at': expense['expense_created_at'],
-                    'expense_updated_at': expense['expense_updated_at'],
-                    'fund_source': SOURCE_ACCOUNT_MAP[expense['source_account_type']],
-                    'verified_at': expense['verified_at'],
-                    'custom_properties': expense['custom_properties'],
-                    'tax_amount': round(expense['tax_amount'], 2) if expense['tax_amount'] is not None else None,
-                    'tax_group_id': expense['tax_group_id'],
-                    'billable': expense['billable'] if expense['billable'] else False
                 }
+
+            defaults = {
+                'employee_email': expense['employee_email'],
+                'employee_name': expense['employee_name'],
+                'category': expense['category'],
+                'sub_category': expense['sub_category'],
+                'project': expense['project'],
+                'expense_number': expense['expense_number'],
+                'org_id': expense['org_id'],
+                'amount': round(expense['amount'], 2),
+                'currency': expense['currency'],
+                'foreign_amount': expense['foreign_amount'],
+                'foreign_currency': expense['foreign_currency'],
+                'reimbursable': expense['reimbursable'],
+                'state': expense['state'],
+                'vendor': expense['vendor'][:250] if expense['vendor'] else None,
+                'cost_center': expense['cost_center'],
+                'corporate_card_id': expense['corporate_card_id'],
+                'purpose': expense['purpose'],
+                'report_id': expense['report_id'],
+                'file_ids': expense['file_ids'],
+                'spent_at': expense['spent_at'],
+                'posted_at': expense['posted_at'],
+                'expense_created_at': expense['expense_created_at'],
+                'expense_updated_at': expense['expense_updated_at'],
+                'fund_source': SOURCE_ACCOUNT_MAP[expense['source_account_type']],
+                'verified_at': expense['verified_at'],
+                'custom_properties': expense['custom_properties'],
+                'tax_amount': round(expense['tax_amount'], 2) if expense['tax_amount'] is not None else None,
+                'tax_group_id': expense['tax_group_id'],
+                'billable': expense['billable'] if expense['billable'] else False
+            }
+
+            if expense_data_to_append:
+                defaults.update(expense_data_to_append)
+
+            expense_object, _ = Expense.objects.update_or_create(
+                expense_id=expense['id'],
+                workspace_id=workspace_id,
+                defaults=defaults
             )
             expense_objects.append(expense_object)
 

apps/fyle/tasks.py

@@ -169,5 +169,5 @@ def update_non_exported_expenses(data: Dict) -> None:
         expense_obj.append(data)
         expense_objects = FyleExpenses().construct_expense_object(expense_obj, expense.workspace_id)
         Expense.create_expense_objects(
-            expense_objects, expense.workspace_id
+            expense_objects, expense.workspace_id, skip_update=True
         )

quickbooks_desktop_api/settings.py

@@ -127,7 +127,7 @@
     'cached': False,
     'orm': 'default',
     'ack_failures': True,
-    'poll': 1,
+    'poll': 5,
     'max_attempts': 1,
     'attempt_count': 1,
     'retry': 14400,

quickbooks_desktop_api/tests/settings.py

@@ -115,7 +115,7 @@
     'cached': False,
     'orm': 'default',
     'ack_failures': True,
-    'poll': 1,
+    'poll': 5,
     'max_attempts': 1,
     'attempt_count': 1,
     'retry': 14400,

requirements.txt

@@ -29,7 +29,7 @@ fyle==0.37.0
 # Reusable Fyle Packages
 fyle-rest-auth==1.7.2
 fyle-accounting-mappings==1.33.1
-fyle-integrations-platform-connector==1.38.1
+fyle-integrations-platform-connector==1.38.4
 
 # Postgres Dependincies
 psycopg2-binary==2.8.4

tests/test_fyle/fixtures.py

@@ -159,31 +159,6 @@
         },
         'project_id': 330241,
         'purpose': None,
-        'report': {
-            'amount': 12,
-            'approvals': [
-                {
-                    'approver_user': {
-                        'email': 'admin1@fyleforimporrttest.in',
-                        'full_name': 'Theresa Brown',
-                        'id': 'usVN2WTtPqE7'
-                    },
-                    'approver_user_id': 'usVN2WTtPqE7',
-                    'state': 'APPROVAL_DONE'
-                }
-            ],
-            'id': 'rpN41rGGnxNI',
-            'last_approved_at': '2024-05-10T07:53:25.774+00:00',
-            'last_paid_at': None,
-            'last_submitted_at': '2024-05-10T07:53:09.457+00:00',
-            'last_verified_at': '2024-05-10T07:55:02.32928+00:00',
-            'reimbursement_id': 'reimYNNUkKQiWp',
-            'reimbursement_seq_num': 'P/2024/05/T/P/2024/05/R/30',
-            'seq_num': 'C/2024/05/R/45',
-            'settlement_id': 'setUkp31alIp7',
-            'state': 'PAYMENT_PROCESSING',
-            'title': '#5:  May 2024'
-        },
         'report_id': 'rpN41rGGnxNI',
         'report_last_approved_at': '2024-05-10T07:53:25.774000+00:00',
         'report_last_paid_at': None,