error obtaining VCS status with latest fyne-cross-images:windows

[nhsiehABK]

Describe the bug:

We pinned the version of fyne-cross to v1.5.0. Nothing changed in our code besides a new version of fyne-cross-images:windows being available which caused the following error:

error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

In debug mode, the fyne-cross command

fyne-cross windows -cache /REDACTED/fyne-cross-cache -name app.exe -debug -arch amd64 -app-id appid -tags windows -docker-registry docker-repo.com

eventually runs

/usr/bin/docker run --rm -t -w /app -v /REDACTED:/app:z -v /REDACTED/fyne-cross-cache:/go:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows /usr/local/bin/fyne package -os windows -name app.exe -icon /app/fyne-cross/tmp/windows-amd64/Icon.png -appBuild 1 -appVersion 1.0.0 -appID REDACTED -tags windows -release

which pulls the latest image of fyne-cross-images:windows

Digest: sha256:6a055669b713068a8e30f89f0c8571b1310794d0cb908fb054601f2a807bb0dd
Status: Downloaded newer image for docker-repo.com/fyneio/fyne-cross-images:windows

fyne-cross-images should be pinned to specific releases. Especially since the fyne-cross-images release v1.2.0 notes say Note: requires fyne-cross 2.6.1 https://github.com/fyne-io/fyne-cross/pull/289

To Reproduce:

Steps to reproduce the behaviour:

1. `go install github.com/fyne-io/fyne-cross@v1.5.0
2. fyne-cross windows
3. See that the latest images are being pulled

Device and debug info (please complete the following information):

Device info

• OS: Linux
• Version: 5.15.49-linuxkit-pr
• Go version: go 1.22
• fyne-cross version: v1.5.0
• Fyne version: v2.5.0

Debug info

go install github.com/fyne-io/fyne-cross@v1.5.0
go: downloading github.com/fyne-io/fyne-cross v1.5.0
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/Kodeworks/golang-image-ico v0.0.0-20141118225523-73f0f4cfade9
go: downloading github.com/BurntSushi/toml v1.3.2
fyne-cross windows --debug --no-cache -name app.exe -arch amd64 -app-id appid -tags windows -docker-registry docker-repo.com
[i] Target: windows/amd64
&command.localContainerImage{baseContainerImage:command.baseContainerImage{arch:"amd64", os:"windows", id:"windows-amd64", env:map[string]string{"CC":"zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows", "CXX":"zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows", "GOARCH":"amd64", "GOOS":"windows"}, tags:[]string{"windows"}, mount:[]command.containerMountPoint{command.containerMountPoint{name:"project", localHost:"REDACTED", inContainer:"/app"}}, DockerImage:"docker-repo.com/fyneio/fyne-cross-images:windows"}, runner:(*command.localContainerEngine)(0xc0000da090)}
[i] Cleaning target directories...
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows rm -rf /app/fyne-cross/bin/windows-amd64
Unable to find image 'docker-repo.com/fyneio/fyne-cross-images:windows' locally
windows: Pulling from fyneio/fyne-cross-images
af302e5ce9: Pulling fs layer
4c65416bdbb9: Pulling fs layer
85be39d2fb22: Pulling fs layer
8ce8e0da5c32: Pulling fs layer
4f4fb700ef54: Pulling fs layer
5b4519e69c81: Pulling fs layer
84add9ea6dfa: Pulling fs layer
1ff67999894d: Pulling fs layer
c5cc716e5fb9: Pulling fs layer
00f29f9f37ab: Pulling fs layer
1ce9c9b762b2: Pulling fs layer
1ff67999894d: Waiting
c5cc716e5fb9: Waiting
4f4fb700ef54: Waiting
00f29f9f37ab: Waiting
5b4519e69c81: Waiting
84add9ea6dfa: Waiting
8ce8e0da5c32: Waiting
1ce9c9b762b2: Waiting
af302e5c37e9: Download complete
8ce8e0da5c32: Verifying Checksum
8ce8e0da5c32: Download complete
4c65416bdbb9: Verifying Checksum
4c65416bdbb9: Download complete
4f4fb700ef54: Download complete
5b4519e69c81: Verifying Checksum
5b4519e69c81: Download complete
85bed2fb22: Verifying Checksum
85be39d2fb22: Download complete
c5cc716e5fb9: Verifying Checksum
c5cc716e5fb9: Download complete
00f29f9f37ab: Verifying Checksum
00f29f9f37ab: Download complete
1ce9c9b762b2: Verifying Checksum
1ce9c9b762b2: Download complete
84add9ea6dfa: Verifying Checksum
84add9ea6dfa: Download complete
af302e5c37e9: Pull complete
4c656bdbb9: Pull complete
1ff67999894d: Verifying Checksum
1ff67999894d: Download complete
85be39d2fb22: Pull complete
8ce8e0da5c32: Pull complete
4f4fb700ef54: Pull complete
5b4519e69c81: Pull complete
84add9ea6dfa: Pull complete
1ff67999894d: Pull complete
c5cc716e5fb9: Pull complete
00f29f9f37ab: Pull complete
1ce9c9b762b2: Pull complete
Digest: sha256:6a055669b713068a8e30f89f0c8571b1310794d0cb908fb054601f2a807bb0dd
Status: Downloaded newer image for docker-repo.com/fyneio/fyne-cross-images:windows
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows mkdir -p /app/fyne-cross/bin/windows-amd64
[✓] "bin" dir cleaned: /app/fyne-cross/bin/windows-amd64
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows rm -rf /app/fyne-cross/dist/windows-amd64
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e GOOS=windows -e GOARCH=amd64 docker-repo.com/fyneio/fyne-cross-images:windows mkdir -p /app/fyne-cross/dist/windows-amd64
[✓] "dist" dir cleaned: /app/fyne-cross/dist/windows-amd64
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows rm -rf /app/fyne-cross/tmp/windows-amd64
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows mkdir -p /app/fyne-cross/tmp/windows-amd64
[✓] "temp" dir cleaned: /app/fyne-cross/tmp/windows-amd64
[i] Checking for go.mod: REDACTED/go.mod
[✓] go.mod found
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows cp /app/Icon.png /app/fyne-cross/tmp/windows-amd64/Icon.png
[i] Packaging app...
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows /usr/local/bin/fyne version
fyne cli version: v2.5.3
/usr/bin/docker run --rm -t -w /app -v REDACTED:/app:z --platform linux/amd64 --user 0 -e HOME=/tmp -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=windows -e GOARCH=amd64 -e CC=zig cc -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows -e CXX=zig c++ -target x86_64-windows-gnu -Wdeprecated-non-prototype -Wl,--subsystem,windows docker-repo.com/fyneio/fyne-cross-images:windows /usr/local/bin/fyne package -os windows -name app.exe -icon /app/fyne-cross/tmp/windows-amd64/Icon.png -appBuild 1 -appVersion 1.0.0 -appID appid -tags windows -release
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
error building application: exit status 1
[✗] could not package the Fyne app: exit status 1

[nhsiehABK]

When I bump to use fyne-cross@v1.6.1 instead, I still get error obtaining VCS status. Any help appreciated.

[Bluebugs]

Can you do a build with debugging log and show us what it looks like? What version control system do you use?

[nhsiehABK]

@Bluebugs Its in the debug info section. The debug flag right?

[andydotxyz]

What version control system do you use?

This seems like the pertinent question - the error looks like it's coming straight from Go. Either the version control is not recognised or it's not present in the project folder that is passed into fyne-cross...

[nhsiehABK]

We're using gitlab runner and git.

Preparing environment
Waiting for pod gitlab-runners/runner-oxlrrkbg-project to be running, status is Pending
Running on runner-oxlrrkbg-project via gitlab-runner-generic-gke...
Getting source from Git repository
Fetching changes with git depth set to 100...
Initialized empty Git repository in /some-path/.git/
Created fresh repository.
Checking out 2ff60130 as detached HEAD ...
Skipping Git submodules setup

Pinned the image as a workaround

fyne-cross windows -cache /REDACTED/fyne-cross-cache -name app.exe -arch amd64 -app-id appid -tags windows -image docker-repo.com/fyneio/fyne-cross-images@sha256:c23ec6aa3d3fd6441fdb5c1a582644f8348cab136b8e2fe5bc1e4c6286cac84d

[andydotxyz]

Is the .git folder included in the scope passed to Fyne-cross?