Skip to content

Commit 7b40e04

Browse files
authored
Merge pull request #2926 from Shadowcat650/vec-with-capacity
chore: use `Vec::with_capacity` instead of `vec![]` in sse vector decode
2 parents 14109f3 + bedcf47 commit 7b40e04

File tree

11 files changed

+333
-333
lines changed

11 files changed

+333
-333
lines changed

frb_codegen/assets/integration_template/shared/REPLACE_ME_RUST_CRATE_DIR/src/frb_generated.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl SseDecode for Vec<u8> {
125125
// Codec=Sse (Serialization based), see doc to use other codecs
126126
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
127127
let mut len_ = <i32>::sse_decode(deserializer);
128-
let mut ans_ = vec![];
128+
let mut ans_ = Vec::with_capacity(len_ as usize);
129129
for idx_ in 0..len_ {
130130
ans_.push(<u8>::sse_decode(deserializer));
131131
}

frb_codegen/src/library/codegen/generator/codec/sse/ty/general_list.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ pub(super) fn general_list_generate_decode(
4949
"<{}>[]",
5050
ApiDartGenerator::new(mir_inner.clone(), context.as_api_dart_context()).dart_api_type()
5151
),
52-
Lang::RustLang(_) => "vec![]".to_owned(),
52+
Lang::RustLang(_) => "Vec::with_capacity(len_ as usize)".to_owned(),
5353
};
5454
let list_push = match lang {
5555
Lang::DartLang(_) => "add",

frb_example/flutter_package/rust/src/frb_generated.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl SseDecode for Vec<u8> {
125125
// Codec=Sse (Serialization based), see doc to use other codecs
126126
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
127127
let mut len_ = <i32>::sse_decode(deserializer);
128-
let mut ans_ = vec![];
128+
let mut ans_ = Vec::with_capacity(len_ as usize);
129129
for idx_ in 0..len_ {
130130
ans_.push(<u8>::sse_decode(deserializer));
131131
}

frb_example/flutter_via_create/rust/src/frb_generated.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl SseDecode for Vec<u8> {
125125
// Codec=Sse (Serialization based), see doc to use other codecs
126126
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
127127
let mut len_ = <i32>::sse_decode(deserializer);
128-
let mut ans_ = vec![];
128+
let mut ans_ = Vec::with_capacity(len_ as usize);
129129
for idx_ in 0..len_ {
130130
ans_.push(<u8>::sse_decode(deserializer));
131131
}

frb_example/flutter_via_integrate/rust/src/frb_generated.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl SseDecode for Vec<u8> {
125125
// Codec=Sse (Serialization based), see doc to use other codecs
126126
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
127127
let mut len_ = <i32>::sse_decode(deserializer);
128-
let mut ans_ = vec![];
128+
let mut ans_ = Vec::with_capacity(len_ as usize);
129129
for idx_ in 0..len_ {
130130
ans_.push(<u8>::sse_decode(deserializer));
131131
}

frb_example/gallery/rust/src/frb_generated.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ impl SseDecode for Vec<u8> {
128128
// Codec=Sse (Serialization based), see doc to use other codecs
129129
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
130130
let mut len_ = <i32>::sse_decode(deserializer);
131-
let mut ans_ = vec![];
131+
let mut ans_ = Vec::with_capacity(len_ as usize);
132132
for idx_ in 0..len_ {
133133
ans_.push(<u8>::sse_decode(deserializer));
134134
}

frb_example/integrate_third_party/rust/src/frb_generated.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30995,7 +30995,7 @@ impl SseDecode for Vec<MediaStreamTrack> {
3099530995
// Codec=Sse (Serialization based), see doc to use other codecs
3099630996
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3099730997
let mut len_ = <i32>::sse_decode(deserializer);
30998-
let mut ans_ = vec![];
30998+
let mut ans_ = Vec::with_capacity(len_ as usize);
3099930999
for idx_ in 0..len_ {
3100031000
ans_.push(<MediaStreamTrack>::sse_decode(deserializer));
3100131001
}
@@ -31007,7 +31007,7 @@ impl SseDecode for Vec<web_audio_api::AudioParamDescriptor> {
3100731007
// Codec=Sse (Serialization based), see doc to use other codecs
3100831008
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3100931009
let mut len_ = <i32>::sse_decode(deserializer);
31010-
let mut ans_ = vec![];
31010+
let mut ans_ = Vec::with_capacity(len_ as usize);
3101131011
for idx_ in 0..len_ {
3101231012
ans_.push(<web_audio_api::AudioParamDescriptor>::sse_decode(
3101331013
deserializer,
@@ -31021,7 +31021,7 @@ impl SseDecode for Vec<Vec<f32>> {
3102131021
// Codec=Sse (Serialization based), see doc to use other codecs
3102231022
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3102331023
let mut len_ = <i32>::sse_decode(deserializer);
31024-
let mut ans_ = vec![];
31024+
let mut ans_ = Vec::with_capacity(len_ as usize);
3102531025
for idx_ in 0..len_ {
3102631026
ans_.push(<Vec<f32>>::sse_decode(deserializer));
3102731027
}
@@ -31033,7 +31033,7 @@ impl SseDecode for Vec<f32> {
3103331033
// Codec=Sse (Serialization based), see doc to use other codecs
3103431034
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3103531035
let mut len_ = <i32>::sse_decode(deserializer);
31036-
let mut ans_ = vec![];
31036+
let mut ans_ = Vec::with_capacity(len_ as usize);
3103731037
for idx_ in 0..len_ {
3103831038
ans_.push(<f32>::sse_decode(deserializer));
3103931039
}
@@ -31045,7 +31045,7 @@ impl SseDecode for Vec<f64> {
3104531045
// Codec=Sse (Serialization based), see doc to use other codecs
3104631046
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3104731047
let mut len_ = <i32>::sse_decode(deserializer);
31048-
let mut ans_ = vec![];
31048+
let mut ans_ = Vec::with_capacity(len_ as usize);
3104931049
for idx_ in 0..len_ {
3105031050
ans_.push(<f64>::sse_decode(deserializer));
3105131051
}
@@ -31057,7 +31057,7 @@ impl SseDecode for Vec<u8> {
3105731057
// Codec=Sse (Serialization based), see doc to use other codecs
3105831058
fn sse_decode(deserializer: &mut flutter_rust_bridge::for_generated::SseDeserializer) -> Self {
3105931059
let mut len_ = <i32>::sse_decode(deserializer);
31060-
let mut ans_ = vec![];
31060+
let mut ans_ = Vec::with_capacity(len_ as usize);
3106131061
for idx_ in 0..len_ {
3106231062
ans_.push(<u8>::sse_decode(deserializer));
3106331063
}

0 commit comments

Comments
 (0)