-
Notifications
You must be signed in to change notification settings - Fork 382
Introduce conversion between chrono::NaiveDate and DateTime avoiding RustOpaque #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…b_internal generate-run-frb-codegen-command-generate --package frb_example/pure_dart"
|
As far as I can see meanwhile (since my last attempt) the PR template changed in the way that I should have made an example in dart_minimal. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
===========================================
- Coverage 98.57% 68.40% -30.18%
===========================================
Files 464 463 -1
Lines 19202 18589 -613
===========================================
- Hits 18928 12715 -6213
- Misses 274 5874 +5600 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It is better to directly add things in pure_dart etc! :) |
|
I recognized that the regeneration of files resulted in automatically added explicit lifetime annotations. Is this expected, is it a problem, does it depend on the used Rust version? |
|
What next steps are left for me to do to make this PR worth to be merged? |
Feel free to make a separate PR to firstly update code for these!
I am sorry that I am having a very tight deadline recently :( I will try my best to find some time after the ddl to review and merge all pending PRs. At the same time, feel free to use your branch if you need this feature, as long as the critical tests in CI passes then usually the branch is good to use. |
Changes
Fixes #1833
Procedure and Checklist
In order to quickly iterate and avoid slowing down development pace by making CI pass, only the following simplified steps are needed, and I (fzyzcjy) will handle the rest of CI / moving the tests currently (will have more automation in the future).
frb_example/dart_minimal.dart_minimal's CI green.Utility commands
cargo run --manifest-path /path/to/flutter_rust_bridge/frb_codegen/Cargo.toml -- generate./frb_internal test-dart-native --package frb_example/dart_minimal