Changed reaper to delete in the same method as killing because there is no guarantee that the same element remains after std::remove

Author: gabrieldiem

server_src/client_manager.cpp

@@ -73,21 +73,19 @@ void ClientManager::kill_all() {
 
 
 void ClientManager::reap_dead_client_connections() {
-    auto lambda_kill_client_if_dead = [](ClientConnection* client) {
+    auto lambda_kill_and_delete_client_if_dead = [](ClientConnection* client) {
         if (!client->is_connection_alive()) {
             client->kill();
             client->stop();
             client->join();
+            delete client;
             return true;
         }
         return false;
     };
 
-    auto dead_clients_iterator =
-            std::remove_if(this->clients.begin(), this->clients.end(), lambda_kill_client_if_dead);
-
-    auto lambda_clean_client_memory = [](ClientConnection* client) { delete client; };
-    std::for_each(dead_clients_iterator, this->clients.end(), lambda_clean_client_memory);
+    auto dead_clients_iterator = std::remove_if(this->clients.begin(), this->clients.end(),
+                                                lambda_kill_and_delete_client_if_dead);
 
     this->clients.erase(dead_clients_iterator, this->clients.end());
 }