Skip to content

Commit 1915a47

Browse files
committed
tweak app list ui
1 parent 203d262 commit 1915a47

File tree

3 files changed

+16
-23
lines changed

3 files changed

+16
-23
lines changed

fw/application/src/app/desktop/view/app_list_view.c

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,9 @@ static void app_list_view_on_draw(mui_view_t *p_view, mui_canvas_t *p_canvas) {
5050
mini_app_t *app = *ptr_array_get(p_list_view->items, i);
5151
int16_t icon_x = i * ICON_GROUP_WIDTH - scroll_offset + first_offset;
5252
if (icon_x + ICON_GROUP_WIDTH > 0 && icon_x < canvas_width) {
53-
// icon_x = LV_MAX(icon_x, 0);
54-
// if( i == focus){
55-
// uint8_t icon_w = LV_MIN(ICON_WIDTH, canvas_width - icon_x);
56-
// mui_canvas_draw_box(p_canvas, icon_x, ICON_TOP_MARGIN, ICON_WIDTH, ICON_WIDTH);
57-
// mui_canvas_set_draw_color(p_canvas, 0);
58-
// mui_canvas_draw_xbm(p_canvas, icon_x, ICON_TOP_MARGIN, ICON_WIDTH, ICON_HEIGHT, app->icon_32x32->data);
59-
// mui_canvas_set_draw_color(p_canvas, 1);
60-
//}else{
6153
if (app->icon_32x32) {
6254
mui_canvas_draw_xbm(p_canvas, icon_x, ICON_TOP_MARGIN, ICON_WIDTH, ICON_HEIGHT, app->icon_32x32->data);
6355
}
64-
//}
6556
}
6657
}
6758

@@ -86,19 +77,19 @@ static void app_list_view_on_draw(mui_view_t *p_view, mui_canvas_t *p_canvas) {
8677

8778
// dash line
8879
mui_canvas_set_draw_color(p_canvas, 1);
89-
for (uint8_t i = 0; i < canvas_width; i += 2) {
90-
mui_canvas_draw_dot(p_canvas, i, canvas_height - font_height);
80+
for (uint8_t i = 0; i < canvas_width; i += 6) {
81+
mui_canvas_draw_line(p_canvas, i, canvas_height - font_height, i + 3, canvas_height - font_height);
9182
}
9283

9384
// app name
9485
mui_canvas_set_font(p_canvas, u8g2_font_wqy12_t_gb2312a);
9586
mui_canvas_draw_utf8(p_canvas, (canvas_width - name_width) / 2, canvas_height - 1 + p_list_view->name_anim_value,
9687
getLangString(focus_app->name_i18n_key));
9788

98-
// icon in front of name
89+
// left and right icon
9990
mui_canvas_set_font(p_canvas, u8g2_font_siji_t_6x10);
100-
mui_canvas_draw_glyph(p_canvas, (canvas_width - name_width) / 2 - 12,
101-
canvas_height - 1 + p_list_view->name_anim_value, focus_app->icon);
91+
mui_canvas_draw_glyph(p_canvas, 0, canvas_height - 2, 0xe10b);
92+
mui_canvas_draw_glyph(p_canvas, canvas_width - 12, canvas_height - 2, 0xe10a);
10293
}
10394

10495
static void app_list_view_on_input(mui_view_t *p_view, mui_input_event_t *event) {
@@ -135,7 +126,7 @@ static void app_list_view_on_input(mui_view_t *p_view, mui_input_event_t *event)
135126
int32_t scroll_offset = -1 * size * ICON_GROUP_WIDTH;
136127
mui_anim_set_values(&p_app_list_view->icon_anim, scroll_offset, 0);
137128
mui_anim_set_time(&p_app_list_view->icon_anim, ICON_ANIM_LONG_TIME);
138-
}
129+
}
139130
if (mui_list_view_anim_enabled()) {
140131
mui_anim_set_values(&p_app_list_view->name_anim, FONT_HEIGHT, 0);
141132
mui_anim_start(&p_app_list_view->icon_anim);
@@ -164,7 +155,7 @@ static void app_list_view_on_enter(mui_view_t *p_view) {
164155
}
165156

166157
static void app_list_view_on_exit(mui_view_t *p_view) {
167-
app_list_view_t *p_app_list_view = p_view->user_data;
158+
app_list_view_t *p_app_list_view = p_view->user_data;
168159
if (mui_list_view_anim_enabled()) {
169160
mui_anim_stop(&p_app_list_view->icon_anim);
170161
mui_anim_stop(&p_app_list_view->name_anim);

fw/application/src/mui/mui_canvas.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,14 @@ void mui_canvas_draw_rframe(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_
108108
u8g2_DrawRFrame(p_canvas->fb, x, y, width, height, radius);
109109
}
110110

111-
void mui_canvas_draw_xbm(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height, uint8_t *bitmap) {
111+
void mui_canvas_draw_xbm(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height, const uint8_t *bitmap) {
112112
x += p_canvas->offset_x;
113113
y += p_canvas->offset_y;
114114
u8g2_DrawXBM(p_canvas->fb, x, y, width, height, bitmap);
115115
}
116116

117117
void mui_canvas_draw_bitmap(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height,
118-
uint8_t *bitmap) {
118+
const uint8_t *bitmap) {
119119
x += p_canvas->offset_x;
120120
y += p_canvas->offset_y;
121121
u8g2_DrawBitmap(p_canvas->fb, x, y, width, height, bitmap);

fw/application/src/mui/mui_canvas.h

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ void mui_canvas_clear(mui_canvas_t *p_canvas);
2323

2424
uint8_t mui_canvas_get_utf8_bytes(const char *p);
2525

26-
void mui_canvas_set_font(mui_canvas_t *p_canvas, const uint8_t *font);
26+
void mui_canvas_set_font(mui_canvas_t *p_canvas, const uint8_t *font);
2727
uint8_t mui_canvas_draw_utf8(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, const char *str);
2828
int32_t mui_canvas_draw_utf8_clip(mui_canvas_t *p_canvas, int32_t x, int32_t y, const char *text);
2929
uint8_t mui_canvas_draw_glyph(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint16_t encoding);
3030
uint16_t mui_canvas_get_utf8_width(mui_canvas_t *p_canvas, const char *s);
3131

3232
void mui_canvas_set_frame(mui_canvas_t *p_canvas, uint8_t offset_x, uint8_t offset_y, uint8_t width, uint8_t height);
33-
void mui_canvas_get_clip_window(mui_canvas_t *p_canvas, mui_rect_t* p_rect);
34-
void mui_canvas_set_clip_window(mui_canvas_t *p_canvas, mui_rect_t* p_rect);
33+
void mui_canvas_get_clip_window(mui_canvas_t *p_canvas, mui_rect_t *p_rect);
34+
void mui_canvas_set_clip_window(mui_canvas_t *p_canvas, mui_rect_t *p_rect);
3535

3636
uint8_t mui_canvas_get_draw_color(mui_canvas_t *p_canvas);
3737
void mui_canvas_set_draw_color(mui_canvas_t *p_canvas, uint8_t color);
@@ -41,8 +41,10 @@ void mui_canvas_draw_dot(mui_canvas_t *p_canvas, uint8_t x, uint8_t y);
4141
void mui_canvas_draw_rframe(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height,
4242
uint8_t radius);
4343

44-
void mui_canvas_draw_xbm(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height, uint8_t *bitmap);
45-
void mui_canvas_draw_bitmap(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height, uint8_t *bitmap);
44+
void mui_canvas_draw_xbm(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height,
45+
const uint8_t *bitmap);
46+
void mui_canvas_draw_bitmap(mui_canvas_t *p_canvas, uint8_t x, uint8_t y, uint8_t width, uint8_t height,
47+
const uint8_t *bitmap);
4648

4749
uint16_t mui_canvas_string_width(mui_canvas_t *p_canvas, const char *str);
4850

0 commit comments

Comments
 (0)