Skip to content

Commit 249bcc0

Browse files
committed
Use the lazy route table by default for faster initial pageloads
1 parent 36932a9 commit 249bcc0

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/fastify-renderer/src/node/renderers/react/ReactRenderer.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ const staticLocationHook = (path = '/', { record = false } = {}) => {
3737

3838
export class ReactRenderer implements Renderer {
3939
static ROUTE_TABLE_ID = '/@fstr!route-table.js'
40-
static LAZY_ROUTE_TABLE_ID = '/@fstr!lazy-route-table.js'
4140

4241
viteConfig!: ResolvedConfig
4342
devServer?: ViteDevServer
@@ -312,7 +311,9 @@ export class ReactRenderer implements Renderer {
312311
// client side hydration entrypoint for a particular route generated by fastify-renderer
313312
import React from 'react'
314313
import ReactDOM from 'react-dom'
315-
import { routes } from ${JSON.stringify(ReactRenderer.ROUTE_TABLE_ID + '?' + querystring.stringify({ base }))}
314+
import { routes } from ${JSON.stringify(
315+
ReactRenderer.ROUTE_TABLE_ID + '?' + querystring.stringify({ base, lazy: true })
316+
)}
316317
import { Root } from ${JSON.stringify(this.clientModulePath)}
317318
import Layout from ${JSON.stringify(layout)}
318319
import Entrypoint from ${JSON.stringify(entrypoint)}

packages/test-apps/simple-react/test/switching-contexts.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ describe('navigation details', () => {
1212

1313
test('navigating between pages of the same context doesnt trigger a server side render request', async () => {
1414
page.on('request', (request) => {
15+
if (request.url().includes('/.vite/')) return
1516
if (request.headers().accept !== 'application/json') {
16-
throw new Error(`Expecting request to only fetch props, request made: ${request.method()} ${request.url()}`)
17+
throw new Error(`Expecting request to only fetch props, request made: ${request.method()} ${request.url()} $`)
1718
}
1819
})
1920

@@ -22,6 +23,8 @@ describe('navigation details', () => {
2223

2324
test('navigating between pages of different contexts triggers a server side render request', async () => {
2425
page.on('request', (request) => {
26+
if (request.url().includes('/.vite/')) return
27+
2528
if (request.headers().accept === 'application/json') {
2629
throw new Error(`Expecting request to trigger SSR, request made: ${request.method()} ${request.url()}`)
2730
}

0 commit comments

Comments
 (0)