Upgrade lint and move test tsconfig to proper spot

Author: airhorns

.eslintrc.js

@@ -2,7 +2,7 @@ module.exports = {
   parser: '@typescript-eslint/parser',
   parserOptions: {
     tsconfigRootDir: __dirname,
-    project: ['./packages/fastify-renderer/tsconfig.eslint.json', './packages/test-apps/tsconfig.json'],
+    project: ['./packages/fastify-renderer/tsconfig.eslint.json', './packages/test-apps/simple-react/tsconfig.json'],
   },
   settings: {
     react: {

packages/fastify-renderer/package.json

@@ -81,7 +81,7 @@
     "@swc/jest": "^0.2.29",
     "@types/connect": "^3.4.35",
     "@types/jest": "^26.0.24",
-    "@types/node": "^14.17.20",
+    "@types/node": "^18.11.9",
     "@types/react": "^17.0.43",
     "@types/react-dom": "^17.0.11",
     "@types/sanitize-filename": "^1.6.3",
@@ -91,13 +91,12 @@
     "fastify": "^3.29.0",
     "gitpkg": "^1.0.0-beta.2",
     "jest": "^28.1.3",
-    "jest-playwright-preset": "^2.0.0",
     "npm-run-all": "^4.1.5",
     "pino-pretty": "^4.8.0",
     "react": "0.0.0-experimental-4ead6b530",
     "react-dom": "0.0.0-experimental-4ead6b530",
     "rimraf": "^3.0.2",
-    "typescript": "^4.7.4"
+    "typescript": "^5.2.2"
   },
   "files": [
     "client",

packages/test-apps/simple-react/NavigationHistoryTest.tsx

@@ -2,7 +2,7 @@ import React from 'react'
 import { Link, useLocation } from 'fastify-renderer/client/react'
 
 const NavigationHistoryTest = () => {
-  const [path, navigate] = useLocation()
+  const [_path, navigate] = useLocation()
 
   return (
     <>

packages/test-apps/helpers.ts renamed to packages/test-apps/simple-react/helpers.ts

@@ -20,17 +20,14 @@ export const port = 3000 + parseInt(process.env.JEST_WORKER_ID!) - 1
 export const rootURL = `http://localhost:${port}`
 
 beforeAll(async () => {
-  const testPath = expect.getState().testPath as string
+  const testPath = expect.getState().testPath
   // eslint-disable-next-line @typescript-eslint/prefer-regexp-exec
   const testName = slash(testPath).match(/test-apps\/([\w-]+)\//)?.[1]
 
   // if this is a test placed under test-apps/xxx/test/
   // start a fastify server in that directory.
   if (testName) {
-    const testAppsRoot = resolve(__dirname, './')
-    const srcDir = resolve(testAppsRoot, testName)
-
-    const serverEntrypoint = resolve(srcDir, 'server.ts')
+    const serverEntrypoint = resolve(__dirname, 'server.ts')
     if (!fs.existsSync(serverEntrypoint)) {
       throw Error(`Missing server entrypoint file at: ${serverEntrypoint}`)
     }

packages/test-apps/simple-react/package.json

@@ -20,6 +20,12 @@
     "@playwright/test": "^1.39.0",
     "@swc/core": "^1.3.95",
     "@swc/jest": "^0.2.29",
-    "html-validator": "^5.1.18"
+    "@types/jest": "^26.0.24",
+    "@types/node": "^18.11.9",
+    "@types/react": "^17.0.43",
+    "@types/react-dom": "^17.0.11",
+    "html-validator": "^5.1.18",
+    "jest-playwright-preset": "^2.0.0",
+    "typescript": "^5.2.2"
   }
 }

packages/test-apps/simple-react/test/boot-props.spec.ts

@@ -1,6 +1,6 @@
 import { expect } from '@playwright/test'
 import { Page } from 'playwright-chromium'
-import { newTestPage, reactReady, rootURL } from '../../helpers'
+import { newTestPage, reactReady, rootURL } from '../helpers'
 
 describe('boot props', () => {
   let page: Page

packages/test-apps/simple-react/test/imperative-rendering.spec.ts

@@ -1,5 +1,5 @@
 import { Page } from 'playwright-chromium'
-import { newTestPage, reactReady, rootURL } from '../../helpers'
+import { newTestPage, reactReady, rootURL } from '../helpers'
 
 describe('imperative rendering', () => {
   let page: Page

packages/test-apps/simple-react/test/navigation-details.spec.ts

@@ -1,5 +1,5 @@
 import { Page } from 'playwright-chromium'
-import { newTestPage, reactReady, rootURL } from '../../helpers'
+import { newTestPage, reactReady, rootURL } from '../helpers'
 
 describe('navigation details', () => {
   let page: Page

packages/test-apps/simple-react/test/navigation-history.spec.ts

@@ -1,5 +1,5 @@
 import { Page } from 'playwright-chromium'
-import { newTestPage, reactReady, rootURL } from '../../helpers'
+import { newTestPage, reactReady, rootURL } from '../helpers'
 
 describe('navigation details', () => {
   let page: Page

packages/test-apps/simple-react/test/serve.spec.ts

@@ -1,6 +1,6 @@
 import validator from 'html-validator'
 import { Page } from 'playwright-chromium'
-import { newTestPage, reactReady, rootURL } from '../../helpers'
+import { newTestPage, reactReady, rootURL } from '../helpers'
 
 describe('simple-react', () => {
   let page: Page