Reduce test flakiness by awaiting all test navigations

Author: airhorns

packages/test-apps/simple-react/test/navigation-details.spec.ts

@@ -14,6 +14,9 @@ describe('navigation details', () => {
     await page.click('#home-link')
 
     const testCalls: any[] = await page.evaluate('window.test')
+
+    await page.waitForFunction(() => window.test.length === 2)
+
     expect(testCalls).toBeDefined()
     expect(testCalls).toHaveLength(2)
     expect(testCalls[0].isNavigating).toBe(false)
@@ -31,6 +34,8 @@ describe('navigation details', () => {
 
     await page.click('#section-link')
 
+    await page.waitForFunction(() => window.test.length === 3)
+
     const testCalls: any[] = await page.evaluate('window.test')
     expect(testCalls).toBeDefined()
     expect(testCalls[0].isNavigating).toBe(false)
@@ -46,6 +51,8 @@ describe('navigation details', () => {
     await page.goto(`${rootURL}/navigation-test?foo=bar#section`)
     await reactReady(page)
 
+    await page.waitForFunction(() => window.test.length === 3)
+
     const testCalls: any[] = await page.evaluate('window.test')
     expect(testCalls).toBeDefined()
     expect(testCalls).toHaveLength(3)