Formatting updates from oxlint

MillanWangGadget · MillanWangGadget · commit fa3c64b84927 · 2026-02-10T13:15:12.000-05:00
diff --git a/packages/react/cypress/component/auto/table/AutoTableBulkActions.cy.tsx b/packages/react/cypress/component/auto/table/AutoTableBulkActions.cy.tsx
@@ -14,15 +14,15 @@ describeForEachAutoAdapter("AutoTable - Bulk actions", ({ name, adapter: { AutoT
           singleRowCheckbox: (recordId: string | number) => `input[id="Select-${recordId}"]`,
         }
       : name === SUITE_NAMES.POLARIS_WC
-      ? {
-          selectAllCheckbox: `s-checkbox[id^="select-all-"]`,
-          singleRowCheckbox: (recordId: string | number) => `s-checkbox[id$="-${recordId}"]`,
-        }
-      : {
-          // SHADCN
-          selectAllCheckbox: `button[id="AutoTableSelectAllCheckbox"]`,
-          singleRowCheckbox: (recordId: string | number) => `button[id="AutoTableSingleRowCheckbox-${recordId}"]`,
-        };
+        ? {
+            selectAllCheckbox: `s-checkbox[id^="select-all-"]`,
+            singleRowCheckbox: (recordId: string | number) => `s-checkbox[id$="-${recordId}"]`,
+          }
+        : {
+            // SHADCN
+            selectAllCheckbox: `button[id="AutoTableSelectAllCheckbox"]`,
+            singleRowCheckbox: (recordId: string | number) => `button[id="AutoTableSingleRowCheckbox-${recordId}"]`,
+          };
 
   const mockModelMetadata = () => {
     cy.intercept(
diff --git a/packages/react/spec/auto/storybook/table/SelectableDesignSystemAutoTableStory.tsx b/packages/react/spec/auto/storybook/table/SelectableDesignSystemAutoTableStory.tsx
@@ -83,7 +83,7 @@ const PolarisWCAutoTableStory = <
   GivenOptions extends OptionsType,
   SchemaT,
   FinderFunction extends FindManyFunction<GivenOptions, any, SchemaT, any>,
-  Options extends FinderFunction["optionsType"]
+  Options extends FinderFunction["optionsType"],
 >(
   props: AutoTableProps<GivenOptions, SchemaT, FinderFunction, Options>
 ) => {
diff --git a/packages/react/src/auto/hooks/useEnumInputController.tsx b/packages/react/src/auto/hooks/useEnumInputController.tsx
@@ -42,13 +42,10 @@ export const useEnumInputController = (props: AutoEnumInputProps) => {
     [allOptions, searchValue]
   );
 
-  const onChange = useCallback(
-    (...args: any[]) => {
-      fieldProps.onChange(...args);
-      props.afterChange?.(...args);
-    },
-    [fieldProps.onChange, props.afterChange]
-  );
+  const onChange = useCallback((...args: any[]) => {
+    fieldProps.onChange(...args);
+    props.afterChange?.(...args);
+  }, [fieldProps.onChange, props.afterChange]);
 
   const onSelectionChange = useCallback(
     (selected: string | null) => {
diff --git a/packages/react/src/auto/hooks/useTagsForTableCellRenderer.tsx b/packages/react/src/auto/hooks/useTagsForTableCellRenderer.tsx
@@ -34,7 +34,7 @@ export const useTagsForTableCellRenderer = (props: {
         .map((tag) => (maxTagLength && tag.length > maxTagLength ? tag.slice(0, maxTagLength) + "…" : tag)),
       originalLength: formattedTags.length,
     };
-  }, [value]);
+  }, [value, maxTagCount, maxTagLength]);
 
   return {
     allTags,
diff --git a/packages/react/src/auto/polaris-wc/PolarisWCAutoButton.tsx b/packages/react/src/auto/polaris-wc/PolarisWCAutoButton.tsx
@@ -13,7 +13,7 @@ declare let window: any;
 export const PolarisWCAutoButton = <
   GivenOptions extends OptionsType,
   SchemaT,
-  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>
+  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>,
 >(
   props: AutoButtonProps<GivenOptions, SchemaT, ActionFunc> & { id?: string; children?: React.ReactNode }
 ) => {
diff --git a/packages/react/src/auto/polaris-wc/PolarisWCAutoForm.tsx b/packages/react/src/auto/polaris-wc/PolarisWCAutoForm.tsx
@@ -30,7 +30,7 @@ export const PolarisWCAutoFormSkeleton = () => (
 export type PolarisWCAutoFormProps<
   GivenOptions extends OptionsType,
   SchemaT,
-  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>
+  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>,
 > = AutoFormProps<GivenOptions, SchemaT, ActionFunc>;
 
 /**
@@ -39,7 +39,7 @@ export type PolarisWCAutoFormProps<
 export const PolarisWCAutoForm = <
   GivenOptions extends OptionsType,
   SchemaT,
-  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>
+  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>,
 >(
   props: PolarisWCAutoFormProps<GivenOptions, SchemaT, ActionFunc>
 ) => {
@@ -65,7 +65,7 @@ export const PolarisWCAutoForm = <
 const PolarisWCAutoFormComponent = <
   GivenOptions extends OptionsType,
   SchemaT,
-  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>
+  ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>,
 >(
   props: PolarisWCAutoFormProps<GivenOptions, SchemaT, ActionFunc>
 ) => {
diff --git a/packages/react/src/auto/polaris-wc/PolarisWCAutoTable.tsx b/packages/react/src/auto/polaris-wc/PolarisWCAutoTable.tsx
@@ -55,7 +55,7 @@ export type PolarisWCAutoTableProps<
   GivenOptions extends OptionsType,
   SchemaT,
   FinderFunction extends FindManyFunction<GivenOptions, any, SchemaT, any>,
-  Options extends FinderFunction["optionsType"]
+  Options extends FinderFunction["optionsType"],
 > = AutoTableProps<GivenOptions, SchemaT, FinderFunction, Options>;
 
 /**
@@ -70,7 +70,7 @@ export const PolarisWCAutoTable = <
   GivenOptions extends OptionsType,
   SchemaT,
   FinderFunction extends FindManyFunction<GivenOptions, any, SchemaT, any>,
-  Options extends FinderFunction["optionsType"]
+  Options extends FinderFunction["optionsType"],
 >(
   props: PolarisWCAutoTableProps<GivenOptions, SchemaT, FinderFunction, Options>
 ) => {
@@ -87,7 +87,7 @@ const PolarisWCAutoTableComponent = <
   GivenOptions extends OptionsType,
   SchemaT,
   FinderFunction extends FindManyFunction<GivenOptions, any, SchemaT, any>,
-  Options extends FinderFunction["optionsType"]
+  Options extends FinderFunction["optionsType"],
 >(
   props: PolarisWCAutoTableProps<GivenOptions, SchemaT, FinderFunction, Options>
 ) => {
diff --git a/packages/react/src/auto/polaris-wc/commonComponents/PolarisWCDismissibleBadge.tsx b/packages/react/src/auto/polaris-wc/commonComponents/PolarisWCDismissibleBadge.tsx
@@ -1,4 +1,5 @@
-import React, { ComponentProps } from "react";
+import type { ComponentProps } from "react";
+import React from "react";
 import { useHover } from "../../hooks/useHover.js";
 
 /**
diff --git a/packages/react/src/auto/polaris-wc/commonComponents/PolarisWCTruncatedTextWithTooltip.tsx b/packages/react/src/auto/polaris-wc/commonComponents/PolarisWCTruncatedTextWithTooltip.tsx
@@ -26,7 +26,9 @@ export const PolarisWCTruncatedTextWithTooltip = (props: PolarisWCTruncatedTextW
     useScrollWidthCheck: true,
   });
 
-  useEffect(checkOverflow, [text]);
+  useEffect(() => {
+    checkOverflow();
+  }, [checkOverflow, text]);
 
   const [isHovering, hoverProps] = useHover();
 
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoBooleanInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoBooleanInput.tsx
@@ -23,12 +23,13 @@ export const PolarisWCAutoBooleanInput = autoInput((props: PolarisWCAutoBooleanI
   const { field: _field, control: _control, disabled, label: _label, ...rest } = props;
   const { error, fieldProps, metadata } = useBooleanInputController(props);
 
+  const { onChange } = fieldProps;
   const handleChange = useCallback(
     (event: Event) => {
       const target = event.currentTarget as any;
-      fieldProps.onChange(target.checked ?? false);
+      onChange(target.checked ?? false);
     },
-    [fieldProps.onChange]
+    [onChange]
   );
 
   // Ensure label is always a string - metadata.name should be string but TypeScript infers it could be ReactNode
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoEncryptedStringInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoEncryptedStringInput.tsx
@@ -29,7 +29,7 @@ export const PolarisWCAutoEncryptedStringInput = autoInput((props: PolarisWCAuto
       const value =
         typeof eventOrValue === "string"
           ? eventOrValue
-          : (eventOrValue.currentTarget as HTMLInputElement & { value?: string })?.value ?? "";
+          : ((eventOrValue.currentTarget as HTMLInputElement & { value?: string })?.value ?? "");
       stringInputController.onChange(value);
     },
     [stringInputController.onChange]
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoEnumInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoEnumInput.tsx
@@ -33,7 +33,7 @@ export const PolarisWCAutoEnumInput = autoInput((props: PolarisWCAutoEnumInputPr
   const inputLabel: string = typeof labelProp === "string" ? labelProp : String(label ?? "");
 
   // Single select: show selected value in input when not searching; otherwise show search text
-  const singleSelectInputValue = searchQuery.value !== "" ? searchQuery.value : selectedOptions[0] ?? "";
+  const singleSelectInputValue = searchQuery.value !== "" ? searchQuery.value : (selectedOptions[0] ?? "");
 
   const handleSingleInputChange = useCallback(
     (value: string) => {
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoJSONInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoJSONInput.tsx
@@ -38,19 +38,19 @@ export const PolarisWCAutoJSONInput = autoInput((props: PolarisWCAutoJSONInputPr
   // Ensure label is always a string
   const label: string = typeof props.label === "string" ? props.label : String(controllerLabel ?? "");
   const displayError = !isFocused && errorMessage ? `Invalid JSON: ${errorMessage}` : undefined;
-
+  const { onFocus, onBlur } = focusProps;
   const handleFocus = useCallback(
     (event: Event) => {
-      focusProps.onFocus?.(event as any);
+      onFocus?.(event as any);
     },
-    [focusProps.onFocus]
+    [onFocus]
   );
 
   const handleBlur = useCallback(
     (event: Event) => {
-      focusProps.onBlur?.(event as any);
+      onBlur?.(event as any);
     },
-    [focusProps.onBlur]
+    [onBlur]
   );
 
   return (
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoNumberInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoNumberInput.tsx
@@ -32,8 +32,8 @@ export const PolarisWCAutoNumberInput = autoInput((props: PolarisWCAutoNumberInp
     metadata.configuration.decimals > 0
       ? getStepFromNumberOfDecimals(metadata.configuration.decimals)
       : value
-      ? getStepFromNumberOfDecimals(countNumberOfDecimals(`${value}`))
-      : 1;
+        ? getStepFromNumberOfDecimals(countNumberOfDecimals(`${value}`))
+        : 1;
 
   return (
     <s-number-field
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoRolesInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoRolesInput.tsx
@@ -42,6 +42,7 @@ export const PolarisWCAutoRolesInput = autoInput((props: PolarisWCAutoRolesInput
     [options, searchValue]
   );
 
+  const { onChange } = fieldProps;
   const handleOptionClick = useCallback(
     (roleKey: string) => {
       const next = new Set(selectedRoleKeys);
@@ -50,16 +51,16 @@ export const PolarisWCAutoRolesInput = autoInput((props: PolarisWCAutoRolesInput
       } else {
         next.add(roleKey);
       }
-      fieldProps.onChange([...next]);
+      onChange([...next]);
     },
-    [fieldProps.onChange, selectedRoleKeys]
+    [onChange, selectedRoleKeys]
   );
 
   const handleDismissBadge = useCallback(
     (roleKey: string) => {
-      fieldProps.onChange(selectedRoleKeys.filter((k: string) => k !== roleKey));
+      onChange(selectedRoleKeys.filter((k: string) => k !== roleKey));
     },
-    [fieldProps.onChange, selectedRoleKeys]
+    [onChange, selectedRoleKeys]
   );
 
   const verticalContent = useMemo(() => {
diff --git a/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoTextInput.tsx b/packages/react/src/auto/polaris-wc/inputs/PolarisWCAutoTextInput.tsx
@@ -39,13 +39,13 @@ export type PolarisWCTextInputPropsResult = {
  */
 export function usePolarisWCTextInputProps(props: PolarisWCTextInputPropsParams): PolarisWCTextInputPropsResult {
   const stringInputController = useStringInputController(props as AutoTextInputProps);
-
+  const { onChange } = stringInputController;
   const handleChange = useCallback(
     (event: Event) => {
       const target = event.currentTarget as HTMLInputElement & { value?: string };
-      stringInputController.onChange(target.value ?? "");
+      onChange(target.value ?? "");
     },
-    [stringInputController.onChange]
+    [onChange]
   );
 
   const label: string = typeof props.label === "string" ? props.label : String(stringInputController.metadata.name ?? "");
diff --git a/packages/react/src/auto/polaris-wc/inputs/relationships/PolarisWCAutoBelongsToInput.tsx b/packages/react/src/auto/polaris-wc/inputs/relationships/PolarisWCAutoBelongsToInput.tsx
@@ -44,11 +44,11 @@ export const PolarisWCAutoBelongsToInput = autoInput((props: AutoRelationshipInp
       selectedOption && selectedOption.id
         ? { content: selectedOption.primary, key: `selectedRecordTag_${selectedOption.id}` }
         : danglingSelectedRecordId
-        ? {
-            content: <span style={{ color: "red" }}>id: {danglingSelectedRecordId}</span>,
-            key: `selectedRecordTag_${danglingSelectedRecordId}`,
-          }
-        : undefined;
+          ? {
+              content: <span style={{ color: "red" }}>id: {danglingSelectedRecordId}</span>,
+              key: `selectedRecordTag_${danglingSelectedRecordId}`,
+            }
+          : undefined;
 
     return tagConfig ? (
       <div style={{ display: "flex", flexWrap: "wrap", gap: "4px", marginTop: "8px" }}>
diff --git a/packages/react/src/auto/polaris-wc/inputs/relationships/PolarisWCRelatedModelOptions.tsx b/packages/react/src/auto/polaris-wc/inputs/relationships/PolarisWCRelatedModelOptions.tsx
@@ -151,17 +151,18 @@ export const PolarisWCRelatedModelOptionsPopover = (
   }
 ) => {
   const scrollContainerRef = useRef<HTMLDivElement>(null);
+  const { onScrolledToBottom } = props;
 
   const handleScroll = useCallback(() => {
-    if (!scrollContainerRef.current || !props.onScrolledToBottom) return;
+    if (!scrollContainerRef.current || !onScrolledToBottom) return;
 
     const { scrollTop, scrollHeight, clientHeight } = scrollContainerRef.current;
     const isNearBottom = scrollTop + clientHeight >= scrollHeight - 50;
 
     if (isNearBottom) {
-      props.onScrolledToBottom();
+      onScrolledToBottom();
     }
-  }, [props.onScrolledToBottom]);
+  }, [onScrolledToBottom]);
 
   return (
     <PolarisWCPopover
diff --git a/packages/react/src/auto/polaris-wc/submit/PolarisWCSubmitResultBanner.tsx b/packages/react/src/auto/polaris-wc/submit/PolarisWCSubmitResultBanner.tsx
@@ -30,10 +30,11 @@ export const PolarisWCSubmitResultBanner = (props: PolarisWCSubmitResultBannerPr
 export const PolarisWCSubmitSuccessfulBanner = (props: PolarisWCBannerProps) => {
   const { show, hide, successful, title } = useResultBannerController();
 
+  const { onDismiss } = props;
   const handleDismiss = useCallback(() => {
     hide();
-    props.onDismiss?.();
-  }, [hide, props.onDismiss]);
+    onDismiss?.();
+  }, [hide, onDismiss]);
 
   if (!show || !successful) {
     return null;
@@ -49,10 +50,11 @@ export const PolarisWCSubmitSuccessfulBanner = (props: PolarisWCBannerProps) =>
 export const PolarisWCSubmitErrorBanner = (props: PolarisWCBannerProps) => {
   const { show, hide, successful, title } = useResultBannerController();
 
+  const { onDismiss } = props;
   const handleDismiss = useCallback(() => {
     hide();
-    props.onDismiss?.();
-  }, [hide, props.onDismiss]);
+    onDismiss?.();
+  }, [hide, onDismiss]);
 
   if (!show || successful) {
     return null;
diff --git a/packages/react/src/auto/polaris-wc/tableComponents/PolarisWCAutoTableHeaders.tsx b/packages/react/src/auto/polaris-wc/tableComponents/PolarisWCAutoTableHeaders.tsx
@@ -12,13 +12,13 @@ export const SortableTableHeader = (props: { column: TableColumn; isPrimary: boo
   const columnField = column.type === "CustomRenderer" ? column.identifier : column.field;
   const isSorted = sort.column === columnField;
   const isSortable = column.sortable && column.type !== "CustomRenderer";
-
+  const { handleColumnSort } = sort;
   useEffect(() => {
     const el = ref.current;
     if (!el || !isSortable || !columnField) return;
 
     const handleClick = () => {
-      sort.handleColumnSort(columnField);
+      handleColumnSort(columnField);
     };
 
     // Add cursor style for sortable columns
@@ -29,7 +29,7 @@ export const SortableTableHeader = (props: { column: TableColumn; isPrimary: boo
       el.removeEventListener("click", handleClick);
       el.style.cursor = "";
     };
-  }, [sort.handleColumnSort, columnField, isSortable]);
+  }, [handleColumnSort, columnField, isSortable]);
 
   const [isHovered, hoverProps] = useHover();
   // Sort indicator icon
diff --git a/packages/react/src/auto/polaris/PolarisFixedOptionsCombobox.tsx b/packages/react/src/auto/polaris/PolarisFixedOptionsCombobox.tsx
@@ -110,7 +110,7 @@ export const PolarisFixedOptionsCombobox = (props: PolarisFixedOptionsComboboxPr
         setInputValue(selectedValue[0] || "");
       }
     },
-    [callOnChange, options]
+    [callOnChange, options, allowMultiple]
   );
 
   const removeOption = useCallback(
diff --git a/packages/react/src/auto/shadcn/inputs/ShadcnAutoFileInput.tsx b/packages/react/src/auto/shadcn/inputs/ShadcnAutoFileInput.tsx
@@ -76,7 +76,7 @@ export const makeShadcnAutoFileInput = ({
           />
         </div>
       );
-    }, [actionHintParts, validations.onlyImages?.acceptedTypes, props, onFileUpload]);
+    }, [actionHintParts, validations.onlyImages?.acceptedTypes, props, onFileUpload, isFilePickerOpen]);
 
     const inputLabel = props.label ?? (
       <div style={{ display: "flex", gap: "4px" }}>
