Merge pull request #98 from gadget-inc/array-push-multi

airhorns · web-flow · commit a00ebef7e57d · 2024-06-01T14:33:13.000-04:00
Improve QuickArray creation performance
diff --git a/src/array.ts b/src/array.ts
@@ -82,9 +82,7 @@ export class ArrayType<T extends IAnyType> extends BaseType<Array<T["InputType"]
   instantiate(snapshot: this["InputType"] | undefined, context: TreeContext, parent: IStateTreeNode | null): this["InstanceType"] {
     const array = new QuickArray<T>(this, parent, context);
     if (snapshot) {
-      for (let index = 0; index < snapshot?.length; ++index) {
-        array.push(this.childrenType.instantiate(snapshot[index], context, array));
-      }
+      array.push(...snapshot.map((element) => this.childrenType.instantiate(element, context, array)));
     }
     return array as this["InstanceType"];
   }

Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,7 @@ export class ArrayType<T extends IAnyType> extends BaseType<Array<T["InputType"]`
`82`	`82`	`instantiate(snapshot: this["InputType"] \| undefined, context: TreeContext, parent: IStateTreeNode \| null): this["InstanceType"] {`
`83`	`83`	`const array = new QuickArray<T>(this, parent, context);`
`84`	`84`	`if (snapshot) {`
`85`		`- for (let index = 0; index < snapshot?.length; ++index) {`
`86`		`- array.push(this.childrenType.instantiate(snapshot[index], context, array));`
`87`		`- }`
	`85`	`+ array.push(...snapshot.map((element) => this.childrenType.instantiate(element, context, array)));`
`88`	`86`	`}`
`89`	`87`	`return array as this["InstanceType"];`
`90`	`88`	`}`