Cleanup warnings (#350)

Author: Zehir

addons/gaea/editor/create_node_popup.gd

@@ -25,7 +25,7 @@ func _input(event: InputEvent) -> void:
 
 func _on_tool_button_pressed() -> void:
 	tool_popup.position = Vector2(position) + tool_button.get_global_rect().end
-	tool_popup.position.x -= tool_button.size.x
+	tool_popup.position.x -= roundi(tool_button.size.x)
 	tool_popup.popup()
 
 

addons/gaea/editor/create_node_tree.gd

@@ -132,7 +132,7 @@ func _on_search_bar_text_changed(new_text: String) -> void:
 		get_root().set_collapsed_recursive(false)
 
 	var item: TreeItem = get_root()
-	var first_item_found: TreeItem
+	var first_item_found: TreeItem = null
 
 	while item.get_next_in_tree() != null:
 		item = item.get_next_in_tree()
@@ -141,7 +141,7 @@ func _on_search_bar_text_changed(new_text: String) -> void:
 		else:
 			var item_matched = new_text.is_subsequence_ofn(item.get_text(0))
 			if item_matched and item.is_selectable(0):
-				if not first_item_found:
+				if first_item_found == null:
 					first_item_found = item
 				item.visible = true
 				_show_parents_recursive(item)
@@ -182,6 +182,6 @@ func _show_parents_recursive(item: TreeItem) -> void:
 		parent_item = parent_item.get_parent()
 
 
-func _on_search_bar_text_submitted(new_text: String) -> void:
+func _on_search_bar_text_submitted(_new_text: String) -> void:
 	if get_selected() != null:
 		_on_item_activated()

addons/gaea/editor/gradient_visualizer.gd

@@ -1,3 +1,4 @@
+@tool
 extends TextureRect
 
 
@@ -17,8 +18,8 @@ func _ready() -> void:
 
 func update() -> void:
 	var image: Image = Image.create_empty(SIZE.x, SIZE.y, false, Image.FORMAT_RGB8)
-	for x in SIZE.x / CHECKERBOARD_SIZE.x:
-		for y in SIZE.y / CHECKERBOARD_SIZE.y:
+	for x in roundi(float(SIZE.x) / CHECKERBOARD_SIZE.x):
+		for y in roundi(float(SIZE.y) / CHECKERBOARD_SIZE.y):
 			image.fill_rect(Rect2i(
 					Vector2i(x, y) * CHECKERBOARD_SIZE,
 					CHECKERBOARD_SIZE
@@ -39,8 +40,8 @@ func update() -> void:
 		var color: Color = Color.TRANSPARENT if not is_instance_valid(gaea_material) else gaea_material.preview_color
 
 		image.fill_rect(Rect2(
-				Vector2i(start_offset * SIZE.x, 0.0),
-				Vector2i(((end_offset + 0.005) - start_offset) * SIZE.x, SIZE.y)
+				Vector2(start_offset * SIZE.x, 0.0).round(),
+				Vector2(((end_offset + 0.005) - start_offset) * SIZE.x, SIZE.y).round()
 			),
 			color)
 

addons/gaea/editor/graph_edit.gd

@@ -107,8 +107,8 @@ func remove_invalid_connections() -> void:
 			disconnect_node(connection.from_node, connection.from_port, connection.to_node, connection.to_port)
 			continue
 
-		var from_type: GaeaValue.Type = from_node.get_output_port_type(connection.from_port)
-		var to_type: GaeaValue.Type = to_node.get_input_port_type(connection.to_port)
+		var from_type: GaeaValue.Type = from_node.get_output_port_type(connection.from_port) as GaeaValue.Type
+		var to_type: GaeaValue.Type = to_node.get_input_port_type(connection.to_port) as GaeaValue.Type
 		if not is_valid_connection_type(from_type, to_type) and from_type != to_type:
 			disconnect_node(connection.from_node, connection.from_port, connection.to_node, connection.to_port)
 			to_node.notify_connections_updated.call_deferred()

addons/gaea/editor/panel.gd

@@ -31,7 +31,6 @@ var _zooms: Dictionary[GaeaData, float]
 @onready var _window_popout_separator: VSeparator = %WindowPopoutSeparator
 @onready var _window_popout_button: Button = %WindowPopoutButton
 @onready var _bottom_note_label: RichTextLabel = %BottomNote
-@onready var _generate_button: Button = %GenerateButton
 @onready var _about_button: Button = %AboutButton
 @onready var _about_window: AcceptDialog = $AboutWindow
 

addons/gaea/gaea.gd

@@ -10,12 +10,11 @@ var _panel: Control
 var _panel_button: Button
 var _editor_selection: EditorSelection
 var _inspector_plugin: EditorInspectorPlugin
-var _custom_editor_settings: GaeaEditorSettings
 var _custom_project_settings: GaeaProjectSettings
 
 
 func _enter_tree() -> void:
-	_editor_selection = get_editor_interface().get_selection()
+	_editor_selection = EditorInterface.get_selection()
 	_editor_selection.selection_changed.connect(_on_selection_changed)
 
 	_container = MarginContainer.new()

addons/gaea/graph/components/argument_editors/argument_editor.gd

@@ -8,6 +8,7 @@ extends Control
 ## This class can be extended to create editors for the different value types in Gaea.
 
 ## Emitted when the value is changed using the editor.
+@warning_ignore("unused_signal")
 signal argument_value_changed(new_value: Variant)
 
 var type: GaeaValue.Type

addons/gaea/graph/components/argument_editors/number_argument_editor.gd

@@ -29,7 +29,9 @@ func _configure() -> void:
 func get_arg_value() -> Variant:
 	if super() != null:
 		return super()
-	return float(spin_box.value) if type == GaeaValue.Type.FLOAT else int(spin_box.value)
+	if type == GaeaValue.Type.FLOAT:
+		return float(spin_box.value)
+	return int(spin_box.value)
 
 
 func set_arg_value(new_value: Variant) -> void:

addons/gaea/graph/graph_nodes/generic_classes/constant.gd

@@ -10,10 +10,10 @@ func _get_arguments_list() -> Array[StringName]:
 	return [&"value"]
 
 
-func _get_argument_type(arg_name: StringName) -> GaeaValue.Type:
+func _get_argument_type(_arg_name: StringName) -> GaeaValue.Type:
 	return get_type()
 
-func _get_argument_display_name(arg_name: StringName) -> String:
+func _get_argument_display_name(_arg_name: StringName) -> String:
 	return ""
 
 
@@ -29,7 +29,7 @@ func _get_output_ports_list() -> Array[StringName]:
 	return [&"constant"]
 
 
-func _get_overridden_output_port_idx(output_name: StringName) -> int:
+func _get_overridden_output_port_idx(_output_name: StringName) -> int:
 	return 0
 
 

addons/gaea/graph/graph_nodes/generic_classes/number_operation.gd

@@ -124,14 +124,14 @@ func _get_output_ports_list() -> Array[StringName]:
 	return [&"result"]
 
 
-func _get_output_port_display_name(output_name: StringName) -> String:
+func _get_output_port_display_name(_output_name: StringName) -> String:
 	return OPERATION_DEFINITIONS[get_enum_selection(0)].output
 
 
 
 func _get_data(output_port: StringName, _area: AABB, generator_data: GaeaData) -> Variant:
 	_log_data(output_port, generator_data)
-	var operation: Operation = get_enum_selection(0)
+	var operation: Operation = get_enum_selection(0) as Operation
 	var args: Array
 	for arg_name: StringName in OPERATION_DEFINITIONS[operation].args:
 		args.append(_get_arg(arg_name, _area, generator_data))