Simplify SystemEnvBehaviour

Author: gaggle

lib/system_env_behaviour.ex renamed to lib/behaviours/system_env_behaviour.ex

@@ -1,6 +1,6 @@
-defmodule SystemEnvBehaviour do
+defmodule ElixirScript.Behaviours.SystemEnvBehaviour do
   @moduledoc """
-  The abstract behaviour of SystemEnvBehaviour
+  The abstract behaviour of System get_env functions
   """
   @callback get_env() :: %{optional(String.t()) => String.t()}
   @callback get_env(String.t(), String.t() | nil) :: String.t() | nil

lib/context.ex

@@ -62,5 +62,5 @@ defmodule ElixirScript.Context do
   defp parse_int(nil), do: nil
   defp parse_int(value), do: String.to_integer(value)
 
-  defp system_env_impl, do: Application.get_env(:context, :system_env, SystemEnvImpl)
+  defp system_env_impl, do: Application.get_env(:context, :system_env, System)
 end

lib/system_env_impl.ex

@@ -9,7 +9,7 @@ defmodule ElixirScript.ContextTest do
 
   describe "from_github_environment/0" do
     test "returns a Context struct with default values when environment variables are not set" do
-      stub(SystemEnvBehaviourMock, :get_env, fn varname, default ->
+      stub(SystemEnvMock, :get_env, fn varname, default ->
         GitHubWorkflowRun.env()[varname] || default
       end)
 

test/context_test.exs

@@ -56,7 +56,7 @@ defmodule ElixirScript.E2eTest do
 
   describe "end-to-end tests" do
     test "run e2e tests" do
-      stub(SystemEnvBehaviourMock, :get_env, fn varname, default ->
+      stub(SystemEnvMock, :get_env, fn varname, default ->
         GitHubWorkflowRun.env()[varname] || default
       end)
 

test/e2e_test.exs

@@ -7,7 +7,7 @@ defmodule ElixirScript.ScriptRunnerTest do
   alias Test.Fixtures.GitHubWorkflowRun
 
   setup do
-    stub(SystemEnvBehaviourMock, :get_env, fn varname, default ->
+    stub(SystemEnvMock, :get_env, fn varname, default ->
       GitHubWorkflowRun.env()[varname] || default
     end)
 

test/script_runner_test.exs

@@ -1,4 +1,4 @@
-Mox.defmock(SystemEnvBehaviourMock, for: SystemEnvBehaviour)
-Application.put_env(:context, :system_env, SystemEnvBehaviourMock)
+Mox.defmock(SystemEnvMock, for: ElixirScript.Behaviours.SystemEnvBehaviour)
+Application.put_env(:context, :system_env, SystemEnvMock)
 
 ExUnit.start()