style: apply auto fixes

Author: gajus

package.json

@@ -22,7 +22,7 @@
     "ajv": "^8.6.3",
     "babel-plugin-add-module-exports": "^1.0.4",
     "eslint": "^8.1.0",
-    "eslint-config-canonical": "^32.1.1",
+    "eslint-config-canonical": "^32.6.0",
     "eslint-plugin-eslint-plugin": "^4.0.1",
     "gitdown": "^3.1.4",
     "glob": "^7.2.0",

src/bin/addAssertions.js

@@ -23,9 +23,9 @@ const formatCodeSnippet = (setup) => {
   paragraphs.push(setup.code);
 
   if (setup.errors) {
-    setup.errors.forEach((message) => {
+    for (const message of setup.errors) {
       paragraphs.push('// Message: ' + message.message);
-    });
+    }
   }
 
   if (setup.rules) {

src/bin/checkTests.js

@@ -10,6 +10,7 @@ import {
 const getTestIndexRules = () => {
   const content = fs.readFileSync(path.resolve(__dirname, '../../tests/rules/index.js'), 'utf-8');
 
+  // eslint-disable-next-line unicorn/no-array-reduce
   const result = content.split('\n').reduce((acc, line) => {
     if (acc.inRulesArray) {
       if (line === '];') {

src/rules/defineFlowType.js

@@ -68,9 +68,9 @@ const create = (context) => {
       globalScope = context.getScope();
     },
     TypeParameterDeclaration (node) {
-      node.params.forEach((param) => {
+      for (const param of node.params) {
         makeDefined(param);
-      });
+      }
     },
   };
 };

src/rules/noDupeKeys.js

@@ -68,7 +68,7 @@ const create = (context) => {
     // filter out complex object types, like ObjectTypeSpreadProperty
     const identifierNodes = _.filter(node.properties, {type: 'ObjectTypeProperty'});
 
-    _.forEach(identifierNodes, (identifierNode) => {
+    for (const identifierNode of identifierNodes) {
       const needle = {name: getParameterName(identifierNode, context)};
 
       if (identifierNode.value.type === 'FunctionTypeAnnotation') {
@@ -86,7 +86,7 @@ const create = (context) => {
       } else {
         haystack.push(needle);
       }
-    });
+    }
   };
 
   return {

src/rules/noFlowFixMeComments.js

@@ -25,7 +25,7 @@ const create = (context) => {
   const handleComment = function (comment) {
     const value = comment.value.trim();
 
-    if (value.match(/\$FlowFixMe/u) && !passesExtraRegex(value)) {
+    if (/\$FlowFixMe/u.test(value) && !passesExtraRegex(value)) {
       context.report(comment, message + extraMessage);
     }
   };
@@ -41,13 +41,14 @@ const create = (context) => {
     },
 
     Program () {
-      context
+      for (const comment of context
         .getSourceCode()
         .getAllComments()
-        .filter((comment) => {
-          return comment.type === 'Block' || comment.type === 'Line';
-        })
-        .forEach(handleComment);
+        .filter((node) => {
+          return node.type === 'Block' || node.type === 'Line';
+        })) {
+        handleComment(comment);
+      }
     },
   };
 };

src/rules/requireInexactType.js

@@ -12,7 +12,7 @@ const create = (context) => {
     ObjectTypeAnnotation (node) {
       const {inexact, exact} = node;
 
-      if (!node.hasOwnProperty('inexact')) {
+      if (!Object.prototype.hasOwnProperty.call(node, 'inexact')) {
         return;
       }
 

src/rules/requireParameterType.js

@@ -38,6 +38,7 @@ const create = iterateFunctionNodes((context) => {
       return;
     }
 
+    // eslint-disable-next-line unicorn/no-array-for-each
     _.forEach(functionNode.params, (identifierNode) => {
       const parameterName = getParameterName(identifierNode, context);
 

src/rules/requireReturnType.js

@@ -48,7 +48,9 @@ const create = (context) => {
   const annotateUndefined = _.get(context, 'options[1].annotateUndefined') || 'never';
   const skipArrows = _.get(context, 'options[1].excludeArrowFunctions') || false;
 
+  // eslint-disable-next-line unicorn/no-array-callback-reference
   const excludeMatching = _.get(context, 'options[1].excludeMatching', []).map(makeRegExp);
+  // eslint-disable-next-line unicorn/no-array-callback-reference
   const includeOnlyMatching = _.get(context, 'options[1].includeOnlyMatching', []).map(makeRegExp);
 
   const targetNodes = [];

src/rules/requireVariableType.js

@@ -49,6 +49,7 @@ const create = (context) => {
         return;
       }
 
+      // eslint-disable-next-line unicorn/no-array-for-each
       _.forEach(variableDeclaration.declarations, (variableDeclarator) => {
         const identifierNode = _.get(variableDeclarator, 'id');
         const identifierName = _.get(identifierNode, 'name');