Skip to content

Commit 04d5ba0

Browse files
committed
Merge branch 'master' into add-more-type-checks-to-valid-types
* master: refactor: fix code comment docs(require-description, require-example, require-param, require-returns): add reference to potentially applicable settings, removing reference to deprecated items docs: make explicit default for setting `ignorePrivate` and clarify setting
2 parents 38a13e7 + dd61177 commit 04d5ba0

File tree

7 files changed

+11
-5
lines changed

7 files changed

+11
-5
lines changed

.README/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ You can then selectively add to or override the recommended rules.
121121
### Allow `@private` to disable rules for that comment block
122122

123123
- `settings.jsdoc.ignorePrivate` - Disables all rules for the comment block
124-
on which it occurs.
124+
on which a `@private` tag occurs. Defaults to `false`.
125125

126126
### Alias Preference
127127

.README/rules/require-description.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,6 @@ An options object may have any of the following properties:
2121
|Tags|`description`|
2222
|Aliases|`desc`|
2323
|Options|`contexts`, `exemptedBy`|
24+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
2425

2526
<!-- assertions requireDescription -->

.README/rules/require-example.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,6 @@ This rule has an object option:
2121
|Context|`ArrowFunctionExpression`, `FunctionDeclaration`, `FunctionExpression`|
2222
|Tags|`example`|
2323
|Options|`exemptedBy`, `avoidExampleOnConstructors`|
24+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
2425

2526
<!-- assertions requireExample -->

.README/rules/require-param.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ An options object accepts one optional property:
1515
|Tags|`param`|
1616
|Aliases|`arg`, `argument`|
1717
|Options|`exemptedBy`|
18-
|Settings|`allowOverrideWithoutParam`, `allowImplementsWithoutParam`, `allowAugmentsExtendsWithoutParam`|
18+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
1919

2020
<!-- assertions requireParam -->

.README/rules/require-returns.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,6 @@ Requires returns are documented.
2222
|Tags|`returns`|
2323
|Aliases|`return`|
2424
|Options|`exemptedBy`, `forceRequireReturn`, `forceReturnsWithAsync`|
25+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
2526

2627
<!-- assertions requireReturns -->

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ You can then selectively add to or override the recommended rules.
164164
### Allow <code>@private</code> to disable rules for that comment block
165165

166166
- `settings.jsdoc.ignorePrivate` - Disables all rules for the comment block
167-
on which it occurs.
167+
on which a `@private` tag occurs. Defaults to `false`.
168168

169169
<a name="eslint-plugin-jsdoc-settings-alias-preference"></a>
170170
### Alias Preference
@@ -3721,6 +3721,7 @@ An options object may have any of the following properties:
37213721
|Tags|`description`|
37223722
|Aliases|`desc`|
37233723
|Options|`contexts`, `exemptedBy`|
3724+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
37243725

37253726
The following patterns are considered problems:
37263727

@@ -3915,6 +3916,7 @@ This rule has an object option:
39153916
|Context|`ArrowFunctionExpression`, `FunctionDeclaration`, `FunctionExpression`|
39163917
|Tags|`example`|
39173918
|Options|`exemptedBy`, `avoidExampleOnConstructors`|
3919+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
39183920

39193921
The following patterns are considered problems:
39203922

@@ -5204,7 +5206,7 @@ An options object accepts one optional property:
52045206
|Tags|`param`|
52055207
|Aliases|`arg`, `argument`|
52065208
|Options|`exemptedBy`|
5207-
|Settings|`allowOverrideWithoutParam`, `allowImplementsWithoutParam`, `allowAugmentsExtendsWithoutParam`|
5209+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
52085210

52095211
The following patterns are considered problems:
52105212

@@ -6138,6 +6140,7 @@ Requires returns are documented.
61386140
|Tags|`returns`|
61396141
|Aliases|`return`|
61406142
|Options|`exemptedBy`, `forceRequireReturn`, `forceReturnsWithAsync`|
6143+
|Settings|`overrideReplacesDocs`, `augmentsExtendsReplacesDocs`, `implementsReplacesDocs`|
61416144

61426145
The following patterns are considered problems:
61436146

src/iterateJsdoc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ const getSettings = (context) => {
267267
// All rules
268268
settings.ignorePrivate = Boolean(_.get(context, 'settings.jsdoc.ignorePrivate'));
269269

270-
// `check-tag-names` and many require/param rules
270+
// `check-tag-names` and many returns/param rules
271271
settings.tagNamePreference = _.get(context, 'settings.jsdoc.tagNamePreference') || {};
272272

273273
// `check-types` and `no-undefined-types`

0 commit comments

Comments
 (0)