fix (require-returns): remove extra space in reported error

fix (valid-types): ensure memberof type ending in member type operator (yet still bad) always includes whole type in error message
testing: add some uncovered tests; fix indentation
refactor: unused method, prefer `const`
feat(npm): add `test-cov` script showing more coverag info than just summary

Author: brettz9

package.json

@@ -64,6 +64,7 @@
     "build": "rm -fr ./dist && NODE_ENV=production babel ./src --out-dir ./dist --copy-files --source-maps",
     "create-readme": "gitdown ./.README/README.md --output-file ./README.md && npm run add-assertions",
     "lint": "eslint ./src ./test",
+    "test-cov": "BABEL_ENV=test nyc mocha --recursive --require @babel/register --reporter progress",
     "test": "BABEL_ENV=test nyc --reporter text-summary mocha --recursive --require @babel/register --reporter progress"
   },
   "nyc": {

src/iterateJsdoc.js

@@ -47,10 +47,6 @@ const curryUtils = (
     return jsdocUtils.getFunctionParameterNames(node);
   };
 
-  utils.getFunctionSourceCode = () => {
-    return sourceCode.getText(node);
-  };
-
   utils.isConstructor = () => {
     return node.parent && node.parent.kind === 'constructor';
   };

src/rules/requireReturns.js

@@ -58,7 +58,7 @@ export default iterateJsdoc(({
   const tags = utils.getTags(tagName);
 
   if (tags.length > 1) {
-    report('Found more than one  @' + tagName + ' declaration.');
+    report('Found more than one @' + tagName + ' declaration.');
   }
 
   // In case the code returns something, we expect a return value in JSDoc.

src/rules/validTypes.js

@@ -18,15 +18,14 @@ export default iterateJsdoc(({
       } catch (err) {
         let error = err;
 
-        let endChar;
         if (tagName && ['memberof', 'memberof!'].includes(tagName)) {
-          endChar = type.slice(-1);
+          const endChar = type.slice(-1);
           if (['#', '.', '~'].includes(endChar)) {
             try {
               parse(type.slice(0, -1));
               error = {};
             } catch (memberofError) {
-              error = memberofError;
+              // Use the original error for including the whole type
             }
           }
         }

test/rules/assertions/checkTagNames.js

@@ -236,6 +236,16 @@ export default {
     },
     {
       code: ALL_JSDOC_TAGS_COMMENT + '\nfunction quux (foo) {}'
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function quux (foo) {
+
+          }
+      `
     }
   ]
 };

test/rules/assertions/checkTypes.js

@@ -2042,6 +2042,16 @@ export default {
           }
         }
       }
+    },
+    {
+      code: `
+          /**
+           * @param {Number<} Ignore the error as not a validating rule
+           */
+          function quux (foo) {
+
+          }
+      `
     }
   ]
 };

test/rules/assertions/implementsOnClasses.js

@@ -54,6 +54,21 @@ export default {
       }
       `
     },
+    {
+      code: `
+      /**
+       *
+       */
+      const quux = class {
+        /**
+         * @implements {SomeClass}
+         */
+        constructor () {
+
+        }
+      }
+      `
+    },
     {
       code: `
       /**

test/rules/assertions/newlineAfterDescription.js

@@ -33,6 +33,36 @@ export default {
           }
       `
     },
+    {
+      code: `
+          /**
+           * Foo.
+           *
+           * Foo.
+           * @foo
+           */
+          function quux () {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'There must be a newline after the description of the JSDoc block.'
+        }
+      ],
+      output: `
+          /**
+           * Foo.
+           *
+           * Foo.
+           *
+           * @foo
+           */
+          function quux () {
+
+          }
+      `
+    },
     {
       code: `
           /**

test/rules/assertions/requireExample.js

@@ -130,6 +130,23 @@ export default {
         }
       }
     },
+    {
+      code: `
+      class Foo {
+        /**
+         *
+         */
+        constructor () {
+
+        }
+      }
+      `,
+      settings: {
+        jsdoc: {
+          avoidExampleOnConstructors: true
+        }
+      }
+    },
     {
       code: `
       /**

test/rules/assertions/requireHyphenBeforeParamDescription.js

@@ -27,6 +27,30 @@ export default {
           }
       `
     },
+    {
+      code: `
+          /**
+           * @param foo Foo.
+           */
+          function quux () {
+
+          }
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'There must be a hyphen before @param description.'
+        }
+      ],
+      output: `
+          /**
+           * @param foo - Foo.
+           */
+          function quux () {
+
+          }
+      `
+    },
     {
       code: `
           /**
@@ -141,6 +165,16 @@ export default {
       options: [
         'never'
       ]
+    },
+    {
+      code: `
+          /**
+           * @param foo
+           */
+          function quux () {
+
+          }
+      `
     }
   ]
 };