fix(check-param-names, check-property-names, require-file-overview): avoid direct use of uncertain license of object.entries-ponyfill; closes #487

BREAKING CHANGE:

Now requires Node >= 8

Author: brettz9

.travis.yml

@@ -3,7 +3,6 @@ node_js:
   - 12
   - 10
   - 8
-  - 6
 before_install:
   - npm config set depth 0
 before_script: >
@@ -12,13 +11,8 @@ before_script: >
     echo "Node 10+"
     npm install --no-save "eslint@${ESLINT}"
     else
-      if [ ${node_version:1:1} -ge 8 ]; then
-        echo "Node 8+"
-        npm install --no-save "eslint@${ESLINT}" [email protected] [email protected]
-      else
-        echo "Node <= 6"
-        npm install --no-save "eslint@${ESLINT}" [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] @typescript-eslint/[email protected]
-      fi
+      echo "Node 8+"
+      npm install --no-save "eslint@${ESLINT}" [email protected] [email protected]
   fi
 notifications:
   email: false

package.json

@@ -9,7 +9,6 @@
     "debug": "^4.1.1",
     "jsdoctypeparser": "^6.1.0",
     "lodash": "^4.17.15",
-    "object.entries-ponyfill": "^1.0.1",
     "regextras": "^0.7.0",
     "semver": "^6.3.0",
     "spdx-expression-parse": "^3.0.0"
@@ -38,7 +37,7 @@
     "typescript": "^3.7.5"
   },
   "engines": {
-    "node": ">=6"
+    "node": ">=8"
   },
   "husky": {
     "hooks": {

src/rules/checkParamNames.js

@@ -1,12 +1,10 @@
-// Todo[engine:node@>=7.0.0]: Replace with `Object.entries`
-import entries from 'object.entries-ponyfill';
 import iterateJsdoc from '../iterateJsdoc';
 
 const validateParameterNames = (
   targetTagName : string, allowExtraTrailingParamDocs: boolean,
   functionParameterNames : Array<string>, jsdoc, jsdocNode, utils, report,
 ) => {
-  const paramTags = entries(jsdoc.tags).filter(([, tag]) => {
+  const paramTags = Object.entries(jsdoc.tags).filter(([, tag]) => {
     return tag.tag === targetTagName;
   });
   const paramTagsNonNested = paramTags.filter(([, tag]) => {

src/rules/checkPropertyNames.js

@@ -1,11 +1,10 @@
-import entries from 'object.entries-ponyfill';
 import iterateJsdoc from '../iterateJsdoc';
 
 const validatePropertyNames = (
   targetTagName : string,
   jsdoc, jsdocNode, utils,
 ) => {
-  const propertyTags = entries(jsdoc.tags).filter(([, tag]) => {
+  const propertyTags = Object.entries(jsdoc.tags).filter(([, tag]) => {
     return tag.tag === targetTagName;
   });
 

src/rules/requireFileOverview.js

@@ -1,5 +1,3 @@
-// Todo[engine:node@>=7.0.0]: Replace with `Object.entries`
-import entries from 'object.entries-ponyfill';
 import iterateJsdoc from '../iterateJsdoc';
 
 const defaultTags = {
@@ -63,7 +61,7 @@ export default iterateJsdoc(({
       mustExist = false,
       preventDuplicates = false,
       initialCommentsOnly = false,
-    }] of entries(tags)) {
+    }] of Object.entries(tags)) {
       const obj = utils.getPreferredTagNameObject({tagName});
       if (obj && obj.blocked) {
         utils.reportSettings(