Merge pull request #307 from interfaced/master

feat(no-undefined-types): Handle GCC generic functions

Author: brettz9

README.md

@@ -3048,6 +3048,14 @@ function quux(foo, bar, baz) {
 // Options: [{"definedTypes":["MyType"],"preferredTypesDefined":true}]
 // Message: The type 'HerType' is undefined.
 
+/**
+ * @template TEMPLATE_TYPE
+ * @param {WRONG_TEMPLATE_TYPE} bar
+ */
+function foo (bar) {
+};
+// Message: The type 'WRONG_TEMPLATE_TYPE' is undefined.
+
 class Foo {
   /**
    * @return {TEMPLATE_TYPE}
@@ -3227,6 +3235,14 @@ function quux(foo, bar, baz) {
 // Settings: {"jsdoc":{"preferredTypes":{"hertype":{"replacement":"HerType<>"},"histype":"HisType.<>"}}}
 // Options: [{"definedTypes":["MyType"],"preferredTypesDefined":true}]
 
+/**
+ * @template TEMPLATE_TYPE
+ * @param {TEMPLATE_TYPE} bar
+ * @return {TEMPLATE_TYPE}
+ */
+function foo (bar) {
+};
+
 /**
  * @template TEMPLATE_TYPE
  */

src/rules/noUndefinedTypes.js

@@ -68,18 +68,21 @@ export default iterateJsdoc(({
     })
     .value();
 
-  let closureGenericTypes = [];
+  let templateTags = utils.getPresentTags('template');
   const classJsdoc = utils.getClassJsdoc();
   if (classJsdoc && classJsdoc.tags) {
-    closureGenericTypes = classJsdoc.tags
-      .filter((tag) => {
-        return tag.tag === 'template';
-      })
-      .flatMap((tag) => {
-        return jsdocUtils.parseClosureTemplateTag(tag);
-      });
+    templateTags = templateTags.concat(
+      classJsdoc.tags
+        .filter((tag) => {
+          return tag.tag === 'template';
+        })
+    );
   }
 
+  const closureGenericTypes = templateTags.flatMap((tag) => {
+    return jsdocUtils.parseClosureTemplateTag(tag);
+  });
+
   const allDefinedTypes = globalScope.variables.map((variable) => {
     return variable.name;
   })

test/rules/assertions/noUndefinedTypes.js

@@ -155,6 +155,22 @@ export default {
         }
       }
     },
+    {
+      code: `
+      /**
+       * @template TEMPLATE_TYPE
+       * @param {WRONG_TEMPLATE_TYPE} bar
+       */
+      function foo (bar) {
+      };
+      `,
+      errors: [
+        {
+          line: 4,
+          message: 'The type \'WRONG_TEMPLATE_TYPE\' is undefined.'
+        }
+      ]
+    },
     {
       code: `
       class Foo {
@@ -439,6 +455,17 @@ export default {
         }
       }
     },
+    {
+      code: `
+      /**
+       * @template TEMPLATE_TYPE
+       * @param {TEMPLATE_TYPE} bar
+       * @return {TEMPLATE_TYPE}
+       */
+      function foo (bar) {
+      };
+      `
+    },
     {
       code: `
       /**