Call namepaths namepath instead of types in error messages

Author: l1bbcsg

README.md

@@ -7345,39 +7345,39 @@ function quux() {
 function quux() {
 
 }
-// Message: Syntax error in type: module:namespace.SomeClass<~
+// Message: Syntax error in namepath: module:namespace.SomeClass<~
 
 /**
  * @memberof module:namespace.SomeClass~<
  */
 function quux() {
 
 }
-// Message: Syntax error in type: module:namespace.SomeClass~<
+// Message: Syntax error in namepath: module:namespace.SomeClass~<
 
 /**
  * @borrows foo% as bar
  */
 function quux() {
 
 }
-// Message: Syntax error in type: foo%
+// Message: Syntax error in namepath: foo%
 
 /**
  * @borrows #foo as bar
  */
 function quux() {
 
 }
-// Message: Syntax error in type: #foo
+// Message: Syntax error in namepath: #foo
 
 /**
  * @borrows foo as bar%
  */
 function quux() {
 
 }
-// Message: Syntax error in type: bar%
+// Message: Syntax error in namepath: bar%
 
 /**
  * @borrows foo
@@ -7394,7 +7394,7 @@ function quux() {
 
 }
 // Options: [{"checkSeesForNamepaths":true}]
-// Message: Syntax error in type: foo%
+// Message: Syntax error in namepath: foo%
 
 /** */
 function foo() {}
@@ -7407,15 +7407,15 @@ function foo() {}
 function quux() {
 
 }
-// Message: Syntax error in type: module:abc#event:foo-bar
+// Message: Syntax error in namepath: module:abc#event:foo-bar
 
 /**
  * @mixes module:namespace.SomeClass~
  */
 function quux() {
 
 }
-// Message: Syntax error in type: module:namespace.SomeClass~
+// Message: Syntax error in namepath: module:namespace.SomeClass~
 
 /**
  * @callback
@@ -7440,7 +7440,7 @@ function quux() {
 /**
  * @typedef {string} UserStr%ng
  */
-// Message: Syntax error in type: UserStr%ng
+// Message: Syntax error in namepath: UserStr%ng
 
 /**
  * @extends

src/rules/validTypes.js

@@ -21,38 +21,38 @@ export default iterateJsdoc(({
     return;
   }
   jsdoc.tags.forEach((tag) => {
-    const validTypeParsing = function (type, tagName) {
+    const validNamepathParsing = function (namepath, tagName) {
       try {
-        parse(type);
-      } catch (err) {
-        let error = err;
+        parse(namepath);
+      } catch (error) {
+        let handled = false;
 
         if (tagName) {
           if (['memberof', 'memberof!'].includes(tagName)) {
-            const endChar = type.slice(-1);
+            const endChar = namepath.slice(-1);
             if (['#', '.', '~'].includes(endChar)) {
               try {
-                parse(type.slice(0, -1));
-                error = {};
+                parse(namepath.slice(0, -1));
+                handled = true;
               } catch (memberofError) {
                 // Use the original error for including the whole type
               }
             }
           } else if (tagName === 'borrows') {
-            const startChar = type.charAt();
+            const startChar = namepath.charAt();
             if (['#', '.', '~'].includes(startChar)) {
               try {
-                parse(type.slice(1));
-                error = {};
+                parse(namepath.slice(1));
+                handled = true;
               } catch (memberofError) {
                 // Use the original error for including the whole type
               }
             }
           }
         }
 
-        if (error.name === 'SyntaxError') {
-          report(`Syntax error in type: ${type}`, null, tag);
+        if (!handled) {
+          report(`Syntax error in namepath: ${namepath}`, null, tag);
 
           return false;
         }
@@ -61,6 +61,18 @@ export default iterateJsdoc(({
       return true;
     };
 
+    const validTypeParsing = function (type) {
+      try {
+        parse(type);
+      } catch (error) {
+        report(`Syntax error in type: ${type}`, null, tag);
+
+        return false;
+      }
+
+      return true;
+    };
+
     const hasType = utils.tagMightHaveType(tag.tag) && Boolean(tag.type);
     const mustHaveType = utils.tagMustHaveType(tag.tag);
 
@@ -79,10 +91,10 @@ export default iterateJsdoc(({
         return;
       }
 
-      if (validTypeParsing(thisNamepath, 'borrows')) {
+      if (validNamepathParsing(thisNamepath, 'borrows')) {
         const thatNamepath = tag.name;
 
-        validTypeParsing(thatNamepath);
+        validNamepathParsing(thatNamepath);
       }
     } else {
       if (mustHaveEither && !hasEither) {
@@ -98,7 +110,7 @@ export default iterateJsdoc(({
       }
 
       if (hasNamePath) {
-        validTypeParsing(tag.name, tag.tag);
+        validNamepathParsing(tag.name, tag.tag);
       } else if (mustHaveNamepath) {
         report(`Tag @${tag.tag} must have a namepath`, null, tag);
       }

test/rules/assertions/validTypes.js

@@ -28,7 +28,7 @@ export default {
       errors: [
         {
           line: 3,
-          message: 'Syntax error in type: module:namespace.SomeClass<~',
+          message: 'Syntax error in namepath: module:namespace.SomeClass<~',
         },
       ],
     },
@@ -44,7 +44,7 @@ export default {
       errors: [
         {
           line: 3,
-          message: 'Syntax error in type: module:namespace.SomeClass~<',
+          message: 'Syntax error in namepath: module:namespace.SomeClass~<',
         },
       ],
     },
@@ -59,7 +59,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: foo%',
+        message: 'Syntax error in namepath: foo%',
       }],
     },
     {
@@ -73,7 +73,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: #foo',
+        message: 'Syntax error in namepath: #foo',
       }],
     },
     {
@@ -87,7 +87,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: bar%',
+        message: 'Syntax error in namepath: bar%',
       }],
     },
     {
@@ -115,7 +115,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: foo%',
+        message: 'Syntax error in namepath: foo%',
       }],
       options: [{
         checkSeesForNamepaths: true,
@@ -152,7 +152,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: module:abc#event:foo-bar',
+        message: 'Syntax error in namepath: module:abc#event:foo-bar',
       }],
     },
     {
@@ -166,7 +166,7 @@ export default {
       `,
       errors: [{
         line: 3,
-        message: 'Syntax error in type: module:namespace.SomeClass~',
+        message: 'Syntax error in namepath: module:namespace.SomeClass~',
       }],
     },
     {
@@ -222,7 +222,7 @@ export default {
       errors: [
         {
           line: 3,
-          message: 'Syntax error in type: UserStr%ng',
+          message: 'Syntax error in namepath: UserStr%ng',
         },
       ],
     },