fix(no-undefined-types): add line info to inline tags; fixes #1079

Author: brettz9

docs/rules/no-undefined-types.md

@@ -283,6 +283,24 @@ function foo () {
 const a = new Todo();
 // Settings: {"jsdoc":{"mode":"jsdoc"}}
 // Message: The type 'Omit' is undefined.
+
+/**
+ * Message with {@link NotKnown}
+ */
+// Message: The type 'NotKnown' is undefined.
+
+/**
+ * Message with
+ * a link that is {@link NotKnown}
+ */
+// Message: The type 'NotKnown' is undefined.
+
+/**
+ * @abc
+ * @someTag Message with
+ *   a link that is {@link NotKnown}
+ */
+// Message: The type 'NotKnown' is undefined.
 ````
 
 

src/jsdocUtils.js

@@ -533,8 +533,54 @@ const hasTag = (jsdoc, targetTagName) => {
 const getAllTags = (jsdoc, includeInlineTags) => {
   return includeInlineTags ? [
     ...jsdoc.tags,
-    ...jsdoc.inlineTags,
+    ...jsdoc.inlineTags.map((inlineTag) => {
+      // Tags don't have source or line numbers, so add before returning
+      let line = -1;
+      for (const {
+        tokens: {
+          description,
+        },
+      } of jsdoc.source) {
+        line++;
+        if (description && description.includes(`{@${inlineTag.tag}`)) {
+          break;
+        }
+      }
+
+      inlineTag.line = line;
+
+      return inlineTag;
+    }),
     ...jsdoc.tags.flatMap((tag) => {
+      let tagBegins = -1;
+      for (const {
+        tokens: {
+          tag: tg,
+        },
+      } of jsdoc.source) {
+        tagBegins++;
+        if (tg) {
+          break;
+        }
+      }
+
+      for (const inlineTag of tag.inlineTags) {
+        let line;
+        for (const {
+          number,
+          tokens: {
+            description,
+          },
+        } of tag.source) {
+          if (description && description.includes(`{@${inlineTag.tag}`)) {
+            line = number;
+            break;
+          }
+        }
+
+        inlineTag.line = tagBegins + line - 1;
+      }
+
       return (
         /**
          * @type {import('comment-parser').Spec & {

test/rules/assertions/noUndefinedTypes.js

@@ -490,6 +490,48 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * Message with {@link NotKnown}
+       */
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'The type \'NotKnown\' is undefined.',
+        },
+      ],
+    },
+    {
+      code: `
+      /**
+       * Message with
+       * a link that is {@link NotKnown}
+       */
+      `,
+      errors: [
+        {
+          line: 4,
+          message: 'The type \'NotKnown\' is undefined.',
+        },
+      ],
+    },
+    {
+      code: `
+      /**
+       * @abc
+       * @someTag Message with
+       *   a link that is {@link NotKnown}
+       */
+      `,
+      errors: [
+        {
+          line: 5,
+          message: 'The type \'NotKnown\' is undefined.',
+        },
+      ],
+    },
   ],
   valid: [
     {