Merge pull request #231 from brettz9/duplicate-params

Duplicate params

Author: brettz9

README.md

@@ -689,6 +689,33 @@ function quux (foo) {
 
 }
 // Message: @param "bar" does not match an existing function parameter.
+
+/**
+ * @param foo
+ * @param foo
+ */
+function quux (foo) {
+
+}
+// Message: Duplicate @param "foo"
+
+/**
+ * @param foo
+ * @param foo
+ */
+function quux (foo, bar) {
+
+}
+// Message: Duplicate @param "foo"
+
+/**
+ * @param foo
+ * @param foo
+ */
+function quux (foo, foo) {
+
+}
+// Message: Duplicate @param "foo"
 ````
 
 The following patterns are not considered problems:

src/rules/checkParamNames.js

@@ -10,6 +10,13 @@ const validateParameterNames = (targetTagName : string, functionParameterNames :
   });
 
   return paramTags.some((tag, index) => {
+    if (paramTags.some((tg, idx) => {
+      return tg.name === tag.name && idx !== index;
+    })) {
+      report('Duplicate @' + targetTagName + ' "' + tag.name + '"');
+
+      return true;
+    }
     const functionParameterName = functionParameterNames[index];
 
     if (!functionParameterName) {

test/rules/assertions/checkParamNames.js

@@ -117,6 +117,54 @@ export default {
           message: '@param "bar" does not match an existing function parameter.'
         }
       ]
+    },
+    {
+      code: `
+          /**
+           * @param foo
+           * @param foo
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'Duplicate @param "foo"'
+        }
+      ]
+    },
+    {
+      code: `
+          /**
+           * @param foo
+           * @param foo
+           */
+          function quux (foo, bar) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'Duplicate @param "foo"'
+        }
+      ]
+    },
+    {
+      code: `
+          /**
+           * @param foo
+           * @param foo
+           */
+          function quux (foo, foo) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'Duplicate @param "foo"'
+        }
+      ]
     }
   ],
   valid: [