Removed important flag and some build warnings

Signed-off-by: James Cocker <james.s.earth@gmail.com>

Author: James-Cocker

galasa-ui/src/components/test-runs/test-run-details/LogTab.tsx

@@ -536,7 +536,7 @@ export default function LogTab({ logs, initialLine, runId }: LogTabProps) {
         lineElement.scrollIntoView({ behavior: ANIMATION_BEHAVIOUR, block: 'start' });
       }
     }
-  }, [initialLine, processedLines]);
+  }, [ANIMATION_BEHAVIOUR, initialLine, processedLines]);
 
   // Scroll to current match
   useEffect(() => {
@@ -549,7 +549,7 @@ export default function LogTab({ logs, initialLine, runId }: LogTabProps) {
         });
       }
     }
-  }, [currentMatchIndex]);
+  }, [ANIMATION_BEHAVIOUR, currentMatchIndex]);
 
   useEffect(() => {
     const matchCount = searchMatches.length;

galasa-ui/src/components/test-runs/test-run-details/TestRunDetails.tsx

@@ -110,6 +110,8 @@ const TestRunDetails = ({
     if (is3270TabSelectedInURL && zos3270TerminalFolderExists && !is3270TabLoading) {
       setSelectedTabIndex(indexOf3270Tab);
     }
+    // Ignore missing dependecies as they will be finalised by the time is3270TabLoading switches to false
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [is3270TabLoading]);
 
   const handleSetZos3270TerminalData = (newZos3270TerminalData: TreeNodeData[]) => {

galasa-ui/src/styles/test-runs/test-run-details/Tab3270.module.css

@@ -13,8 +13,7 @@
 }
 
 #innerScreenshotTable {
-  /* Override Carbon's max-height for the Table component */
-  max-height: min(calc(100vh - 450px), 550px) !important;
+  max-height: min(calc(100vh - 450px), 550px);
   overflow-y: auto;
   /* Stops sticky header overlapping table elements when scrollToTop() is called. */
   scroll-padding-top: 48px;