Merge pull request #236 from mvdbeek/boolean_when

Don't rely on boolean coercion

Author: mvdbeek

tasks/dependencies.yml

@@ -44,7 +44,7 @@
       environment:
         PYTHONPATH: null
         VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
-      when: galaxy_additional_venv_packages
+      when: galaxy_additional_venv_packages | length > 0
 
   remote_user: "{{ galaxy_remote_users.privsep | default(__galaxy_remote_user) }}"
   become: "{{ true if galaxy_become_users.privsep is defined else __galaxy_become }}"

tasks/paths.yml

@@ -20,8 +20,8 @@
         owner: "{{ __galaxy_privsep_user_name }}"
         group: "{{ __galaxy_user_group }}" #This is set so that the galaxy_user can read the files in the priv_sep dirs. (As priv_sep dirs have defauly perms of 0640.)
         mode: "{{ __galaxy_dir_perms }}"
-      loop: "{{ galaxy_privsep_dirs + galaxy_extra_privsep_dirs }}"
-      when: item | default(False)
+      # Skip null, xref https://github.com/galaxyproject/ansible-galaxy/pull/126
+      loop: "{{ (galaxy_privsep_dirs + galaxy_extra_privsep_dirs) | select | list }}"
 
     - name: Create additional directories
       file: