Skip to content

Commit ea4135d

Browse files
authored
Merge pull request #20 from yaroslav-shabalin/wal_dir_rename
Properly handle WAL directory in backup scripts for version >=10
2 parents c20db04 + 9da5ccc commit ea4135d

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

templates/backup_working_wal.sh.j2

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
## This file is maintained by Ansible - CHANGES WILL BE OVERWRITTEN
44
##
55

6-
xlog_dir='{{ postgresql_pgdata }}/pg_xlog'
6+
wal_dir='{{ postgresql_pgdata }}/{{ postgresql_version is version("10", ">=") | ternary("pg_wal", "pg_xlog") }}'
77
backup_dir={{ postgresql_backup_active_dir }}
88
mailto='{{ postgresql_backup_mail_recipient }}'
99

10-
active=`ls -1rtF $xlog_dir | grep -v '/$' | tail -1`
10+
active=`ls -1rtF $wal_dir | grep -v '/$' | tail -1`
1111

12-
out=`scp -p $xlog_dir/$active $backup_dir/$active 2>&1`
12+
out=`scp -p $wal_dir/$active $backup_dir/$active 2>&1`
1313
ret=$?
1414

1515
if [ $ret -ne 0 ]; then

templates/scheduled_backup.sh.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ dir='{{ postgresql_backup_dir }}/current'
99
mailto='{{ postgresql_backup_mail_recipient }}'
1010
mutex={{ postgresql_backup_local_dir }}/scheduledmutex
1111
rotate='{{ postgresql_backup_rotate | default("True") }}'
12+
wal_dir='{{ postgresql_version is version("10", ">=") | ternary("pg_wal", "pg_xlog") }}'
1213

1314
[ '{{ postgresql_backup_remote_rsync_path | default("None") }}' != 'None' ] && remote_rsync='--rsync-path={{ postgresql_backup_remote_rsync_path | default("None") }}' || remote_rsync=''
1415

@@ -83,7 +84,7 @@ backup_started=1
8384
handler mkdir -p $data/wal
8485

8586
# begin the backup
86-
handler rsync $remote_rsync -rptg --delete --delete-delay --exclude pg_xlog $data/ $dir
87+
handler rsync $remote_rsync -rptg --delete --delete-delay --exclude $wal_dir $data/ $dir
8788

8889
# tell postgres we're done
8990
psql_handler "SELECT pg_stop_backup();"

0 commit comments

Comments
 (0)