Skip to content

Commit 0648cbe

Browse files
committed
Wait for datatype response before setting up tabs -- we need this to know if we are preview/viz/raw/etc.
1 parent 75212d0 commit 0648cbe

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

client/src/components/Dataset/DatasetView.vue

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,28 @@ const preferredVisualization = computed(
4747
() => dataset.value && datatypeStore.getPreferredVisualization(dataset.value.file_ext)
4848
);
4949
50+
// Track datatype loading state
51+
const isDatatypeLoading = ref(false);
52+
const datatypeDetailsLoaded = ref(false);
53+
5054
// Watch for changes to the dataset to fetch datatype info
5155
watch(
5256
() => dataset.value?.file_ext,
5357
async () => {
5458
if (dataset.value && dataset.value.file_ext) {
59+
isDatatypeLoading.value = true;
60+
datatypeDetailsLoaded.value = false;
5561
await datatypeStore.fetchDatatypeDetails(dataset.value.file_ext);
62+
isDatatypeLoading.value = false;
63+
datatypeDetailsLoaded.value = true;
5664
}
5765
},
5866
{ immediate: true }
5967
);
6068
</script>
6169

6270
<template>
63-
<LoadingSpan v-if="isLoading || !dataset" message="Loading dataset details" />
71+
<LoadingSpan v-if="isLoading || !dataset || isDatatypeLoading" message="Loading dataset details" />
6472
<div v-else class="dataset-view d-flex flex-column h-100">
6573
<header :key="`dataset-header-${dataset.id}`" class="dataset-header flex-shrink-0">
6674
<div class="d-flex">

0 commit comments

Comments
 (0)