Merge remote-tracking branch 'upstream/release_25.0' into dev

Author: dannon

client/.eslintrc.js

@@ -87,6 +87,8 @@ const baseRules = {
         "error",
         { prefer: "type-imports", fixStyle: "inline-type-imports" },
     ],
+
+    "@typescript-eslint/no-import-type-side-effects": "error",
 };
 
 const baseExtends = [

client/src/api/client/__mocks__/index.ts

@@ -2,7 +2,7 @@ import { HttpResponse } from "msw";
 import { setupServer } from "msw/node";
 import { createOpenApiHttp } from "openapi-msw";
 
-import { type GalaxyApiPaths } from "@/api/schema";
+import type { GalaxyApiPaths } from "@/api/schema";
 
 export { HttpResponse };
 

client/src/api/client/index.ts

@@ -1,6 +1,6 @@
 import createClient from "openapi-fetch";
 
-import { type GalaxyApiPaths } from "@/api/schema";
+import type { GalaxyApiPaths } from "@/api/schema";
 import { getAppRoot } from "@/onload/loadConfig";
 
 function getBaseUrl() {

client/src/api/client/serverMock.test.ts

@@ -1,4 +1,4 @@
-import { type HistoryDetailed, type HistorySummary, type MessageException } from "@/api";
+import type { HistoryDetailed, HistorySummary, MessageException } from "@/api";
 import { GalaxyApi } from "@/api";
 import { useServerMock } from "@/api/client/__mocks__";
 

client/src/api/configTemplates.ts

@@ -1,4 +1,4 @@
-import { type components } from "@/api/schema";
+import type { components } from "@/api/schema";
 
 export type CreateInstancePayload = components["schemas"]["CreateInstancePayload"];
 

client/src/api/datatypes.ts

@@ -1,3 +1,3 @@
-import { type components } from "@/api";
+import type { components } from "@/api";
 
 export type CompositeFileInfo = components["schemas"]["CompositeFileInfo"];

client/src/api/fileSources.ts

@@ -1,7 +1,7 @@
 import { faAws, faDropbox, faGoogleDrive } from "@fortawesome/free-brands-svg-icons";
 import { faCloud, faFolderTree, faNetworkWired, type IconDefinition } from "font-awesome-6";
 
-import { type components } from "@/api/schema";
+import type { components } from "@/api/schema";
 import { contains } from "@/utils/filtering";
 
 export type FileSourceTemplateSummary = components["schemas"]["FileSourceTemplateSummary"];

client/src/api/histories.ts

@@ -1,4 +1,4 @@
-import { type AnyHistory, type components } from "@/api";
+import type { AnyHistory, components } from "@/api";
 
 type HistoryDetailed = components["schemas"]["HistoryDetailed"];
 

client/src/api/index.ts

@@ -1,7 +1,7 @@
 /** Contains type alias and definitions related to Galaxy API models. */
 
 import { GalaxyApi } from "@/api/client";
-import { type components, type GalaxyApiPaths } from "@/api/schema";
+import type { components, GalaxyApiPaths } from "@/api/schema";
 
 export { type components, GalaxyApi, type GalaxyApiPaths };
 

client/src/api/invocations.ts

@@ -1,4 +1,4 @@
-import { type components } from "./schema";
+import type { components } from "./schema";
 
 export type WorkflowInvocationElementView = components["schemas"]["WorkflowInvocationElementView"];
 export type WorkflowInvocationCollectionView = components["schemas"]["WorkflowInvocationCollectionView"];