Remove more references to Job.params

Author: jdavcs

lib/galaxy/jobs/__init__.py

@@ -1048,8 +1048,6 @@ def __init__(
         self._job_io = None
         self.tool_provided_job_metadata = None
         self.params = None
-        if job.params:
-            self.params = loads(job.params)
         self.runner_command_line = None
 
         # Wrapper holding the info required to restore and clean up from files used for setting metadata externally

lib/galaxy/tools/actions/__init__.py

@@ -7,7 +7,6 @@
     Mapping,
     MutableMapping,
 )
-from json import dumps
 from typing import (
     Any,
     cast,
@@ -738,8 +737,6 @@ def handle_output(name, output, hidden=None):
         # execute immediate post job actions and associate post job actions that are to be executed after the job is complete
         if job_callback:
             job_callback(job)
-        if job_params:
-            job.params = dumps(job_params)
         if completed_job:
             job.set_copied_from_job_id(completed_job.id)
         trans.sa_session.add(job)

lib/galaxy/tools/actions/metadata.py

@@ -1,6 +1,5 @@
 import logging
 import os
-from json import dumps
 from typing import (
     Any,
     Optional,
@@ -144,8 +143,6 @@ def execute_via_app(
         job.tool_id = tool.id
         if user:
             job.user_id = user.id
-        if job_params:
-            job.params = dumps(job_params)
         start_job_state = job.state  # should be job.states.NEW
         try:
             # For backward compatibility, some tools may not have versions yet.