Merge pull request #21056 from mvdbeek/fix_dynamic_tool_session_issue

[25.0] Fix `InvalidRequestError` when saving workflow step with dynamic tool

Author: mvdbeek

lib/galaxy/workflow/modules.py

@@ -2007,7 +2007,7 @@ def from_workflow_step(Class, trans, step, **kwds):
 
     # ---- Saving in various forms ------------------------------------------
 
-    def save_to_step(self, step, detached=False):
+    def save_to_step(self, step: WorkflowStep, detached=False):
         super().save_to_step(step, detached=detached)
         step.tool_id = self.tool_id
         if self.tool:
@@ -2017,7 +2017,7 @@ def save_to_step(self, step, detached=False):
         if tool_uuid := getattr(self, "tool_uuid", None):
             tool = self.trans.app.toolbox.get_tool(tool_uuid=tool_uuid, user=self.trans.user)
             if tool:
-                step.dynamic_tool = tool.dynamic_tool
+                step.dynamic_tool_id = tool.dynamic_tool.id
         if not detached:
             for k, v in self.post_job_actions.items():
                 pja = self.__to_pja(k, v, step)