Merge pull request #20974 from guerler/remove_trackster

Remove Trackster

Author: guerler

client/src/bundleEntries.js

@@ -1,32 +1,31 @@
 /**
- * The big list of horrible globals we expose on window.bundleEntries.
+ * The list of horrible globals we expose on window.bundleEntries.
  *
  * Everything that is exposed on this global variable is something that the python templates
  * require for their hardcoded initializations. These objects are going to have to continue
  * to exist until such time as we replace the overall application with a Vue component which
  * will handle initializations for components individually.
+ *
+ * legacy/grid_base.mako: window.bundleEntries.LegacyGridView
+ * webapps/galaxy/dataset/tabular_chunked.mako: window.bundleEntries.createTabularDatasetChunkedView
+ * webapps/galaxy/dataset/display.mako: window.bundleEntries.createTabularDatasetChunkedView
+ * webapps/reports/run_stats.mako: window.bundleEntries.create_chart
+ * webapps/reports/run_stats.mako: window.bundleEntries.create_histogram
+ * tagging_common.mako: show_in_overlay
  */
 
 /* jquery and _ are exposed via expose-loader while several external plugins rely on these */
 import $ from "jquery"; // eslint-disable-line no-unused-vars
 import _ from "underscore"; // eslint-disable-line no-unused-vars
-import { TracksterUIView } from "viz/trackster";
 
 export { getGalaxyInstance, setGalaxyInstance } from "app";
 export { default as LegacyGridView } from "legacy/grid/grid-view";
 export { createTabularDatasetChunkedView } from "mvc/dataset/data";
 export { create_chart, create_histogram } from "reports/run_stats";
 export { Toast } from "ui/toast"; // TODO: remove when external consumers are updated/gone (IES right now)
-export { TracksterUI } from "viz/trackster";
-
-export function trackster(options) {
-    new TracksterUIView(options);
-}
 
 // Previously wandering around as window.thing = thing in the onload script
-export { hide_modal, Modal, show_in_overlay, show_message, show_modal } from "layout/modal";
-export { make_popup_menus, make_popupmenu } from "ui/popupmenu";
-export { default as async_save_text } from "utils/async-save-text";
+export { show_in_overlay } from "layout/modal";
 
 // Used in common.mako
 export { default as store } from "storemodern";

client/src/components/Grid/configs/visualizationsPublished.ts

@@ -3,7 +3,6 @@ import { useEventBus } from "@vueuse/core";
 
 import { GalaxyApi } from "@/api";
 import Filtering, { contains, expandNameTag, type ValidFilter } from "@/utils/filtering";
-import { withPrefix } from "@/utils/redirect";
 import { rethrowSimple } from "@/utils/simple-error";
 
 import type { FieldArray, GridConfig } from "./types";
@@ -57,13 +56,9 @@ const fields: FieldArray = [
                 title: "View",
                 icon: faEye,
                 handler: (data: VisualizationEntry) => {
-                    if (data.type === "trackster") {
-                        window.location.href = withPrefix(`/visualization/${data.type}?id=${data.id}`);
-                    } else {
-                        emit(`/visualizations/display?visualization=${data.type}&visualization_id=${data.id}`, {
-                            title: data.title,
-                        });
-                    }
+                    emit(`/visualizations/display?visualization=${data.type}&visualization_id=${data.id}`, {
+                        title: data.title,
+                    });
                 },
             },
         ],

client/src/components/Grid/configs/visualizationsShared.ts

@@ -3,7 +3,6 @@ import { useEventBus } from "@vueuse/core";
 
 import { GalaxyApi } from "@/api";
 import Filtering, { contains, expandNameTag, type ValidFilter } from "@/utils/filtering";
-import { withPrefix } from "@/utils/redirect";
 import { rethrowSimple } from "@/utils/simple-error";
 
 import type { FieldArray, GridConfig } from "./types";
@@ -57,13 +56,9 @@ const fields: FieldArray = [
                 title: "View",
                 icon: faEye,
                 handler: (data: VisualizationEntry) => {
-                    if (data.type === "trackster") {
-                        window.location.href = withPrefix(`/visualization/${data.type}?id=${data.id}`);
-                    } else {
-                        emit(`/visualizations/display?visualization=${data.type}&visualization_id=${data.id}`, {
-                            title: data.title,
-                        });
-                    }
+                    emit(`/visualizations/display?visualization=${data.type}&visualization_id=${data.id}`, {
+                        title: data.title,
+                    });
                 },
             },
         ],

client/src/components/User/CustomBuilds.vue

@@ -134,11 +134,6 @@ chr3    159599783
 chr4    155630120
 chr5    152537259</pre
                     >
-                    <p class="card-text">
-                        Trackster uses this information to populate the select box for chrom/contig, andto set the
-                        maximum basepair of the track browser. You may either upload a .len fileof this format (Len File
-                        option), or directly enter the information into the box (Len Entry option).
-                    </p>
                 </b-card>
             </b-col>
         </b-row>

client/src/components/Visualizations/VisualizationFrame.vue

@@ -22,21 +22,12 @@ const iframeRef = ref<HTMLIFrameElement | null>(null);
 
 const srcWithRoot = computed(() => {
     let url = "";
-    if (props.visualization === "trackster") {
-        if (props.visualizationId) {
-            url = `/visualization/trackster?id=${props.visualizationId}`;
-        } else {
-            url = `/visualization/trackster?dataset_id=${props.datasetId}`;
-        }
+    if (props.visualizationId) {
+        url = `/plugins/visualizations/${props.visualization}/saved?id=${props.visualizationId}`;
     } else {
-        if (props.visualizationId) {
-            url = `/plugins/visualizations/${props.visualization}/saved?id=${props.visualizationId}`;
-        } else {
-            const query = props.datasetId ? `?dataset_id=${props.datasetId}` : "";
-            url = `/plugins/visualizations/${props.visualization}/show${query}`;
-        }
+        const query = props.datasetId ? `?dataset_id=${props.datasetId}` : "";
+        url = `/plugins/visualizations/${props.visualization}/show${query}`;
     }
-
     return withPrefix(url);
 });
 

client/src/onload/globalInits/index.js

@@ -7,7 +7,6 @@
  * will more properly be run inside a lifecycle handler inside of a component.
  */
 
-import { make_popup_menus } from "ui/popupmenu";
 import { monitorInit } from "utils/installMonitor";
 
 import { prependInitialization } from "../initQueue";
@@ -30,7 +29,6 @@ export function globalInits() {
         initTooltips,
         init_refresh_on_change,
         () => replace_big_select_inputs(20, 1500),
-        make_popup_menus,
         onloadWebhooks,
     );
 }

client/src/style/scss/base.scss

@@ -29,7 +29,6 @@ $fa-font-path: "../../../node_modules/@fortawesome/fontawesome-free/webfonts/";
 @import "upload.scss";
 @import "ui.scss";
 @import "library.scss";
-@import "trackster.scss";
 @import "toastr.scss";
 @import "tour.scss";
 @import "flex.scss";