Generate unique operation ids for /api/jobs/{job_id}/files

Work around a bug in FastAPI (fastapi/fastapi#13175) that assigns the same operation id to both request methods GET and HEAD of the endpoint `/api/jobs/{job_id}/files` when using the `@router.api_route()` decorator with `methods=["GET", "HEAD"]` as keyword argument.

Author: kysrpex

client/src/api/schema/schema.ts

@@ -3031,7 +3031,7 @@ export interface paths {
          *
          *     This API method is intended only for consumption by job runners, not end users.
          */
-        head: operations["index_api_jobs__job_id__files_get"];
+        head: operations["index_api_jobs__job_id__files_head"];
         patch?: never;
         trace?: never;
     };
@@ -31334,7 +31334,7 @@ export interface operations {
             };
         };
     };
-    index_api_jobs__job_id__files_get: {
+    index_api_jobs__job_id__files_head: {
         parameters: {
             query: {
                 /** @description Path to file. */

lib/galaxy/webapps/galaxy/api/job_files.py

@@ -65,23 +65,29 @@ class FastAPIJobFiles:
     # needs to include some code to handle this behavior, as tests existing before the migration to FastAPI expect HEAD
     # requests to work.
     #
-    # @router.get(  # use me when ALL endpoints have been migrated to FastAPI
-    @router.api_route(
-        "/api/jobs/{job_id}/files",
-        summary="Get a file required to staging a job.",
-        responses={
-            200: {
-                "description": "Contents of file.",
-                "content": {"application/json": None, "application/octet-stream": {"example": None}},
-            },
-            400: {
-                "description": (
-                    "File not found, path does not refer to a file, or input dataset(s) for job have been purged."
-                )
-            },
-        },
-        methods=["GET", "HEAD"],  # remove me when ALL endpoints have been migrated to FastAPI
+    @router.get(
+        # simplify me (remove `_args` and `_kwargs` defined using the walrus operator) when ALL endpoints have been
+        # migrated to FastAPI, this is a workaround for FastAPI bug https://github.com/fastapi/fastapi/issues/13175
+        *(_args := ["/api/jobs/{job_id}/files"]),
+        **(
+            _kwargs := dict(
+                summary="Get a file required to staging a job.",
+                responses={
+                    200: {
+                        "description": "Contents of file.",
+                        "content": {"application/json": None, "application/octet-stream": {"example": None}},
+                    },
+                    400: {
+                        "description": (
+                            "File not found, path does not refer to a file, or input dataset(s) for job have been purged."
+                        )
+                    },
+                },
+            )
+        ),
     )
+    @router.head(*_args, **_kwargs)  # type: ignore[name-defined]
+    # remove `@router.head(...)` when ALL endpoints have been migrated to FastAPI
     def index(
         self,
         job_id: Annotated[str, Path(description="Encoded id string of the job.")],