Skip to content

Commit 551300c

Browse files
authored
Merge pull request #21140 from mvdbeek/fix_make_client
[25.1] Use corepack to link yarn into $VIRTUALENV/bin
2 parents 0a97d14 + 5b4b389 commit 551300c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,13 @@ skip-client: ## Run only the server, skipping the client build.
180180

181181
node-deps: ## Install NodeJS dependencies.
182182
ifndef YARN
183-
npm install -g yarn;
183+
corepack enable yarn;
184184
endif
185185
$(IN_VENV) yarn install $(YARN_INSTALL_OPTS)
186186

187187
client-node-deps: ## Install NodeJS dependencies for the client.
188188
ifndef YARN
189-
npm install -g yarn;
189+
corepack enable yarn;
190190
endif
191191
$(IN_VENV) cd client && yarn install $(YARN_INSTALL_OPTS)
192192

scripts/common_startup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@ if [ $SKIP_CLIENT_BUILD -eq 0 ]; then
238238
echo "Installing yarn into '$CONDA_DEFAULT_ENV' Conda environment with conda."
239239
$CONDA_EXE install --yes --override-channels --channel conda-forge --name "$CONDA_DEFAULT_ENV" 'yarn<2'
240240
elif [ -n "$VIRTUAL_ENV" ] && in_venv "$(command -v npm)"; then
241-
echo "Installing yarn into $VIRTUAL_ENV with npm."
242-
npm install --global yarn
241+
echo "Installing yarn into $VIRTUAL_ENV with corepack."
242+
corepack enable yarn
243243
else
244244
echo "Installing yarn locally with npm."
245245
npm install yarn

0 commit comments

Comments
 (0)