Merge pull request #20822 from mvdbeek/webpack_dev_server_fix

Fix webpack dev server detection

Author: mvdbeek

.pre-commit-config.yaml.sample

@@ -8,13 +8,11 @@ repos:
     hooks:
     - id: flake8
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v2.7.1 # Use the sha or tag you want to point at
+    rev: v3.1.0
     hooks:
-      - id: prettier
-        types: [file]
-        types_or: [javascript, jsx, ts, tsx, vue]
-        additional_dependencies:
-          - [email protected] # Workaround. See https://github.com/pre-commit/mirrors-prettier/issues/29
+    - id: prettier
+      additional_dependencies:
+        - [email protected] # SEE: https://github.com/pre-commit/pre-commit/issues/3133
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.5.0  # Use the ref you want to point at
     hooks:

client/webpack.config.js

@@ -39,7 +39,7 @@ module.exports = (env = {}, argv = {}) => {
     // environment name based on -d, -p, webpack flag
     const targetEnv = process.env.NODE_ENV == "production" || argv.mode == "production" ? "production" : "development";
     // Detect if running under webpack-dev-server
-    const isDevServer = argv.$0 && argv.$0.includes("webpack-dev-server");
+    const isDevServer = Boolean(process.env.WEBPACK_SERVE);
 
     let minimizations = {};
     if (targetEnv == "production") {