Skip to content

Commit af028c9

Browse files
committed
Fix dataset view heading wrapping and consolidate loading states
Prevent line breaks in hid and dataset state while allowing name to wrap. Consolidate datatype and dataset loading states into single computed property.
1 parent 747c6d0 commit af028c9

File tree

1 file changed

+27
-5
lines changed

1 file changed

+27
-5
lines changed

client/src/components/Dataset/DatasetView.vue

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ watch(
8282
class="flex-grow-1"
8383
:collapse="headerState"
8484
@click="toggleHeaderCollapse">
85-
{{ dataset?.hid }}: <span class="font-weight-bold">{{ dataset?.name }}</span>
85+
<span class="dataset-hid">{{ dataset?.hid }}:</span>
86+
<span class="dataset-name font-weight-bold">{{ dataset?.name }}</span>
8687
<span class="dataset-state-header">
8788
<DatasetState :dataset-id="datasetId" />
8889
</span>
@@ -193,16 +194,16 @@ watch(
193194
:is-preview="true"
194195
@load="iframeLoading = false" />
195196
</div>
196-
<div v-else-if="tab === 'visualize'" class="d-flex flex-column overflow-hidden overflow-y">
197+
<div v-else-if="tab === 'visualize'" class="tab-content-panel">
197198
<VisualizationsList :dataset-id="datasetId" />
198199
</div>
199-
<div v-else-if="tab === 'edit'" class="d-flex flex-column overflow-hidden overflow-y mt-2">
200+
<div v-else-if="tab === 'edit'" class="tab-content-panel mt-2">
200201
<DatasetAttributes :dataset-id="datasetId" />
201202
</div>
202-
<div v-else-if="tab === 'details'" class="d-flex flex-column overflow-hidden overflow-y mt-2">
203+
<div v-else-if="tab === 'details'" class="tab-content-panel mt-2">
203204
<DatasetDetails :dataset-id="datasetId" />
204205
</div>
205-
<div v-else-if="tab === 'error'" class="d-flex flex-column overflow-hidden overflow-y mt-2">
206+
<div v-else-if="tab === 'error'" class="tab-content-panel mt-2">
206207
<DatasetError :dataset-id="datasetId" />
207208
</div>
208209
</div>
@@ -243,9 +244,30 @@ watch(
243244
opacity: 0;
244245
}
245246
247+
.dataset-hid,
248+
.dataset-state-header {
249+
white-space: nowrap;
250+
}
251+
252+
.dataset-hid {
253+
margin-right: 0.25rem;
254+
}
255+
256+
.dataset-name {
257+
word-break: break-word;
258+
}
259+
246260
.dataset-state-header {
247261
font-size: $h5-font-size;
248262
vertical-align: middle;
263+
margin-left: 0.5rem;
264+
}
265+
266+
.tab-content-panel {
267+
display: flex;
268+
flex-direction: column;
269+
overflow: hidden;
270+
overflow-y: auto;
249271
}
250272
251273
.auto-download-message {

0 commit comments

Comments
 (0)