Skip to content

Commit b089848

Browse files
committed
Improve responsiveness of DatasetView header
dataset name takes priority for horizontal space and state will now kick to a second line when needed.
1 parent bb447e1 commit b089848

File tree

1 file changed

+27
-10
lines changed

1 file changed

+27
-10
lines changed

client/src/components/Dataset/DatasetView.vue

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,18 @@ watch(
9797
separator
9898
inline
9999
size="lg"
100-
class="flex-grow-1 d-flex flex-wrap align-items-center"
100+
class="flex-grow-1"
101101
:collapse="headerState"
102102
@click="toggleHeaderCollapse">
103-
<span class="dataset-hid">{{ dataset?.hid }}:</span>
104-
<span class="dataset-name font-weight-bold">{{ dataset?.name }}</span>
105-
<span class="dataset-state-header">
106-
<DatasetState :dataset-id="datasetId" />
107-
</span>
103+
<div class="dataset-header-content">
104+
<div class="dataset-title-row">
105+
<span class="dataset-hid">{{ dataset?.hid }}:</span>
106+
<span class="dataset-name font-weight-bold">{{ dataset?.name }}</span>
107+
</div>
108+
<span class="dataset-state-header">
109+
<DatasetState :dataset-id="datasetId" />
110+
</span>
111+
</div>
108112
</Heading>
109113
</div>
110114
<transition v-if="dataset" name="header">
@@ -277,21 +281,34 @@ watch(
277281
opacity: 0;
278282
}
279283
284+
.dataset-header-content {
285+
display: flex;
286+
flex-wrap: wrap;
287+
align-items: baseline;
288+
gap: 0.5rem;
289+
}
290+
291+
.dataset-title-row {
292+
display: flex;
293+
align-items: baseline;
294+
min-width: 0; // Allow to shrink below content
295+
flex: 1 1 auto; // Allow to grow and shrink
296+
}
297+
280298
.dataset-hid {
281299
white-space: nowrap;
282300
margin-right: 0.25rem;
283301
}
284302
285303
.dataset-name {
286304
word-break: break-word;
287-
min-width: 0; // Allow flex item to shrink below content size
305+
min-width: 0; // Allow text to wrap
288306
}
289307
290308
.dataset-state-header {
291309
font-size: $h5-font-size;
292-
vertical-align: middle;
293-
margin-left: 0.5rem;
294-
flex-shrink: 0; // Prevent state badge from shrinking
310+
flex: 0 0 auto; // Don't grow or shrink
311+
white-space: nowrap; // Prevent state badge from wrapping internally
295312
}
296313
297314
.tab-content-panel {

0 commit comments

Comments
 (0)