Skip to content

Commit e5edfbc

Browse files
committed
Determine overflow on tab not parent level
1 parent 7f68d2e commit e5edfbc

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

client/src/components/Dataset/DatasetView.vue

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ watch(
100100

101101
<template>
102102
<LoadingSpan v-if="isLoading || !dataset" message="Loading dataset details" />
103-
<div v-else class="dataset-view d-flex flex-column h-100">
103+
<div v-else class="dataset-view d-flex flex-column">
104104
<header v-if="!displayOnly" :key="`dataset-header-${dataset.id}`" class="dataset-header flex-shrink-0">
105105
<div class="d-flex">
106106
<Heading
@@ -188,7 +188,7 @@ watch(
188188
<FontAwesomeIcon :icon="faBug" class="mr-1" /> Error
189189
</BNavItem>
190190
</BNav>
191-
<div v-if="tab === 'preview'" class="h-100 overflow-auto">
191+
<div v-if="tab === 'preview'" class="tab-content-panel">
192192
<VisualizationFrame
193193
v-if="preferredVisualization"
194194
:dataset-id="datasetId"
@@ -211,7 +211,7 @@ watch(
211211
class="p-3" />
212212
<DatasetDisplay v-else :dataset-id="datasetId" :is-binary="isBinaryDataset" @load="iframeLoading = false" />
213213
</div>
214-
<div v-else-if="tab === 'raw'" class="h-100 overflow-auto">
214+
<div v-else-if="tab === 'raw'" class="tab-content-panel">
215215
<div v-if="isAutoDownloadType && !isPdfDataset" class="auto-download-message p-4">
216216
<div class="alert alert-info">
217217
<h4>Download Required</h4>
@@ -307,8 +307,7 @@ watch(
307307
.tab-content-panel {
308308
display: flex;
309309
flex-direction: column;
310-
overflow: hidden;
311-
overflow-y: auto;
310+
overflow: auto;
312311
height: 100%;
313312
}
314313

client/src/components/DatasetInformation/DatasetAttributes.vue

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ onMounted(async () => {
9191
</script>
9292

9393
<template>
94-
<div aria-labelledby="dataset-attributes-heading">
94+
<div class="dataset-attributes" aria-labelledby="dataset-attributes-heading">
9595
<Heading id="dataset-attributes-heading" h1 separator inline size="md">
9696
{{ localize("Edit Dataset Attributes") }}
9797
</Heading>
@@ -230,3 +230,10 @@ onMounted(async () => {
230230
</div>
231231
</div>
232232
</template>
233+
234+
<style>
235+
.dataset-attributes {
236+
overflow-x: hidden;
237+
overflow-y: auto;
238+
}
239+
</style>

client/src/components/DatasetInformation/DatasetDetails.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ onUnmounted(() => {
155155
display: flex;
156156
flex-direction: column;
157157
gap: 1rem;
158-
158+
overflow-x: hidden;
159+
overflow-y: auto;
159160
.dataset-peek {
160161
word-break: break-all;
161162
}

client/src/entry/analysis/modules/CenterFrame.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function onLoad(ev: Event) {
3434
}
3535
</script>
3636
<template>
37-
<div class="h-100">
37+
<div class="h-100 overflow-hidden">
3838
<LoadingSpan v-if="isLoading">Loading ...</LoadingSpan>
3939
<iframe
4040
:id="id"

0 commit comments

Comments
 (0)