Skip to content

Conversation

@Smeds
Copy link
Contributor

@Smeds Smeds commented Nov 21, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@Smeds Smeds marked this pull request as draft November 21, 2025 19:35
@Smeds
Copy link
Contributor Author

Smeds commented Nov 21, 2025

will stay in draft mode until I can add the tool for building reference files

@Smeds Smeds closed this Nov 21, 2025
@Smeds Smeds reopened this Nov 21, 2025
</section>

<section name="reference_opts" title="Reference Options" expanded="false">
<param name="custom_reference" argument="-t" type="data" format="fasta" optional="true" label="Custom reference FASTA" help="Optional custom telogator reference FASTA file. If not provided, built-in human T2T reference will be used."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human T2T

Is this in the container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! A default human T2T (also maze and mouse) reference is included. I'm also adding the reference building tool, should be in bioconda this week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it maybe be wise to require the user to provide a reference and not rely on the once included? Right now you loose a bit of the data tracabillity since the included references are include in the source package, and it's not super clear which reference version that have been used to build the included ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproducibility is given IMO. Only transparency is questionable. Maybe also ask upstream?


<section name="reference_opts" title="Reference Options" expanded="false">
<param name="custom_reference" argument="-t" type="data" format="fasta" optional="true" label="Custom reference FASTA" help="Optional custom telogator reference FASTA file. If not provided, built-in human T2T reference will be used."/>
<param name="kmer_file" argument="-k" type="data" format="txt" optional="true" label="Telomere kmers file" help="Optional telomere kmers file (required for non-human organisms like mouse or maize)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more info in this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information about the kmer file is currently very sparse on in the repo. I have asked them to add more information about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants