-
Notifications
You must be signed in to change notification settings - Fork 489
New Tool addition: Haltools #7488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,17 @@ | ||||||
| name: haltools | ||||||
| owner: iuc | ||||||
| description: A set of tools to for manipulating HAL alignment files | ||||||
| long_description: | | ||||||
| A set of tools to for manipulating HAL alignment files | ||||||
| homepage_url: https://github.com/ComparativeGenomicsToolkit/hal | ||||||
| remote_repository_url: https://github.com/galaxyproject/tools-iuc/tree/main/tools/haltools | ||||||
| categories: | ||||||
| - Sequence Analysis | ||||||
| auto_tool_repositories: | ||||||
| name_template: "{{ tool_id }}" | ||||||
| description_template: "Wrapper for hal tool suite: {{ tool_name }}" | ||||||
|
||||||
| description_template: "Wrapper for hal tool suite: {{ tool_name }}" | |
| description_template: "Wrapper for haltools suite: {{ tool_name }}" |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,238 @@ | ||||||||||
| <tool id="hal_halstats" name="HAL halStats" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="25.0"> | ||||||||||
|
||||||||||
| <tool id="hal_halstats" name="HAL halStats" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="25.0"> | |
| <tool id="hal_halstats" name="HAL halStats" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="@PROFILE@"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define a PROFILE token in macros.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <tool id="hal_halstats" name="HAL halStats" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="25.0"> | |
| <tool id="hal_halstats" name="halStats" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="25.0"> |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <description>retrieves basic statistics from a hal file</description> | |
| <description>retrieve basic statistics from a HAL file</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <expand macro="params_inputFormat"/> | |
| <expand macro="hal_backend_format"/> |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <param name="option" type="select" label="Select a print option" refresh_on_change="true" | |
| <param name="option" type="select" label="Select a print option" |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe specify an example and considering defining a sanitizer
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <data name="out_file_csv" format="tabular" from_work_dir="stats.csv" label="${tool.name} on ${on_string}: CSV Stats"> | |
| <data name="out_file_csv" format="csv" from_work_dir="stats.csv" label="${tool.name} on ${on_string}: CSV Stats"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend your test for other parameters.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other help text would be benefits
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,112 @@ | ||||||||||||||
| <macros> | ||||||||||||||
| <xml name="requirements"> | ||||||||||||||
| <requirements> | ||||||||||||||
| <requirement type="package" version="@TOOL_VERSION@">cactus</requirement> | ||||||||||||||
| </requirements> | ||||||||||||||
| </xml> | ||||||||||||||
| <token name="@TOOL_VERSION@">2.9.9</token> | ||||||||||||||
| <token name="@VERSION_SUFFIX@">0</token> | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Introduce @Profile@ Token |
||||||||||||||
| <xml name="in_hal_file"> | ||||||||||||||
|
||||||||||||||
| <xml name="in_hal_file"> | |
| <xml name="input_hal"> |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can skip this
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditional not required here
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format please
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, will be taken care by TPV rule
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <citation type="bibtex"> | |
| @misc{githubhal, | |
| title = {HAL GitHub page}, | |
| url = {https://github.com/ComparativeGenomicsToolkit/hal}, | |
| } | |
| </citation> |
SaimMomin12 marked this conversation as resolved.
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| FromGenome, ToGenome, sitesCovered1Times, sitesCovered2Times, sitesCovered3Times, sitesCovered4Times, sitesCovered5Times | ||
| Genome_1, Genome_1, 5472, 4688, 3516, 2637, 1465 | ||
| Genome_2, Genome_1, 4688, 2637, 2637, 1172, 0 | ||
| Genome_3, Genome_1, 4688, 4688, 3516, 2960, 880 | ||
| Genome_1, Genome_2, 3516, 3516, 2344, 1465, 293 | ||
| Genome_2, Genome_2, 4270, 2930, 2930, 1172, 0 | ||
| Genome_3, Genome_2, 3516, 3516, 2344, 1788, 176 | ||
| Genome_1, Genome_3, 4725, 4725, 3553, 2381, 1348 | ||
| Genome_2, Genome_3, 4725, 2791, 2791, 1033, 0 | ||
| Genome_3, Genome_3, 6139, 4725, 3553, 3136, 880 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a long description