Remove/Fix unused variables

Author: trasher

lib/GaletteObjectsLend/Controllers/MainController.php

@@ -98,7 +98,6 @@ public function storePreferences(Request $request, Response $response): Response
         $lendsprefs = new Preferences($this->zdb);
 
         $error_detected = [];
-        $success_detected = [];
         if ($lendsprefs->store($post)) {
             $this->flash->addMessage(
                 'success_detected',

lib/GaletteObjectsLend/Entity/LendCategory.php

@@ -144,7 +144,7 @@ public function store(): bool
         try {
             $values = [];
 
-            foreach ($this->fields as $k => $v) {
+            foreach (array_keys($this->fields) as $k) {
                 if ($k === 'is_active' && $this->$k === false) {
                     //Handle booleans for postgres ; bugs #18899 and #19354
                     $values[$k] = $this->zdb->isPostgres() ? 'false' : 0;

lib/GaletteObjectsLend/Entity/LendObject.php

@@ -311,7 +311,7 @@ public function store(): bool
         try {
             $values = [];
 
-            foreach ($this->fields as $k => $v) {
+            foreach (array_keys($this->fields) as $k) {
                 if (
                     ($k === 'is_active' || $k === 'price_per_day')
                     && $this->$k === false

lib/GaletteObjectsLend/Entity/LendRent.php

@@ -148,7 +148,7 @@ public function store(): bool
             $zdb->connection->beginTransaction();
             $values = [];
 
-            foreach ($this->fields as $k => $v) {
+            foreach (array_keys($this->fields) as $k) {
                 $values[$k] = $this->$k ?? null;
             }
 

lib/GaletteObjectsLend/Entity/LendStatus.php

@@ -116,7 +116,7 @@ public function store(): bool
         try {
             $values = [];
 
-            foreach ($this->fields as $k => $v) {
+            foreach (array_keys($this->fields) as $k) {
                 if (
                     ($k === 'is_active' || $k === 'in_stock')
                     && $this->$k === false

lib/GaletteObjectsLend/Entity/Picture.php

@@ -176,8 +176,7 @@ private function createThumb(string $source, string $ext, ?string $dest = null):
                     return false;
             }
 
-            [$cur_width, $cur_height, $cur_type, $curattr]
-                = getimagesize($source);
+            [$cur_width, $cur_height] = getimagesize($source);
 
             $ratio = $cur_width / $cur_height;
 
@@ -356,8 +355,7 @@ private function setThumbSizes(Preferences $prefs): void
         } else {
             //resize if too small/large
             if (function_exists("gd_info")) {
-                [$cur_width, $cur_height, $cur_type, $curattr]
-                    = getimagesize($thumb);
+                [$cur_width, $cur_height] = getimagesize($thumb);
 
                 if (
                     $cur_height != $this->getOptimalHeight()

lib/GaletteObjectsLend/IO/PdfObject.php

@@ -129,7 +129,7 @@ public function drawCard(LendObject $object): void
                 if ($tw > 16) {
                     $wpic = 30;
                 } else {
-                    $wlogo = $tw;
+                    $wpic = $tw;
                 }
                 $hpic = round($wpic / $ratio);
             }