Fix (editor): multiple block editor JavaScript warnings (#3585)

* fix warning isEditingTemplate is deprecated

* fixed all margin warnings

---------

Co-authored-by: [email protected] <>

Author: bfintal

src/block-components/linking/index.js

@@ -44,7 +44,7 @@ export const _Linking = () => {
 	return <div
 		className="stk-linking-wrapper"
 	>
-		<Tooltip position="bottom" text={
+		<Tooltip placement="bottom" text={
 			<>
 				{ __( 'When linked, styling this block would also style other linked blocks in adjacent columns.', i18n ) }
 				<br />

src/block/map/location-control.js

@@ -62,6 +62,7 @@ const LocationControl = props => {
 			onChange={ value => {
 				props.onTextChange( value )
 			} }
+			__next40pxDefaultSize
 		/>
 	)
 }

src/components/advanced-autosuggest-control/editor.scss

@@ -1,12 +1,17 @@
 .ugb-advanced-autosuggest-control {
 	margin-bottom: 16px;
+
+	.stk-inspector-control__reset-button {
+		transform: translateY(-3px);
+	}
 }
 .ugb-advanced-autosuggest-control__select {
 	> * {
 		position: relative;
 	}
 	input {
 		width: 100%;
+		height: 40px; // Follow new WP standard.
 	}
 	.react-autosuggest__suggestions-container {
 		position: absolute;

src/components/advanced-focal-point-control/index.js

@@ -42,6 +42,7 @@ const AdvancedFocalPointControl = props => {
 				{ ...propsToPass }
 				value={ value || FOCAL_DEFAULT_VALUE }
 				onChange={ typeof props.onChange === 'undefined' ? onChange : props.onChange }
+				__nextHasNoMarginBottom
 			/>
 			<ResetButton
 				allowReset={ props.allowReset }

src/components/advanced-range-control/editor.scss

@@ -15,6 +15,7 @@
 	flex: 1;
 	display: flex;
 	align-items: center;
+	height: 40px; // Follow new WP standard.
 	.components-range-control {
 		flex: 1;
 		margin: 0 !important;

src/components/advanced-range-control/range-control.js

@@ -163,6 +163,8 @@ const StackableRangeControl = memo( props => {
 				? props.sliderMax
 				: ( props.max === Infinity ? 100 : props.max ) // Dont' allow Infinity on the slider since it will not move.
 			}
+			__next40pxDefaultSize
+			__nextHasNoMarginBottom
 		/>
 		{ withInputField && isNumberControlSupported && (
 			<NumberControl
@@ -177,6 +179,8 @@ const StackableRangeControl = memo( props => {
 				value={ value }
 				placeholder={ placeholderValue }
 				type="text"
+				__next40pxDefaultSize
+				__nextHasNoMarginBottom
 			/>
 		) }
 		{ _children }

src/components/advanced-select-control/index.js

@@ -35,6 +35,8 @@ const AdvancedSelectControl = memo( props => {
 				role="listbox"
 				value={ typeof props.value === 'undefined' ? value : props.value }
 				onChange={ typeof props.onChange === 'undefined' ? onChange : props.onChange }
+				__nextHasNoMarginBottom
+				__next40pxDefaultSize
 			/>
 			<ResetButton
 				allowReset={ props.allowReset }

src/components/advanced-text-control/index.js

@@ -66,6 +66,8 @@ const AdvancedTextControl = memo( props => {
 					value={ internalValue }
 					onChange={ internalOnChange }
 					className={ classnames( propsToPass.className, 'ugb-advanced-text-control' ) }
+					__nextHasNoMarginBottom
+					__next40pxDefaultSize
 				/>
 			</DynamicContentControl>
 			<ResetButton

src/components/advanced-toggle-control/editor.scss

@@ -4,7 +4,7 @@
 
 .stk-toggle-control .components-base-control__field {
 	display: flex;
-	align-items: center;
+	align-items: flex-start;
 	.components-form-toggle {
 		margin-inline-end: 12px;
 	}

src/components/advanced-toggle-control/index.js

@@ -50,7 +50,7 @@ const AdvancedToggleControl = memo( props => {
 			id={ id }
 			help={ helpLabel }
 			className={ className }
-			allowReset={ true }
+			allowReset={ props.allowReset }
 			value={ checked }
 			showReset={ props.defaultValue ? checked !== props.defaultValue : checked }
 			onChange={ onChange }
@@ -72,7 +72,7 @@ const AdvancedToggleControl = memo( props => {
 
 AdvancedToggleControl.defaultProps = {
 	className: '',
-	allowReset: false,
+	allowReset: true,
 	showReset: null,
 	defaultValue: '',