Skip to content

Commit 05d4066

Browse files
authored
fix (preset values): no found preset should be an empty string, not -1 (#3509)
* fix: no found preset should be an empty string, not -1 * fix: check for undefined, not if false since 0 is valid for four range
1 parent d49cf5c commit 05d4066

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/components/advanced-range-control/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,8 @@ const AdvancedRangeControl = props => {
216216
}
217217
return _value === derivedValue && ( _unit === '' || _unit === unit )
218218
} )
219+
rangeValue = rangeValue === -1 ? '' : rangeValue
220+
219221
rangeOnChange = ( value, property = 'value' ) => {
220222
if ( value === '' ) {
221223
return _onChange( value )

src/components/four-range-control/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,7 @@ const FourRangeControl = memo( props => {
381381
}
382382
return _value === initialValue && ( _unit === '' || _unit === unit )
383383
} )
384+
rangeValue = rangeValue === -1 ? '' : rangeValue
384385
rangeOnChange = ( value, property = 'value' ) => {
385386
if ( value === '' ) {
386387
return initialOnChange( value )

0 commit comments

Comments
 (0)