Skip to content

Commit 0d800b3

Browse files
fix (settings): remove lazy, use filters instead
1 parent 0ffcfdb commit 0d800b3

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/welcome/admin.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import SVGSectionIcon from './images/settings-icon-section.svg'
1111
*/
1212
import { __, sprintf } from '@wordpress/i18n'
1313
import {
14-
useEffect, useState, useCallback, useMemo, lazy, Suspense,
14+
useEffect, useState, useCallback, useMemo, Suspense, Fragment,
1515
} from '@wordpress/element'
1616
import domReady from '@wordpress/dom-ready'
1717
import {
@@ -1174,13 +1174,13 @@ const GlobalSettings = props => {
11741174
)
11751175
}
11761176

1177-
const EditorModeSettings = lazy( () => import( '../../pro__premium_only/src/welcome/editor-mode' ) )
1178-
11791177
const RoleManager = props => {
11801178
const groups = props.filteredSearchTree.find( tab => tab.id === 'role-manager' ).groups
11811179
props.roleManager = groups.find( group => group.id === 'role-manager' )
11821180
const groupLength = groups.reduce( ( acc, curr ) => acc + curr.children.length, 0 )
11831181

1182+
const EditorModeSettings = applyFilters( 'stackable.admin.settings.editorModeSettings', Fragment )
1183+
11841184
return (
11851185
<div className="s-role-manager">
11861186
{ groupLength <= 0 ? (
@@ -1223,14 +1223,14 @@ const RoleManager = props => {
12231223
)
12241224
}
12251225

1226-
const CustomFieldsEnableSettings = lazy( () => import( '../../pro__premium_only/src/welcome/custom-fields-toggle' ) )
1227-
const CustomFieldsManagerSettings = lazy( () => import( '../../pro__premium_only/src/welcome/custom-fields-roles' ) )
1228-
12291226
const CustomFields = props => {
12301227
const groups = props.filteredSearchTree.find( tab => tab.id === 'custom-fields-settings' ).groups
12311228
props.customFields = groups.find( group => group.id === 'custom-fields-settings' )
12321229
const groupLength = groups.reduce( ( acc, curr ) => acc + curr.children.length, 0 )
12331230

1231+
const CustomFieldsEnableSettings = applyFilters( 'stackable.admin.settings.customFieldsEnableSettings', Fragment )
1232+
const CustomFieldsManagerSettings = applyFilters( 'stackable.admin.settings.customFieldsManagerSettings', Fragment )
1233+
12341234
return (
12351235
<div className="s-custom-fields">
12361236
{ groupLength <= 0 ? (
@@ -1276,8 +1276,6 @@ const CustomFields = props => {
12761276
)
12771277
}
12781278

1279-
const IconSettings = lazy( () => import( '../../pro__premium_only/src/welcome/icons.js' ) )
1280-
12811279
const Integrations = props => {
12821280
const {
12831281
settings,
@@ -1289,6 +1287,8 @@ const Integrations = props => {
12891287
props.integrations = groups.find( group => group.id === 'integrations' )
12901288
const groupLength = groups.reduce( ( acc, curr ) => acc + curr.children.length, 0 )
12911289

1290+
const IconSettings = applyFilters( 'stackable.admin.settings.iconSettings', Fragment )
1291+
12921292
return (
12931293
<div className="s-integrations">
12941294
{ groupLength <= 0 ? (

0 commit comments

Comments
 (0)