fix (type scale): added responsive typescale (#3513)

Arukuen · bfintal · web-flow · commit 4173e70a87fa · 2025-06-03T16:16:53.000+08:00
* minor bug fix

* feat: give typescale responsive capabilities

* docs: add jsdoc to new utils

* Update src/plugins/global-settings/typography/utils.js

* fix: add breaks to loop to get out early

* fix: convert arrow to anonymous functino to support php 7.3 and below

* fix: prevent forearch error

---------

Co-authored-by: Benjamin Intal &lt;bfintal@gmail.com&gt;
diff --git a/src/components/advanced-range-control/index.js b/src/components/advanced-range-control/index.js
@@ -271,7 +271,11 @@ const AdvancedRangeControl = props => {
 		// Since the actual previous value is a preset, force the new custom value
 		// when changing unit
 		controlProps.onChangeUnit = ( unit, unitAttrName ) => {
+			dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
 			setAttributes( { [ unitAttrName ]: unit } )
+			if ( props.onChangeUnit ) {
+				props.onChangeUnit( unit )
+			}
 			_onChange( _newValue )
 		}
 	}
diff --git a/src/components/font-size-control/index.js b/src/components/font-size-control/index.js
@@ -34,7 +34,7 @@ const FontSizeControl = props => {
 			placeholder={ passedPlaceholder }
 			onChangeUnit={ value => {
 				// Change font-size so as not to surprise the user.
-				if ( props.value !== '' && ! isNaN( Number( value ) ) ) {
+				if ( props.value !== '' && ! isNaN( Number( props.value ) ) ) {
 					if ( value === 'em' || value === 'rem' ) {
 						props.onChange( String( pxToEm( props.value ) ) )
 					} else if ( value === 'px' ) {
diff --git a/src/components/four-range-control/index.js b/src/components/four-range-control/index.js
@@ -440,8 +440,12 @@ const FourRangeControl = memo( props => {
 			// Since the actual previous value is a preset, force the new custom value
 			// when changing unit
 			controlProps.onChangeUnit = ( unit, unitAttrName ) => {
-				initialOnChange( _newValue )
+				dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
 				setAttributes( { [ unitAttrName ]: unit } )
+				if ( props.onChangeUnit ) {
+					props.onChangeUnit( unit )
+				}
+				initialOnChange( _newValue )
 			}
 		}
 
diff --git a/src/plugins/global-settings/preset-controls/index.php b/src/plugins/global-settings/preset-controls/index.php
@@ -133,8 +133,10 @@ public function generate_css_variables_styles( $property, $presets, $prefix, $is
 
 			$presets_by_slug = [];
 			// Convert presets into an associative array with key 'slug'
-			foreach ( $presets as $preset ) {
-				$presets_by_slug[ $preset[ 'slug' ] ] = $preset;
+			if ( is_array( $presets ) ) {
+				foreach ( $presets as $preset ) {
+					$presets_by_slug[ $preset[ 'slug' ] ] = $preset;
+				}
 			}
 
 			// There is no need to generate custom presets in the editor.
@@ -176,9 +178,10 @@ public function generate_css_variables_styles( $property, $presets, $prefix, $is
 		 * @return mixed
 		 */
 		public function deepGet( $array, $keys ) {
-			return array_reduce( $keys, fn( $value, $key ) => $value[ $key ] ?? null, $array );
+			return array_reduce( $keys, function( $value, $key ) {
+				return $value[ $key ] ?? null;
+			}, $array );
 		}
-
 		/**
 		 * Add our global preset control styles.
 		 *
diff --git a/src/plugins/global-settings/typography/index.js b/src/plugins/global-settings/typography/index.js
@@ -5,15 +5,26 @@ import { GlobalTypographyStyles } from './editor-loader'
 import TypographyPicker from './typography-picker'
 import { getThemeStyles } from './get-theme-styles'
 import FREE_FONT_PAIRS from './font-pairs.json'
-import { getAppliedTypeScale, cleanTypographyStyle } from './utils'
+import {
+	getDevicePropertyKey,
+	getAppliedTypeScale,
+	cleanTypographyStyle,
+	getTypographyTypeScale,
+} from './utils'
 
 /**
  * External dependencies
  */
 import {
-	PanelAdvancedSettings, AdvancedSelectControl, ControlSeparator, FontPairPicker, ProControlButton, AdvancedToggleControl,
+	PanelAdvancedSettings,
+	AdvancedSelectControl,
+	ControlSeparator,
+	FontPairPicker,
+	ProControlButton,
+	AdvancedToggleControl,
 } from '~stackable/components'
 import { fetchSettings } from '~stackable/util'
+import { useDeviceType } from '~stackable/hooks'
 import {
 	i18n, isPro, showProNotice,
 } from 'stackable'
@@ -148,6 +159,7 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 		const _useTypographyAsPresets = select( 'stackable/global-preset-controls.custom' )?.getUseTypographyAsPresets() ?? false
 		return { useTypographyAsPresets: _useTypographyAsPresets }
 	}, [] )
+	const deviceType = useDeviceType()?.toLowerCase() || 'desktop'
 
 	const FONT_PAIRS = applyFilters( 'stackable.global-settings.typography.font-pairs.premium-font-pairs', FREE_FONT_PAIRS )
 
@@ -157,7 +169,11 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 	const [ customFontPairs, setCustomFontPairs ] = useState( [] )
 	const [ selectedFontPairName, setSelectedFontPairName ] = useState( '' )
 	const [ isEditingFontPair, setIsEditingFontPair ] = useState( false )
-	const [ selectedTypeScale, setSelectedTypeScale ] = useState( 'none' )
+	const [ selectedTypeScale, setSelectedTypeScale ] = useState( {
+		desktop: 'none',
+		tablet: 'none',
+		mobile: 'none',
+	} )
 	const [ isApplyBodyToHTML, setIsApplyBodyToHTML ] = useState( false )
 
 	const fontPairContainerRef = useRef( null )
@@ -172,22 +188,21 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 			setSelectedFontPairName( response.stackable_selected_font_pair || 'theme-heading-default/theme-body-default' )
 			setIsApplyBodyToHTML( response.stackable_is_apply_body_to_html || false )
 
-			// Reversely compute the type scale from the font sizes
-			let typeScale = _typographySettings?.h6?.fontSize
-			if ( typeScale ) {
-				const computedApplied = getAppliedTypeScale( typeScale ) ?? {}
-				const tags = Object.keys( _typographySettings )
-				for ( const tag of tags ) {
-				// If font size mismatch, set typography scale to Custom
-					if ( _typographySettings[ tag ]?.fontSize !== computedApplied[ tag ]?.fontSize ) {
-						typeScale = 'custom'
-					}
-				}
-				setSelectedTypeScale( typeScale )
-			}
+			// Reversely compute initial typescale for highlighting
+			const typeScaleDesktop = getTypographyTypeScale( _typographySettings, 'desktop' )
+			const typeScaleTablet = getTypographyTypeScale( _typographySettings, 'tablet' )
+			const typeScaleMobile = getTypographyTypeScale( _typographySettings, 'mobile' )
+			setSelectedTypeScale( {
+				desktop: typeScaleDesktop, tablet: typeScaleTablet, mobile: typeScaleMobile,
+			} )
 		} )
 	}, [] )
 
+	useEffect( () => {
+		const typeScale = getTypographyTypeScale( typographySettings, deviceType )
+		setSelectedTypeScale( prev => ( { ...prev, [ deviceType ]: typeScale } ) )
+	}, [ deviceType, typographySettings ] )
+
 	useEffect( () => {
 		// When typography styles are changed, trigger our editor style generator to update.
 		// This also triggers updating presets with typography, and applying body font size to html.
@@ -269,26 +284,25 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 	}
 
 	const updateTypeScale = value => {
-		setSelectedTypeScale( value )
-
-		// If value is custom, do not do anything
-		if ( value === 'custom ' ) {
-			return
-		}
-
-		// If value is none, reset the font sizes and units
 		if ( value === 'none' ) {
 			const selectors = TYPOGRAPHY_TAGS.map( tag => tag.selector )
-			const newSettings = selectors.reduce( ( acc, selector, ) => {
-				acc[ selector ] = { fontSize: '', fontSizeUnit: '' }
+			const fontSizeKey = getDevicePropertyKey( 'fontSize', deviceType )
+			const fontSizeUnitKey = getDevicePropertyKey( 'fontSizeUnit', deviceType )
+
+			const newSettings = selectors.reduce( ( acc, selector ) => {
+				acc[ selector ] = {
+					[ fontSizeKey ]: '',
+					[ fontSizeUnitKey ]: '',
+				}
 				return acc
 			}, {} )
+
 			changeStyles( newSettings )
 			return
 		}
 
 		// If value is valid type scale, apply to the styles
-		const newSettings = getAppliedTypeScale( value )
+		const newSettings = getAppliedTypeScale( value, deviceType )
 		changeStyles( newSettings )
 	}
 
@@ -513,9 +527,12 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 						<AdvancedSelectControl
 							label={ __( 'Type Scale', i18n ) }
 							options={ TYPE_SCALE }
-							value={ selectedTypeScale }
+							value={ selectedTypeScale[ deviceType ] }
 							onChange={ updateTypeScale }
+							responsive="all"
 							default="none"
+							hasTabletValue={ selectedTypeScale.tablet !== 'none' }
+							hasMobileValue={ selectedTypeScale.mobile !== 'none' }
 						/>
 						{ TYPOGRAPHY_TAGS.map( ( {
 							label, selector, help,
@@ -531,18 +548,9 @@ addFilter( 'stackable.global-settings.inspector', 'stackable/global-typography',
 									isAllowReset={ getIsAllowReset( selector ) }
 									onChange={ styles => {
 										changeStyles( { [ selector ]: styles } )
-										// Set typeScale to custom when editing font size or units
-										if ( 'fontSize' in styles || 'fontSizeUnit' in styles ) {
-											setSelectedTypeScale( 'custom' )
-										}
 									} }
 									onReset={ () => {
 										resetStyles( selector )
-										// Set typeScale to custom when editing font size or units
-										const styles = typographySettings[ selector ]
-										if ( 'fontSize' in styles || 'fontSizeUnit' in styles ) {
-											setSelectedTypeScale( 'custom' )
-										}
 									} }
 								/>
 							)
diff --git a/src/plugins/global-settings/typography/utils.js b/src/plugins/global-settings/typography/utils.js
@@ -1,3 +1,59 @@
+/**
+ * Returns the reversely computed typescale based on the typography settings and device type
+ *
+ * @param {Object} typographySettings - The typography settings object
+ * @param {string} deviceType - The device type
+ * @return {string} The computed typescale. Values can be none, custom, or the numeric scale.
+ */
+export const getTypographyTypeScale = ( typographySettings, deviceType ) => {
+	const fontSizeKey = getDevicePropertyKey( 'fontSize', deviceType )
+	const fontSizeUnitKey = getDevicePropertyKey( 'fontSizeUnit', deviceType )
+	const tags = Object.keys( typographySettings )
+
+	// Reversely compute the type scale from the font sizes
+	let typeScale = typographySettings?.h6?.[ fontSizeKey ]
+	typeScale = typeScale && parseFloat( typeScale ).toString()
+
+	if ( typeScale ) {
+		const computedApplied = getAppliedTypeScale( typeScale, deviceType ) ?? {}
+		for ( const tag of tags ) {
+			// console.log( typographySettings[ tag ]?.[ fontSizeKey ], computedApplied[ tag ]?.[ fontSizeKey ] )
+			// If font size mismatch, set typography scale to Custom
+			if ( typographySettings[ tag ]?.[ fontSizeKey ] !== computedApplied[ tag ]?.[ fontSizeKey ] ||
+					typographySettings[ tag ]?.[ fontSizeUnitKey ] !== computedApplied[ tag ]?.[ fontSizeUnitKey ]
+			) {
+				typeScale = 'custom'
+				break
+			}
+		}
+	} else {
+		typeScale = 'none'
+		for ( const tag of tags ) {
+			if ( typographySettings[ tag ]?.[ fontSizeKey ] ) {
+				typeScale = 'custom'
+				break
+			}
+		}
+	}
+	return typeScale
+}
+
+/**
+ * Returns the property key adjusted for the given device type.
+ *
+ * @param {string} baseProperty - The base property name
+ * @param {string} deviceType - The device type
+ * @return {string} The adjusted property key based on the device type.
+ *
+ */
+export const getDevicePropertyKey = ( baseProperty, deviceType ) => {
+	deviceType = deviceType.toLowerCase()
+	if ( deviceType && deviceType !== 'desktop' ) {
+		return `${ deviceType }${ baseProperty.charAt( 0 ).toUpperCase() }${ baseProperty.slice( 1 ) }`
+	}
+	return baseProperty
+}
+
 /**
  * Generates a typographic scale based on the given value.
  *
@@ -6,26 +62,52 @@
  * calculated using an exponential scale.
  *
  * @param {string|number} value - The base number to use for the typographic scale.
+ * @param {string} deviceType - The device type
  * @return {Object|undefined} An object mapping CSS selectors to their corresponding
  *                              font size settings. Returns `undefined` if input is invalid.
  */
 
-export const getAppliedTypeScale = value => {
+export const getAppliedTypeScale = ( value, deviceType = '' ) => {
 	const typeScale = Number( value )
 	if ( Number.isNaN( typeScale ) ) {
 		return
 	}
-	return {
-		h1: { fontSize: String( Math.pow( typeScale, 6 ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		h2: { fontSize: String( Math.pow( typeScale, 5 ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		h3: { fontSize: String( Math.pow( typeScale, 4 ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		h4: { fontSize: String( Math.pow( typeScale, 3 ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		h5: { fontSize: String( Math.pow( typeScale, 2 ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		h6: { fontSize: String( typeScale.toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		p: { fontSize: '1', fontSizeUnit: 'rem' },
-		'.stk-subtitle': { fontSize: String( ( 1 / typeScale ).toFixed( 3 ) ), fontSizeUnit: 'rem' },
-		'.stk-button__inner-text': { fontSize: '1', fontSizeUnit: 'rem' },
+
+	// These values are the exponent for the typeScale value
+	const headings = {
+		h1: 6,
+		h2: 5,
+		h3: 4,
+		h4: 3,
+		h5: 2,
+		h6: 1,
+		p: 0,
+		'.stk-subtitle': -1,
+		'.stk-button__inner-text': 0,
 	}
+
+	const result = {}
+
+	Object.entries( headings ).forEach( ( [ key, power ] ) => {
+		let fontSize
+		if ( power > 0 ) {
+			fontSize = String( Math.pow( typeScale, power ).toFixed( 3 ) )
+		} else if ( power === 0 ) {
+			fontSize = '1'
+		} else {
+			fontSize = String( ( 1 / typeScale ).toFixed( 3 ) )
+		}
+
+		const fontSizeKey = getDevicePropertyKey( 'fontSize', deviceType )
+		const fontSizeUnitKey = getDevicePropertyKey( 'fontSizeUnit', deviceType )
+
+		result[ key ] = {
+			[ fontSizeKey ]: fontSize,
+			[ fontSizeUnitKey ]: 'rem',
+		}
+	} )
+
+	return result
 }
 
 /**
diff --git a/src/util/typography/styles.js b/src/util/typography/styles.js
@@ -39,8 +39,8 @@ export const createTypographyStyles = ( attrNameTemplate = '%s', screen = 'deskt
 	const mobileFontSize = getValue( 'MobileFontSize' )
 
 	const desktopFontSizeUnit = isCSSVarValue( desktopFontSize ) ? '' : getValue( 'FontSizeUnit' ) || 'px'
-	const tabletFontSizeUnit = isCSSVarValue( tabletFontSize ) ? '' : getValue( 'FontSizeUnit' ) || 'px'
-	const mobileFontSizeUnit = isCSSVarValue( mobileFontSize ) ? '' : getValue( 'FontSizeUnit' ) || 'px'
+	const tabletFontSizeUnit = isCSSVarValue( tabletFontSize ) ? '' : getValue( 'TabletFontSizeUnit' ) || 'px'
+	const mobileFontSizeUnit = isCSSVarValue( mobileFontSize ) ? '' : getValue( 'MobileFontSizeUnit' ) || 'px'
 
 	if ( screen !== 'tablet' && screen !== 'mobile' ) { // Desktop.
 		styles = {

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,11 @@ const AdvancedRangeControl = props => {`
`271`	`271`	`// Since the actual previous value is a preset, force the new custom value`
`272`	`272`	`// when changing unit`
`273`	`273`	`controlProps.onChangeUnit = ( unit, unitAttrName ) => {`
	`274`	`+ dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()`
`274`	`275`	`setAttributes( { [ unitAttrName ]: unit } )`
	`276`	`+ if ( props.onChangeUnit ) {`
	`277`	`+ props.onChangeUnit( unit )`
	`278`	`+ }`
`275`	`279`	`_onChange( _newValue )`
`276`	`280`	`}`
`277`	`281`	`}`
Original file line number	Diff line number	Diff line change
`@@ -440,8 +440,12 @@ const FourRangeControl = memo( props => {`
`440`	`440`	`// Since the actual previous value is a preset, force the new custom value`
`441`	`441`	`// when changing unit`
`442`	`442`	`controlProps.onChangeUnit = ( unit, unitAttrName ) => {`
`443`		`- initialOnChange( _newValue )`
	`443`	`+ dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()`
`444`	`444`	`setAttributes( { [ unitAttrName ]: unit } )`
	`445`	`+ if ( props.onChangeUnit ) {`
	`446`	`+ props.onChangeUnit( unit )`
	`447`	`+ }`
	`448`	`+ initialOnChange( _newValue )`
`445`	`449`	`}`
`446`	`450`	`}`
`447`	`451`